Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 21:32:31 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@kernel.org>
Cc:     Michal Kubecek <mkubecek@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: build failure after commit eb0481bbc4ce ("objtool: Fix
 reloc_hash size")
Message-ID: <20230628193231.GX83892@hirez.programming.kicks-ass.net>
References: <20230628115825.ahqejf5y4hgxhyqj@lion.mk-sys.cz>
 <20230628151654.zqwy5zsc2cymqghr@treble>
 <20230628154432.4drtq4pivlkkg6v2@lion.mk-sys.cz>
 <20230628160631.ryt4icjeck627efs@lion.mk-sys.cz>
 <20230628164554.womrvwq7chnjtva4@lion.mk-sys.cz>
 <20230628170530.derop5w2gtmgjeis@treble>
 <20230628172659.6qwbswgz4ki24wyv@lion.mk-sys.cz>
 <20230628181019.cmgfbygxfvwamzur@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230628181019.cmgfbygxfvwamzur@treble>
Precedence: bulk

On Wed, Jun 28, 2023 at 11:10:19AM -0700, Josh Poimboeuf wrote:
> On Wed, Jun 28, 2023 at 07:26:59PM +0200, Michal Kubecek wrote:
> > I digged some more and my guess is that the problem is that
> > elf_open_read() does
> > 
> > 	memset(elf, 0, offsetof(struct elf, sections));
> > 
> > but commit eb0481bbc4ce ("objtool: Fix reloc_hash size") added
> > num_relocs after sections so that it is not zeroed (0xbabababababababa
> > is probably some kind of poison).
> 
> Argh, that memset() is subtle as heck.  Peter, why?!?

Well, at the time struct elf had a bunch of fairly large hash tables
embedded inside it. memset() on those was a significant performance fail
-- esp. since we called objtool on every .o file.

 struct elf {
   Elf *elf;
   GElf_Ehdr ehdr;
   int fd;
   char *name;
   struct list_head sections;
   DECLARE_HASHTABLE(symbol_hash, 20);
   DECLARE_HASHTABLE(symbol_name_hash, 20);
   DECLARE_HASHTABLE(section_hash, 16);
   DECLARE_HASHTABLE(section_name_hash, 16);
   DECLARE_HASHTABLE(rela_hash, 20);
 };

Those embedded hash-tables have gone away, but apparently someone forgot
about this thing :/

Yes, this can go, struct elf is no longer like that.