Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19714962rwd; Wed, 28 Jun 2023 13:11:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4M4sY+q7+6uQGZ311OTkvs2sVev8Zzfv9Yo/kLaA0M0yV5ATLd08B27+XEVDmAPRp+cm0I X-Received: by 2002:a17:90b:1808:b0:262:f798:b60d with SMTP id lw8-20020a17090b180800b00262f798b60dmr6651914pjb.6.1687983114671; Wed, 28 Jun 2023 13:11:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687983114; cv=none; d=google.com; s=arc-20160816; b=KswWGnxu25m/uRDEGVljuNhOQID+NALWIriOaYdWsFisUNVOOhY94iMGcuFLLDBo0n 9S6Rk8AHXTyJAfkzyvmqyCVEdiRgBqoFToFA3gV99RVFDOf+xC4vPhjROYJe67UDuVXC +EFICQJx23w+HNpriFYH5HnT0lMhMKGmRzWxZ3uflsvQAfmZNYSdEAJRq0zNiWgRc7Yh 9g4PM3AhGDkyTBzQwQGxZfikShU4v5IQACR7NGlRrg08YjrHYDTQJYo8//D2i8DRVACY AqlHlaZJxQ5b5n1L0qBKpu2K++FhZfP8aAQYOVWl9wb6DvJ4Zhfmc4LH899DTBgkwUmz qsBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rqjx8BFkvS49FUhfj3VfQwjT1TYgw6RhCYPNR0yTSNc=; fh=f9Txz01GlPbSDgUagXtTnJJ5slJUUNysKO2nddZvecU=; b=iAeLSxj2u+hnoiOtGikUf+oWnxnoB1HPeTlQ8n29BnDOACOWGPX/u/Cfxf63Dw9pO/ uWA2k4kJ6eVnfPIol8Gn6/uhnFnWF9j5YcPanZ7ztuU6hwfGcsrAIHVNyqe/BXb87SZ+ KuhHAJmVdFm+jZbqnWJcQl63lxfFNUWXBReKpD/fevnSHAdv6t4ys8HMzO0B3G2hV50O 33+zlf/0DWcSRh/HVft9JnT7qqkyzswus79KIZCuCNLZW60Cd+TDRgOStRe8HvV74m7z rqHK3fqoUuXyrdld42LKASdZeXM1nMiCJlhtHlC/tbYUH5qHIFBPCoBV8fxmPJb65vwg weZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="ce7xVd/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q12-20020a17090a9f4c00b00262ca5c4c12si9253519pjv.178.2023.06.28.13.11.42; Wed, 28 Jun 2023 13:11:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="ce7xVd/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231718AbjF1UCx (ORCPT + 99 others); Wed, 28 Jun 2023 16:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjF1UCj (ORCPT ); Wed, 28 Jun 2023 16:02:39 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32D592718 for ; Wed, 28 Jun 2023 13:02:31 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9920b4d8a89so23672066b.3 for ; Wed, 28 Jun 2023 13:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1687982549; x=1690574549; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rqjx8BFkvS49FUhfj3VfQwjT1TYgw6RhCYPNR0yTSNc=; b=ce7xVd/FNl5ogr8NSqwQai/kzQMgEdA1Y7krACrikRY55ryGQbkKjI7dA+f+HMMnBq WK6Qcjk9LMR5NdOnCSlazRvAk97s2AQvPlIpMjvon5W8xaMo8tX4+oEtQn9GXw9b6nqn A8/FyPHBfgOs5dAZrHQbTMYP78dnLkzWKBiR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687982549; x=1690574549; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rqjx8BFkvS49FUhfj3VfQwjT1TYgw6RhCYPNR0yTSNc=; b=Da0gNFaaa9ITnYfQsXh+GlmpJKkbKNg0cMsV8Vgf8RKRyVnqwzvvjJ+T9GNjKosoWa TkMTmXMv7AxOulBFYbSl2pNwTpQr5J2TwDD73+/r/zWeyFZlFm8QTOXTuPzfQHvneK6R NZfF8UDuy3R5s5D8rRRH49G3Sq83mTbUz2HiEPWnrHEcp3YGzDVswO9C3Ipw3KWLPCrB Dc+C1HWR03dELkvPQrAFjzVEMamhqRQ4+Rqmk5P+h+PHiltQVE7JmhvztL6qtwMP4h8u r7R/3d/HUiL9a8sBIxKlGVz09XcljVwaFPRSRwQSXCM86mIQH+KAGblMy9jjzyCP+87Q 0mfg== X-Gm-Message-State: AC+VfDyzKsuR3JwMH0A9eShaRwpVeX99zDZUD0Y1lPUgAgQdawKUdC1U DVq5XwMyc+nBV5ngUR4o+4ef0U80tJtevzHrr0grPEdw X-Received: by 2002:a17:906:5a59:b0:98d:f11e:4818 with SMTP id my25-20020a1709065a5900b0098df11e4818mr11011202ejc.36.1687982549437; Wed, 28 Jun 2023 13:02:29 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id lc26-20020a170906dffa00b00991e6951c1fsm3299043ejc.5.2023.06.28.13.02.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 13:02:28 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-51d97ba7c01so4605617a12.2 for ; Wed, 28 Jun 2023 13:02:28 -0700 (PDT) X-Received: by 2002:a50:fc13:0:b0:51d:df35:3818 with SMTP id i19-20020a50fc13000000b0051ddf353818mr57973edr.5.1687982548324; Wed, 28 Jun 2023 13:02:28 -0700 (PDT) MIME-Version: 1.0 References: <20230628020657.957880-1-goldstein.w.n@gmail.com> <20230628091241.GAZJv5ie0xVGvnMKIM@fat_crate.local> In-Reply-To: From: Linus Torvalds Date: Wed, 28 Jun 2023 13:02:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: x86/csum: Remove unnecessary odd handling To: Noah Goldstein Cc: Borislav Petkov , x86@kernel.org, edumazet@google.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, lkml Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Jun 2023 at 11:34, Noah Goldstein wrote: > > There is a reasonably robust kunit for csum_partial: lib/checksum_kunit.c > so if you happened to run the kunit testsuite with your patch, it's > probably correct. Testing? TESTING? Why do you think I do open source? I like the programming part. I even like the debugging part. But testing - that's what users are for. No? Linus