Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19814474rwd; Wed, 28 Jun 2023 14:57:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6C71cPusnCL83dyI56WH6foHckAttRvq23H86H39fiaCPQ97qqQiAtlPwwSO5ZPHz8QMGh X-Received: by 2002:ac2:4d96:0:b0:4fb:93db:fff3 with SMTP id g22-20020ac24d96000000b004fb93dbfff3mr1962641lfe.16.1687989424437; Wed, 28 Jun 2023 14:57:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687989424; cv=none; d=google.com; s=arc-20160816; b=i4NwasDRjMeil+P1dSs+L4O0A8yETBOm8PuYtACb9dCkmHUdHzPKXuXJb2uWE8dzLH geDJqc1794AsvhbyLGi6OhmLHC0P7ASPMlM7fNHKBGknc7taxh9CqdbL6JBVTrJjv092 /eNmBDno1hUZ7npiFGCLyUyJL7sCDKWKBQkWxWyyFgeRODe1qAkm1P5lGjoXFcP69Gv9 BHnVXOeDzLZCB0mIfSG1nXH0GMkCte07B1XMFirrP9atGMBYp07ZVFGVxHm1bRrMPuxM 39YbhYAHSOih6XWUswhAvaU8kOcEgzOmEi0dQEGjWRguISHlOrJG+bXRlMPdz6pvvOVm RtsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=ZOti4bFsQ+YqSH9SqMcgJmOznZL6VmfHAJFqOvYM4L4=; fh=+JAM5l4lfsVf/oWNCgQLaLBpR/v5a7fPhu8v1WgGYXU=; b=kMTv+289Osgd6VcldviXk6moEmszRGpdsn1Mxa5dup2Boxoz7akH7ePInc9biNOOYM y/WFFH3nAxbS78zM+FG0ClymchAy+sQYZUDWLs29EJ27g18mZCO345E4nUg7HV3+RKtf oiilDdcFGR+FPL8HNlzQx6Z39xPyG3rnsQapElGbdlCcPYsz64C3J+qCzgKd65MqtFP7 g/JCrzqMVQ/LLp2QTJL2XGh8CFBkNLvJ0dA6XB/tP5kT6KAzjaT0OPsQARDTH6CpOljF 3iKocjGBxINbSvmiaL7FLTOtW+vi2QCy6/8B3Z5vMTUFT+4SpFs2LDTPvkut19Jjb99v R5dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jjCJfc3O; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v24-20020a056402185800b0050d06635c10si5542075edy.529.2023.06.28.14.56.39; Wed, 28 Jun 2023 14:57:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jjCJfc3O; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231830AbjF1Vds (ORCPT + 99 others); Wed, 28 Jun 2023 17:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbjF1Vdr (ORCPT ); Wed, 28 Jun 2023 17:33:47 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0081FE3 for ; Wed, 28 Jun 2023 14:33:46 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687988025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZOti4bFsQ+YqSH9SqMcgJmOznZL6VmfHAJFqOvYM4L4=; b=jjCJfc3O3rrI2T8uWkCaRvxJJdMrPjA2uTt3mrBy8207xSrnovEThH5lDAcHk9L6Pus4/M OvzED7lctb+tS59JzWQqP7cFRg/oOtQXQlCVZ+5NgbtwSq3/F3qA7X6DSPucsl3tB7lnnp 6P1AmE+DV4FcsB2apgT8pVLFWmifXXjmuGVk1ojvy9+xrFXp/2tJjli9H4WhOzQ9BbVPzZ lRe+yQALMwRE/nUDObhYdZqCmY8hyiN/u/kpjKvZ+mZAmyalhitBlbFJ5IU/6x8IRmNdeY pOobOuYPWc0AuirNSbQe6sdbQZ2iKSlY0w8v925KbnA5+6UuM6fvp9inDnSvuw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687988025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZOti4bFsQ+YqSH9SqMcgJmOznZL6VmfHAJFqOvYM4L4=; b=Fqh2GeNZCuIvnCUGeUpBPCgJ2QJlQg+4cbn9lyVVv1xL/9x9t2LYmEAiCn6KXZ6iOWXr+1 m6miu0NNghMOzTBA== To: Linus Torvalds , Matthew Wilcox Cc: linux-kernel@vger.kernel.org Subject: Re: Reunbreak the MEM_ENCRYPT build In-Reply-To: References: Date: Wed, 28 Jun 2023 23:33:44 +0200 Message-ID: <87ttur2rwn.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28 2023 at 12:52, Linus Torvalds wrote: > On Wed, 28 Jun 2023 at 12:03, Matthew Wilcox wrote: >> >> Probably this is the wrong fix. > > No, that looks like the obviously correct fix, I just don't see how we > all missed that stale declaration. > > I guess we all had X86_MEM_ENCRYPT enabled, which hides the problem. > And other architectures wouldn't have had the issue. Sigh. I'm sure that I fixed that before. No idea how I missed it in the final reference merge (again). Sorry. tglx