Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <Frank.Li@nxp.com>
To:     rogerq@kernel.org, r-gunasekaran@ti.com, imx@lists.linux.dev,
        jun.li@nxp.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Elson Roy Serrao <quic_eserrao@quicinc.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        =?UTF-8?q?J=C3=B3=20=C3=81gila=20Bitsch?= <jgilab@gmail.com>,
        Prashanth K <quic_prashk@quicinc.com>,
        Peter Chen <peter.chen@kernel.org>,
        linux-usb@vger.kernel.org (open list:USB SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/1] usb: gadget: call usb_gadget_check_config() to verify UDC capability
Date:   Wed, 28 Jun 2023 18:24:36 -0400
Message-Id: <20230628222437.3188441-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CjRP3YKvVtgHap+HKFnHf54MYC8YXKstCa8na02Kvl/g7OhiqKtgMhUawCUN?=
 =?us-ascii?Q?1OtXG1yjNnvZfHt5IpM+C4hLH5XxotAkeNpWEHsU09zFB7ybMFjVvOctGfXs?=
 =?us-ascii?Q?yoCkgIVjG5UIXuDg/7Y0s0MoWeJD+yAxhYD5k4Lq+NQ0+fEOkW3pjC5C0J2U?=
 =?us-ascii?Q?NZ6Gz+gCK1nrW4wibXMrgfXD2QUD+nqPU4UgjROqxQd2/GBWTYZ+tzDhcYHx?=
 =?us-ascii?Q?1A0RDVx+bUlmLi1e+6wgTABSk1EgHT9uX663nHIeBzgrSPoRLfqKBA8xaVY1?=
 =?us-ascii?Q?Rby6akJ/29tTbSPf2Bzcb8V3N7KQVPWKiPT6JtC3xteQIPhvzWG4Nbk2ITHH?=
 =?us-ascii?Q?KvJXfrPV3aCtNoNQUefKzoygMOG5EBB3g55Dr3l1uR/P3XllS1+uswT8IqVF?=
 =?us-ascii?Q?FMrGVw1Q+qFbTN3RGf+qhCMoZTrP5nMPcesiianmdoh3f+aj4+npp8WdYksB?=
 =?us-ascii?Q?PC13OpqcEkydo0mizvUUpQGE1aEydgeY8JX6l0LorrJo7FLXquGtON3I+LPA?=
 =?us-ascii?Q?29PDwLAs+Nb6q1TWf9BPhWIt00nB+fHv83c/Tvqy/MQKUY0MAUFo6YlZacOD?=
 =?us-ascii?Q?h9vnI9NmlvwahHSrrL8JE0NpeafPhwegwtd2CMpQ8y1So5BH6SFp+LzyOuil?=
 =?us-ascii?Q?pJyOS0xzY4baA5V+BkH6vU8KGzfxssqZRARhtnHTZuHBxeH9SNHlPNQSOikS?=
 =?us-ascii?Q?rIjILTa8gQ72Z3UIQn0aXFPqWweBkA3EnK5+ip4Kq2BKFPo8htzuTdr9PupH?=
 =?us-ascii?Q?oJFt3GBJyljfD1v5X+VYdyg4E8+mn2yRMVWtn3qIBQv77q7ta4ioevLpzYW6?=
 =?us-ascii?Q?APGqbA5AdXwodKpp1T6V2hcuhUnT2spx5k+cqBJ3o9B0gRyjDucfaGBMLSXG?=
 =?us-ascii?Q?lJYev9nDuuWPWelGkifLObEvXAU5UBjHdWc3INljsUmTkv9Q+NVY+hkXFJEv?=
 =?us-ascii?Q?5M/W+f3+VydhUnZpTc3H2KtjSuRmNsRMWhVvOCJcuBxJc173kcuMF3KxMF/1?=
 =?us-ascii?Q?3JNwCtJc+AZLZAkcuUjtm06W4v6HmtxauWAoTyeuXQxxxJFE1FXs2WGBN/ol?=
 =?us-ascii?Q?uVv+hjApCccbi1hslXLNlqSg78x+eaTNO8vX+VMo5rYKQY/XkuU01wTqzq/t?=
 =?us-ascii?Q?YQK7A2ybAzzi8YpnBqm7tuGpNYHv5nAau3I3L6P5ElRT35nkITM7W4FOI/Ok?=
 =?us-ascii?Q?cjc0cVO6pC3HN+xXjqCOBLGO7eqfTP4HcLoaY6nyFkaR8aOO8LxzjRg7PyhU?=
 =?us-ascii?Q?Ep35Bn3ti8qI1Pbj7gJi+9QgWu/+lPg7XOL/UIVpmjs2TvTmVEMPcBCUDeTR?=
 =?us-ascii?Q?TtG/N7N6v7dOH9KZs83Wl2DRA22jugeAk42Zhn5frDV7WMkhYdg5FOs6PMrO?=
 =?us-ascii?Q?Pujtrf2VajQdf8Vj3bNpY53MddifJIXun7Jwom2E8I1WtKfu9QTNj8YVW7z5?=
 =?us-ascii?Q?Z2ln8enbYwlw3GsFFRzgFWzJ+U43X5ZPURlsR+PQf1vgvvK31oUqTVZHJkN7?=
 =?us-ascii?Q?yg4ZUKUi+i33VZABIznovo2oXa53nHUH6ZKgmRAFdJsQQGWFXsgyM5nSKObz?=
 =?us-ascii?Q?Wfc6QEhLYVUsO/56Vurp2of9sCSIqZO/H/KcEQMJ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86813297-e0c0-4536-4c10-08db78267ee9
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 22:24:53.9665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wFZY3ZKtdaU2SuRmQSalrtmXFH5AqBaHJBUbS3BW65AtuecJfTmP0ghNXsWtdu7K7TdxxLQDIQ+YB/yRuB99LQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9978
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The legacy gadget driver omitted calling usb_gadget_check_config()
to ensure that the USB device controller (UDC) has adequate resources,
including sufficient endpoint numbers and types, to support the given
configuration.

Previously, usb_add_config() was solely invoked by the legacy gadget
driver. Adds the necessary usb_gadget_check_config() after the bind()
operation to fix the issue.

Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
Reported-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/usb/gadget/composite.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 1b3489149e5e..dd9b90481b4c 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1125,6 +1125,10 @@ int usb_add_config(struct usb_composite_dev *cdev,
 		goto done;
 
 	status = bind(config);
+
+	if (status == 0)
+		status = usb_gadget_check_config(cdev->gadget);
+
 	if (status < 0) {
 		while (!list_empty(&config->functions)) {
 			struct usb_function		*f;
-- 
2.34.1