Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230627201628.207483-6-umang.jain@ideasonboard.com>
References: <20230627201628.207483-1-umang.jain@ideasonboard.com> <20230627201628.207483-6-umang.jain@ideasonboard.com>
Subject: Re: [PATCH v8 5/5] staging: vc04_services: vchiq_arm: Remove vchiq_register_child()
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     stefan.wahren@i2se.com, gregkh@linuxfoundation.org,
        f.fainelli@gmail.com, athierry@redhat.com, error27@gmail.com,
        dave.stevenson@raspberrypi.com, laurent.pinchart@ideasonboard.com,
        Umang Jain <umang.jain@ideasonboard.com>
To:     Umang Jain <umang.jain@ideasonboard.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev
Date:   Wed, 28 Jun 2023 23:46:52 +0100
Message-ID: <168799241214.3298351.10936017214708371368@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Umang Jain (2023-06-27 21:16:28)
> vchiq_register_child() is used to registered child devices as platform

s/registered/register/

> devices. Now that the child devices are migrated to use the
> vchiq_bus_type instead, they will be registered to that. Hence, drop
> vchiq_register_child() as it is no more required.
>=20

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  .../interface/vchiq_arm/vchiq_arm.c           | 22 -------------------
>  1 file changed, 22 deletions(-)
>=20
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.=
c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 75da37fa6372..3c52b09c49ea 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1778,28 +1778,6 @@ static const struct of_device_id vchiq_of_match[] =
=3D {
>  };
>  MODULE_DEVICE_TABLE(of, vchiq_of_match);
> =20
> -static struct platform_device *
> -vchiq_register_child(struct platform_device *pdev, const char *name)
> -{
> -       struct platform_device_info pdevinfo;
> -       struct platform_device *child;
> -
> -       memset(&pdevinfo, 0, sizeof(pdevinfo));
> -
> -       pdevinfo.parent =3D &pdev->dev;
> -       pdevinfo.name =3D name;
> -       pdevinfo.id =3D PLATFORM_DEVID_NONE;
> -       pdevinfo.dma_mask =3D DMA_BIT_MASK(32);
> -
> -       child =3D platform_device_register_full(&pdevinfo);
> -       if (IS_ERR(child)) {
> -               dev_warn(&pdev->dev, "%s not registered\n", name);
> -               child =3D NULL;
> -       }
> -
> -       return child;
> -}
> -
>  static int vchiq_probe(struct platform_device *pdev)
>  {
>         struct device_node *fw_node;
> --=20
> 2.39.1
>