Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a9d6824-b1f1-c711-2e24-cac48eefd9e9@kernel.org>
Date:   Thu, 29 Jun 2023 10:15:53 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3] block: add check that partition length needs to be
 aligned with block size
Content-Language: en-US
To:     Yu Kuai <yukuai1@huaweicloud.com>, Min Li <min15.li@samsung.com>,
        hch@lst.de
Cc:     axboe@kernel.dk, gregkh@linuxfoundation.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@kernel.org, willy@infradead.org,
        "yukuai (C)" <yukuai3@huawei.com>
References: <20230628083839.GA26606@lst.de>
 <CGME20230628090918epcas5p3a5463f0fc421e435a363192e40d3f649@epcas5p3.samsung.com>
 <20230628170734.2960-1-min15.li@samsung.com>
 <f8a4e061-22ab-e30b-586b-3a569f5a379a@huaweicloud.com>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <f8a4e061-22ab-e30b-586b-3a569f5a379a@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/29/23 10:04, Yu Kuai wrote:
> Hi,
> 
> 在 2023/06/29 1:07, Min Li 写道:
>> On Mon, Jun 28, 2023 at 04:48:36PM +0000, Christoph Hellwig  wrote:
>>> They are long long in the UAPI, which is weird but has been that way
>>> for a long time.  So I think we need checks for negative values
>>> before they are shifted and converted to a sector_t.
>>
>> Do you mean that we need to check if p.start and p.length are negative?
>>
> 
> Perhaps this patch will make sense.
> 
> https://lore.kernel.org/all/20230525072041.3701176-1-zhongjinghua@huawei.com/

+ adding to it the logical block size alignment checks.

> 
> Thanks,
> Kuai
>> Thanks for your reply
>>
>> Min li
>> .
>>
> 

-- 
Damien Le Moal
Western Digital Research