Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm: memory-failure: fix unexpected return value in
 soft_offline_page()
To:     Naoya Horiguchi <naoya.horiguchi@linux.dev>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230627112808.1275241-1-linmiaohe@huawei.com>
 <20230627123046.ef7e791208214bbfecd71e42@linux-foundation.org>
 <dc6f687f-926f-effd-338f-32edc7508479@huawei.com>
 <20230628110618.GA1248243@ik1-406-35019.vs.sakura.ne.jp>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <6af5c64f-3311-9a85-6d65-71f814ff9673@huawei.com>
Date:   Thu, 29 Jun 2023 09:48:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20230628110618.GA1248243@ik1-406-35019.vs.sakura.ne.jp>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/6/28 19:06, Naoya Horiguchi wrote:
> On Wed, Jun 28, 2023 at 09:56:38AM +0800, Miaohe Lin wrote:
>> On 2023/6/28 3:30, Andrew Morton wrote:
>>> On Tue, 27 Jun 2023 19:28:08 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
>>>
>>>> When page_handle_poison() fails to handle the hugepage or free page in
>>>> retry path, soft_offline_page() will return 0 while -EBUSY is expected
>>>> in this case.
>>>
>>> What are the user visible effects of the bug?
>>
>> The user will think soft_offline_page succeeds while it failed in fact. So user
>> will not try again later in this case.
> 
> I think that it's helpful to put this in patch descrition so that maintainers can
> easily guess the impact of this patch.

Thanks for your review and advice. Will add it if v2 is needed.

> 
> Anyway, the patch looks good to me, thank you.
> 
> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

Thanks Naoya.