Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 09:42:44 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <chao.gao@intel.com>, <kai.huang@intel.com>,
        <robert.hoo.linux@gmail.com>
Subject: Re: [PATCH v3 03/11] KVM: x86/mmu: Use KVM honors guest MTRRs helper
 when CR0.CD toggles
Message-ID: <ZJzhlDSE4iaUryZ8@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230616023101.7019-1-yan.y.zhao@intel.com>
 <20230616023524.7203-1-yan.y.zhao@intel.com>
 <ZJytJB+mwdU6v/XJ@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZJytJB+mwdU6v/XJ@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CnBhaxi86cu0YhAQxeHMs5/5b8kNB6VZiqS9WgSGoXqR6cA9NGZKw0G9Oihn?=
 =?us-ascii?Q?ViVTiw99jnPgSRlYK5LuefdopIHGcGfNoBdcfGWfFAc06hUjQnC2T51haLqr?=
 =?us-ascii?Q?KFjV6DNeUjqYrau87aus9Dpks1bYnafGbPfaPxCn71kvFLph6nRdAs6i7B+W?=
 =?us-ascii?Q?8rxIBlZEJybuLIQBsbvjyRSvnyU52WNSal2aAmoZXUYtpj31vWq7gc5zrgIj?=
 =?us-ascii?Q?xM21PWts965hewOKh+i2Dyv3oKr+zAKVeIE7ejQL/XQ9LYmxzOjz6j1APRnY?=
 =?us-ascii?Q?PL0VeKgWSc/ixXX2Agi4JCZk+TgdRbvTZsOcD3W+aHQwb+Jb/PdSj8qD7975?=
 =?us-ascii?Q?9lTpIsaK0zWhhWxZNbpiF3XMVutzwTPa7l/lrNVXzqSt05CW4cLJ9GIsRm9t?=
 =?us-ascii?Q?xH7r1EUhQYUpgUI0yoDMw2Rq2GjeEQg+in1XmqqH3HQCIdyVggR8vCTnLt93?=
 =?us-ascii?Q?XIuNz9wHvzD0zeByYepiQPZREvHA1/k73oNNj0Nt/WATRCcGo87+GKqiGc1a?=
 =?us-ascii?Q?zW9XGkXqPEzw/FLqcfxqWTRROyRbcw9C0W80QYnEegtQDmyfZ7yiADLElP97?=
 =?us-ascii?Q?dyF7mqBDctmqEr8FT84SMWmQsBNCHkh49omROKivgO1ear2Fhq7elRGvekWs?=
 =?us-ascii?Q?/yPsZDmVQkvuInj6n2gxq3T2wkRNIucF00juve+rym6ac8NXHiP8KdRCSezS?=
 =?us-ascii?Q?Gifaw+dGj/ktX2/ulH4I4Mk+Yk3/NIrMBW8SUtskvNQ0BfLM9N4VCtlJec8H?=
 =?us-ascii?Q?2ro4YaGVFeKIp089I6taMkXKTjGU7p2e1t9OsLBoQfWFurDKJi4SUuKcSIub?=
 =?us-ascii?Q?rYBk8oVYKKJk+xZNVi2E8MZMOIJKFaSr8E1EJRiL4+1yozLF2hdCDx/IRg9D?=
 =?us-ascii?Q?tTjUr8QhyBxtXKIWLEOQbYpzJ2oT7wo1IS0UsW46XiBpqDGxpHgDa/To/JdO?=
 =?us-ascii?Q?7VMCineMb8xMToFiw4LAH7VyEbkfW10idvBHt/s0niHC5sZl1ptuuc0GQ2Oo?=
 =?us-ascii?Q?KmgoXc9fwnoX2p/7Y49K8wpq4g9aY//nJ6u0rZ08P8F+54WXlLA9fn4cqr/D?=
 =?us-ascii?Q?Y0KkoDUK5C8xMtrYiWQoKor7ueOQTfk3htD73omyRkHKRgd9J+WxMdmn25aj?=
 =?us-ascii?Q?Is+blWptEtAYpAqYUUZePzQIek+QEbDzcmSD31N/MpxmAiqCnKu511oeyCGm?=
 =?us-ascii?Q?FHoe5nzE1eq1VDOCPwvJotTSLgDmuHAybbCdQXtn2PAcNDGgnTi/ojaSZwlt?=
 =?us-ascii?Q?31klkryoHsUG6FVfiD3x20ifNmrzJRlwXWHXG1a7mU0bk/qhZnRbbkoEbIah?=
 =?us-ascii?Q?9P7+g11a2Bt8G3Jeg877CWjWe3374IZDNa2Div0oVf8embv10VoSJ1wWwiAR?=
 =?us-ascii?Q?PrReWwqApdVRAUArZt4Oo/IUxkk3QG2/cIGvNJZEipHjpytzsFGNclsOfKmd?=
 =?us-ascii?Q?FMllEwdkLFJ2H3eiMMR/sSjsM66wsYE6gZr1eTP1lI2AEHMCimz+rxex8pg0?=
 =?us-ascii?Q?5tDercqyp4RDWXkkYcwsCKywlmsEizAek7zuSoRRUAuzS642VbZoVdGZNn/k?=
 =?us-ascii?Q?kv5uXiECUiI6MZvO+qqTj8K9iSK5TDCNq7SPTRsC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df35b44d-ddbd-4eba-f558-08db7845aea3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 02:08:08.8041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u5e6fO44jUc8RhpbpjAqtok1Rl6EMxSHKuDQdgFwK0b57sRLPWirNx9QZzjhYDLywseQX4b/0N0NsUfS1Ztm6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8455
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 28, 2023 at 02:59:00PM -0700, Sean Christopherson wrote:
> On Fri, Jun 16, 2023, Yan Zhao wrote:
> > Call helper to check if guest MTRRs are honored by KVM MMU before zapping,
> 
> Nit, state the effect, not what the code literally does.  The important part is
> that the end result is that KVM will zap if and only if guest MTRRs are being
> honored, e.g.
> 
>   Zap SPTEs when CR0.CD is toggled if and only if KVM's MMU is honoring
>   guest MTRRs, which is the only time that KVM incorporates the guest's
>   CR0.CD into the final memtype.
> 
Thanks! Will update it.