Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 09:51:53 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <chao.gao@intel.com>, <kai.huang@intel.com>,
        <robert.hoo.linux@gmail.com>
Subject: Re: [PATCH v3 09/11] KVM: x86/mmu: serialize vCPUs to zap gfn when
 guest MTRRs are honored
Message-ID: <ZJzjuW8ytOuNhrzY@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230616023101.7019-1-yan.y.zhao@intel.com>
 <20230616023945.7570-1-yan.y.zhao@intel.com>
 <ZJy7pyQYmuYTXC67@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZJy7pyQYmuYTXC67@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b+ziU5ag890Evv6h+v0c1+/1gqPSvd+9QkxIkkL/zfUJlrBr1ytTANLAZkn0?=
 =?us-ascii?Q?A5VQFo9cd2ZTqIPoJ1vYuP5YbsRdyaUeCEaK5gDOpJWYbtreqP9IbYfNnV0w?=
 =?us-ascii?Q?GtLkEaSKzYjpX9r1ql22lNbS2aJzRiTgOFBa57gwzTDGVVptRFTgn8HpgYMv?=
 =?us-ascii?Q?UV+iLi0c0Olsim351A7PLWurMdKOwDv7htLUeAoukxXco1umO5W0hOw9EwZ1?=
 =?us-ascii?Q?PppRTa9dBRaUQ7iYm4DGek2XKjGLBSzs7JmnuEVR8vRMU5BdH81Z2PYY4nNF?=
 =?us-ascii?Q?j7qw2vpp2/PeU8LtvOUPu5FAhMEjvO7fZDX0zPAcOkNBZJNfQ57Z2C9DkizP?=
 =?us-ascii?Q?QNH7p0W1VBzi3rf8xPiUHKm1k517NRjC8oa4//5h+APY09M0jBWTCclFrybZ?=
 =?us-ascii?Q?d+Ck/xRQ39oWZ0hRq1Tyskn6bhtzNiZdyAZ4gGDIAmvVgyFua8ZCj7WfNUTs?=
 =?us-ascii?Q?fRloFrosHk4k2bhGVgHMMqodlmjSVvnbXGh5Tpe6kJx+7GWOknE/2uzQwcUL?=
 =?us-ascii?Q?oOFj3w1/jrLXrYb/BGnVR3W0EEn62IpLaXgc8itBp4wUYEWCWHzLZoUy6EL+?=
 =?us-ascii?Q?dtSj8Wz27EiCtGbZvmZNEOeE/W3fM/ng95yD9BoS9Uj/4TRoLm7DaoH7Lgv4?=
 =?us-ascii?Q?GJntJ5q9P0XVePs2jkw+DKzt7rvFjGHWYG+7TbXO+ZF1RtS+YZ48Ft9lrrhu?=
 =?us-ascii?Q?ypRqm24OJW3y6fRuK/eRveLFR3DeicjABbZnwthNwib6RXcKUElw5a3E3Wdv?=
 =?us-ascii?Q?cCenrCkltNtSHtxt6upb18h2a6XIqnua3jxvE5JjAF1B7g4ElFtTgBgfstqg?=
 =?us-ascii?Q?rUMfS2XDqfUOzsSvjVMYo2QJLMo6RtvDfYd4kInOTr8WjMsuz2TwqrxarChZ?=
 =?us-ascii?Q?/09sppq8vdRok8NseWe4LAosOIo/rV7Rn190Y3D8CmiCdT9EApDKse9hM4H7?=
 =?us-ascii?Q?oib6lVpkNlFMlVEYXGxlE7pw8D34VYEBfkocES1om1hNU3niOOv6vWa3SdKa?=
 =?us-ascii?Q?6aePL4KAKoPgmUfiIMM7wVzsWULV+CzfDIlwXPWiiuWFioyPDxxj7k7TjHAv?=
 =?us-ascii?Q?sREzlL7Z8lMVdqtZSmonnTCIclaDm1+JYnnJq4GMmnldYeslr5NgtpqKPwhc?=
 =?us-ascii?Q?9fED6S76QNDajWzo2tDiwXTzN15asUd689MblHoUTdPpSNa2WcYu+8KtNPec?=
 =?us-ascii?Q?wvbckzP9YvOA641vgd1NIGjb8LKrJ1qcsc5lGTzCWbWUlXAkUGNi7QvjEkdV?=
 =?us-ascii?Q?1ua1D2YUE+2DVP0dLQEC3p9VFuOMewJKzPmgVw/PVlZuPq9q8aNzmorRTNgf?=
 =?us-ascii?Q?kBDiDjsJHvPTSUzFwyJIr2+wh/yomfIbSex2L14ftMdffBvdu0BPPfRMiFfU?=
 =?us-ascii?Q?IiVtdxilSzL3S6ZZxeQBHu2A14hhmzQS7llg+v0fA/NxYTvYfHtL6Qhvt3sZ?=
 =?us-ascii?Q?c0BJ7Gboavu6762jEFNFU81A3bRp8mP1PUlQ93uGMwHEK4S6M8rtxkNro8zx?=
 =?us-ascii?Q?skJmuCJnzVJ/FJ46mQOxiI4Xb8329QG2rHKIXA0JZDwHg2mbf39rLUIDRawu?=
 =?us-ascii?Q?djfZwuczMz2TXx/kw8YMbTcR4HuqIr8vSwRFF2+V?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5be66ff-ea73-4ab7-99a4-08db7846f78d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 02:17:20.1212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bdr6btilllj7mRhUxnqGz9+y31aTzZSN2LIXAZ2pdg2w45/A7IQKAzELprxs169hMNAfeabn5vHSnTOmyGLcTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7386
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 28, 2023 at 04:00:55PM -0700, Sean Christopherson wrote:
> On Fri, Jun 16, 2023, Yan Zhao wrote:
> > diff --git a/arch/x86/kvm/mtrr.c b/arch/x86/kvm/mtrr.c
> > index b35dd0bc9cad..688748e3a4d2 100644
> > --- a/arch/x86/kvm/mtrr.c
> > +++ b/arch/x86/kvm/mtrr.c
> > @@ -25,6 +25,8 @@
> >  #define IA32_MTRR_DEF_TYPE_FE		(1ULL << 10)
> >  #define IA32_MTRR_DEF_TYPE_TYPE_MASK	(0xff)
> >  
> > +static void kvm_mtrr_zap_gfn_range(struct kvm_vcpu *vcpu,
> > +				   gfn_t gfn_start, gfn_t gfn_end);
> >  static bool is_mtrr_base_msr(unsigned int msr)
> >  {
> >  	/* MTRR base MSRs use even numbers, masks use odd numbers. */
> > @@ -341,7 +343,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
> >  		var_mtrr_range(var_mtrr_msr_to_range(vcpu, msr), &start, &end);
> >  	}
> >  
> > -	kvm_zap_gfn_range(vcpu->kvm, gpa_to_gfn(start), gpa_to_gfn(end));
> > +	kvm_mtrr_zap_gfn_range(vcpu, gpa_to_gfn(start), gpa_to_gfn(end));
> >  }
> >  
> >  static bool var_mtrr_range_is_valid(struct kvm_mtrr_range *range)
> > @@ -437,6 +439,11 @@ int kvm_mtrr_get_msr(struct kvm_vcpu *vcpu, u32 msr, u64 *pdata)
> >  void kvm_vcpu_mtrr_init(struct kvm_vcpu *vcpu)
> >  {
> >  	INIT_LIST_HEAD(&vcpu->arch.mtrr_state.head);
> > +
> > +	if (vcpu->vcpu_id == 0) {
> 
> Eww.  This is actually unsafe, because kvm_arch_vcpu_create() is invoked without
> holding kvm->lock.  Oh, and vcpu_id is userspace controlled, so it's *very*
> unsafe.  Just initialize these in kvm_arch_init_vm().
Will do. Thanks!

> 
> > +		spin_lock_init(&vcpu->kvm->arch.mtrr_zap_list_lock);
> > +		INIT_LIST_HEAD(&vcpu->kvm->arch.mtrr_zap_list);
> > +	}
> >  }