Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee27ca83-a144-7468-4515-efa93f01aa43@vivo.com>
Date:   Thu, 29 Jun 2023 11:44:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 1/7] block: add queue_logical_block_mask() and
 bdev_logical_block_mask()
To:     Matthew Wilcox <willy@infradead.org>
Cc:     axboe@kernel.dk, song@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, xiang@kernel.org, chao@kernel.org,
        huyue2@coolpad.com, jefflexu@linux.alibaba.com, hch@infradead.org,
        djwong@kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
        linux-xfs@vger.kernel.org
References: <20230628093500.68779-1-frank.li@vivo.com>
 <ZJxj6odz49iB5Mmm@casper.infradead.org>
From:   Yangtao Li <frank.li@vivo.com>
In-Reply-To: <ZJxj6odz49iB5Mmm@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1hWcDMyWHk4L1RhdnRnMHBuSWZadVVOMURuYWIzRzJqN3ROTFIwV3BhaEQy?=
 =?utf-8?B?OXUvR1plREFJMHNIQkg4ckRKcW5ZVE5GaHFqRllGY1BYRW9kdGV2WlNydVp0?=
 =?utf-8?B?ZmZLOXRUbnlVdVUrcGdaQS9INWxpTUhtT1phWFFPWUQ5VGNkSStxNEIzcmtB?=
 =?utf-8?B?MnlSRW03RVJNYXFFeXMzTmV2dEhwcVZyR3lpM2tYMmswcjF3UHdzWkltc05I?=
 =?utf-8?B?Z1FBT3J2anpyVXN4VnhqaTFlS3BXbUFEK0dVSFROaU5DQzEvYzB3VUhsb2Uy?=
 =?utf-8?B?OXB4VzlVenNVL2tlMnQ2S1lZUVpkN1lzTEVtcFR4dEVqZlQ5bmhqM1BscFU0?=
 =?utf-8?B?UGd5RXRWQTlSNkVnbUtLNHB6L245NXlZSTJnc3V6YzlBQmZDdUNMSVpPS05H?=
 =?utf-8?B?cHNJdHYwS0pCdWEzdm0xY3JHcGllandoaW9zeDhRSEN5Z3lyTnpkeXg5V2JQ?=
 =?utf-8?B?ZVJvNjk4NGlVcjNRcjhXVDFLZ2tJeXdWK2MrZkZoQ2lQaHJQWVVqYXoraExR?=
 =?utf-8?B?ZE1xcEcxY0Z6QjludWRyZjJaVnEwSVIra2dpOFZpaVhlQkxsc2VIakdLaXl5?=
 =?utf-8?B?V3NmVnNQU0ZreGtTaUtwdm1zQWlNaUEwY1JYeHNZVnd3TUVwaGFTNU5RVHhN?=
 =?utf-8?B?RXJVZTRiU05YNmQ4aGhYUFRrU0FmSG5jeXExTUY1U3NPNEF6OUV3QnVDNEEw?=
 =?utf-8?B?c2dxQ2ozVlpRKzlWM0l1RzllSHhMN0NmbmhaSml2Ymo2Nzc3QXV0MUpPL2wz?=
 =?utf-8?B?em5ZNFplSW8zSWRrdVpWUlpJc01jUW5vTnlsRk9Vb2dqN3hKTkpGZ0tWL3hF?=
 =?utf-8?B?aUlxdTlsWUtVMndLcnFTUllTTkd3NmpaQVF2NldsTGtHL1pqS2pieWU2VTVD?=
 =?utf-8?B?am1ndzNZQ0JVbi9mYUNMb3k2emxEeVZDOTR1Vkl5UGpxaFkxVDMwSlU0NVln?=
 =?utf-8?B?RVpjcVRxbWJRSGR1b0JKUzMrdGcrdU04UVdLU0ZZTytFUTVIOHloL2FBWmRo?=
 =?utf-8?B?bjAvRVVzRmFhUGVlaVBvQTU5WS9vMk5nRTFTb2dzNkI1SXpPQ0l3SzkvV2pu?=
 =?utf-8?B?VW94RjNiYkh5dCtCMXpTc0RkQmdwQkhUOVNybEVFYXlmZ3VPVjBOcmlKcENh?=
 =?utf-8?B?cEVud2xOa2I4TXdScy9Da3lVNDdsNnFzMUtUWEJNc29kSVAwcHo0djBqajVD?=
 =?utf-8?B?U3AyL3VPOEtyQ2JpemRLQUhNdU51Wk1STlU0bk01L25veVRmSk1vZ3NPcmhJ?=
 =?utf-8?B?TVQzOWVBa2drbzNYL2xxZEc5emFVWGpXSVh6T1FHbXlKL2RwZHVJWnJ0V1p1?=
 =?utf-8?B?QVVLc29IRWp3d1BweHlPY2RlUDZveHZkaEpmdkU2L3AyVlVZYXhvMmFHQ1l2?=
 =?utf-8?B?ckZZZlh3dU5zanY4czhEQ25JREN0aEdQR2xyUUV5SVh0RS9sQkdUaHR4QVJt?=
 =?utf-8?B?QlFGR0tMeDVZWDBrMnhxSlZ3aTA5YjFMTkY2MVNFeUhuVGdjS3Q2SUk0OURy?=
 =?utf-8?B?R3VDaUxQWEpEeEtNSGQ2VWswZ0pLeXR6U2ltYVo2UGRCTDFhbm56Q0VKYUx0?=
 =?utf-8?B?RGFvczk0WFhjdldoMXd2RFl2cU5SK1Q3MFErYyt2SEZFeUNzdUgrYTlHUzNi?=
 =?utf-8?B?aHlUa1FyZ25NcjlkVTltNmhaSTRLS29uc2R5MnJRbVN0dlpuazRrVDhNVHVP?=
 =?utf-8?B?bnRnWHdqTVFwOTdsZUdCaWJDaDlHc2J5VkIyd2NDaDFGdXdGbE5VcDhycXBh?=
 =?utf-8?B?U3RjbHdJdlIrWU1lY3BtcksyTGJ1N1FtVzZZcGhpOE5zRC8wdlorZ3gvdTZK?=
 =?utf-8?B?aXh2am1OVEpYcjBBT1hiTGJ4R2NlQndhRS8zZ3J1c0loVndwNjRZQUt4M0FD?=
 =?utf-8?B?UlpCenJkTjJkVHJFekh2cTBocE1vQUg3blZKWHhJbzlIYnQ5ZnNKa25kTmYv?=
 =?utf-8?B?NkZsNkNqU0FqdGx6L2tvRjRWelpIano1VFJVZHBVeXBXdTE5cmtpVHZuVGhG?=
 =?utf-8?B?dEdlbllhRldXcXhGZG04ekI3L3BRbkJKMFNmVDNEck53M29mWDF1L2ZmSFk3?=
 =?utf-8?B?RFFLN0Uzb0dIdkJXUWZDVFlBN0NpZlBXV0c4S01VQ0NiL1BwejBhakJNTHBr?=
 =?utf-8?Q?YVU6Fj+ZQlfEhECBoDD8s76xr?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29630706-8e9d-4152-3a2b-08db78532bcf
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 03:44:41.9906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eEQfGYhmsrO+wgcOJN8QbCczw65GxZTEgfnJA53ZaDHebqt0SgR6pbbnSIJkmDp7ryB8ACBH25mSOooPtpjUFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6433
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/6/29 0:46, Matthew Wilcox wrote:

> On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote:
>> Introduce queue_logical_block_mask() and bdev_logical_block_mask()
>> to simplify code, which replace (queue_logical_block_size(q) - 1)
>> and (bdev_logical_block_size(bdev) - 1).
> The thing is that I know what queue_logical_block_size - 1 does.
> That's the low bits.  _Which_ bits are queue_logical_block_mask?
> The high bits or the low bits?  And before you say "It's obviously",
> we have both ways round in the kernel today.


I guess for this you mentioned, can we name it bdev_logical_block_lmask 
and queue_logical_block_lmask?


Thx,

>
> I am not in favour of this change.  I might be in favour of bool
> queue_logical_block_aligned(q, x), but even then it doesn't seem worth
> the bits.