Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 21:30:31 -0700
From:   Sumitra Sharma <sumitraartsy@gmail.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Hans de Goede <hdegoede@redhat.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
        Fabio <fmdefrancesco@gmail.com>, Deepak R Varma <drv@mailo.com>,
        Sumitra Sharma <sumitraartsy@gmail.com>
Subject: Re: [PATCH] fs/vboxsf: Replace kmap() with kmap_local_{page, folio}()
Message-ID: <20230629043031.GA455425@sumitra.com>
References: <20230627135115.GA452832@sumitra.com>
 <ZJsg5GL79MIOzbRf@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZJsg5GL79MIOzbRf@casper.infradead.org>
Precedence: bulk

On Tue, Jun 27, 2023 at 06:48:20PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 27, 2023 at 06:51:15AM -0700, Sumitra Sharma wrote:
> > +++ b/fs/vboxsf/file.c
> > @@ -234,7 +234,7 @@ static int vboxsf_read_folio(struct file *file, struct folio *folio)
> >  	u8 *buf;
> >  	int err;
> >  
> > -	buf = kmap(page);
> > +	buf = kmap_local_folio(folio, off);
> 
> Did you test this?  'off' is the offset in the _file_.  Whereas
> kmap_local_folio() takes the offset within the _folio_.  They have
> different types (loff_t vs size_t) to warn you that they're different
> things.
>

Hi Matthew,

When creating this patch, I read and searched about the loff_t vs size_t.
By mistake, I implemented it in the wrong way.

Also, I did not test it and just compiled it. I apologise for doing so.

And for the other points you have put as feedback. I will take some time to understand
it. And would like to work on the changes you suggest.

Thanks & regards
Sumitra