Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbXJUUAt (ORCPT ); Sun, 21 Oct 2007 16:00:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751750AbXJUUAm (ORCPT ); Sun, 21 Oct 2007 16:00:42 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:60721 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbXJUUAm (ORCPT ); Sun, 21 Oct 2007 16:00:42 -0400 Date: Sun, 21 Oct 2007 22:02:14 +0200 From: Sam Ravnborg To: "H. Peter Anvin" Cc: Gabriel C , Linux Kernel Mailing List , Ingo Molnar , Gabriel C , Thomas Gleixner Subject: Re: some kernel headers broken in current git ? Message-ID: <20071021200214.GA6250@uranus.ravnborg.org> References: <4719174A.7020004@googlemail.com> <471AD5AD.9030000@zytor.com> <471B2918.5090502@googlemail.com> <471B487C.5080209@googlemail.com> <471BA564.3040305@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <471BA564.3040305@zytor.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2582 Lines: 77 On Sun, Oct 21, 2007 at 12:15:48PM -0700, H. Peter Anvin wrote: > Gabriel C wrote: > >>>BITS_PER_LONG was originally set in : > >>> > >>> 39 #ifdef CONFIG_X86_32 > >>> 40 # define BITS_PER_LONG 32 > >>> 41 #else > >>> 42 # define BITS_PER_LONG 64 > >>> 43 #endif > >>User land does not know anything about 'CONFIG_X86_32' right ? > > Wait... this is *user mode* code at this point? No - it is a kernel module. But what a messy codebase to look at... > > Linux kernel headers aren't includable from user space without > processing them through "make headers_install". > > However, from looking at the filenames in your list, it doesn't look > like userspace code at all (although they're wrappered to the degree > that it's somewhat hard to tell.) Thus, you're building a kernel > module, not userland. > > >That is the problem. I've changed the headers virtualbox need from > > > >#ifdef CONFIG_X86_32 to #ifdef __i386__ and all compiled fine. > > > >( subarch headers includes are changed manually still but I think it is > >the same problem ) > > > >Also all the headers got these defines with CONFIG_X86_32 does not work. > > > >... > > > >#ifdef CONFIG_X86_32 > ># include "foo_32.h" > >#else > ># include "foo_64.h" > >#endif > > > >... > > > >results in including both header files on my i686 box. > > > >I don't know what the right way is to fix that , define some who > >CONFIG_X86_32 to __i386__ ? or just s/CONFIG_X86_32/__i386__/ ? > > It sounds like something is seriously broken in your setup, or in the > VirtualBox makefiles. From the looks of it, I would say the latter. >From the file "the-linux-kernel.h": /* * Include iprt/types.h to install the bool wrappers. * Then use the linux bool type for all the stuff include here. */ #include #define bool linux_bool And that file named "types.h" is not a kernel types.h - so we miss that file. I guess it was pulled in by some other headerfile in the past. But I also notice that it latest source from VirtualBox the line number for include of spinlock-h does not match. This is most likely a combination of VirtualBox doing strange strange things and some deep dependency missing in one of the headerfiles. Add a #include to the-linux-kernel.h and let us know if it helps. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/