Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp20357491rwd; Thu, 29 Jun 2023 00:53:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4opySrUUlKNev0la9FvNTnFqL82BbgVrTM6NCYPxkiJe5YyOp+Kw+ewKg5faYMMXRZ2cvE X-Received: by 2002:a05:6358:a11:b0:134:c771:bff8 with SMTP id 17-20020a0563580a1100b00134c771bff8mr7662322rwa.26.1688025223476; Thu, 29 Jun 2023 00:53:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688025223; cv=none; d=google.com; s=arc-20160816; b=oCs2LrXt8ggzkpQiLt54Xh+odPzf0Qg8u6oqAaISkjzR5ul00Mkix3roh1Kz/6e8hD upOS0F9enNfyAEE5VkDWhFDdHuJIobYQXTz5AOIwa5hfDelFjPrc3JfHn3Astk8jazqj My4M0rmX1d357GoWBSqK7cty+XsVSiFD8fGEExpYH34B71C0r0jnahnzjsSQNXdWdY6k FNCzPsj7tK3nC8Zc6/cZ73GBD+CBaMmug9rryv5+TxxEzZrEuDD3G4c2Q7V5hfzwdstj QPJwL5t10az/cT1/VaJR3IY+7RSNXPFBFo4Uz/YAtI801mE3tQJQyWawKnz7LHa/Yv1L lBBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WO2Pk4RvEwUKcqC3zK5xDq5WvCKQJzHvaYR/UXIIXfs=; fh=7gp2iuX/w2+qbZxKGAfvyJh0N63CxlCa4EyN5LLaVI4=; b=eOMlMJ+SvwczYe2N65PNT2h8Kf7u/JCvP6Mb/mtvvpwqWgKi/Mhqcz5AVyaWldN/S8 pfKi5IwUW7E225hjDNr+c9Y+DWUXzKbrTj98TJFyyh7jniuFPvSOQwjwDDqnkktW3wrI 6BDH2Cy0KhyUBbPRuj7JNuelaNVxevOlw0KBHuqDWKehNoCLcLmK1Og+gC8vE3d6FAdj UsK9ruu/Bl5+UpmMNWPjcSxcnfX5FhG5d6H9dneSoHT9z58uOyDlk7Di4nYlR+eEv9qD LtF7IkZLE1dnTpmbEM8DeCbJ7V9zpK9KrArV18amUeAsMnfSLVQYTFxzpHq+c5DV6qvV dWVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=r3VdmzsN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v34-20020a634822000000b005533f251ea7si10386532pga.122.2023.06.29.00.53.30; Thu, 29 Jun 2023 00:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=r3VdmzsN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232269AbjF2Hbq (ORCPT + 99 others); Thu, 29 Jun 2023 03:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232238AbjF2HbY (ORCPT ); Thu, 29 Jun 2023 03:31:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F32EA2D52; Thu, 29 Jun 2023 00:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WO2Pk4RvEwUKcqC3zK5xDq5WvCKQJzHvaYR/UXIIXfs=; b=r3VdmzsNXfUzy46QSIw7zIiY5w 1hgbjQLrGgLDrm0juIusovpWpQrdruw/srVsDzU5IuNkGyZXUzw4bxdphVbYH4Xg4WAJVSd6IwMLy x9WUZlwf6PkiSP7TZwdgrvPxbh0mqnVe/4pxcKve2ihU0sRxdCISWU7R3cvQ18j+Tjhdcq7u2ZhXb M4D4VFchOv8J9BMFaRKEemeSvCW2Av34GBPE6e98KOhdtnzPFyMS5042Tt5ef+4XWdt+DukGQwiOg axw2wpiebY5cTb6sPLreNHM1ZopTK08q0MupEIyU6tXktJ2NQR2+FuNFsh99FsqZEcYf2W826+Ud4 0XTMg+3A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEm7V-000Ct9-30; Thu, 29 Jun 2023 07:31:13 +0000 Date: Thu, 29 Jun 2023 00:31:13 -0700 From: Christoph Hellwig To: "Andreas Hindborg (Samsung)" Cc: Christoph Hellwig , Ming Lei , Hans Holmberg , Aravind Ramesh , Jens Axboe , "open list:BLOCK LAYER" , Matias Bjorling , open list , Damien Le Moal , gost.dev@samsung.com, Minwoo Im Subject: Re: [PATCH v4 3/4] ublk: enable zoned storage support Message-ID: References: <20230628190649.11233-1-nmi@metaspace.dk> <20230628190649.11233-4-nmi@metaspace.dk> <871qhuzpxr.fsf@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qhuzpxr.fsf@metaspace.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2023 at 09:25:32AM +0200, Andreas Hindborg (Samsung) wrote: > If you prefer the latter, I can change it back, no problem. But I must > say I think it comes off cleaner when we move as much as possible of the > zoned code to a separate translation unit. I have to say I much prefer the ifdef. In the end Ming is the maintainer though, so I'll defer to him.