Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7bf3aaa-581d-0625-5f18-6b9b062ea48d@linux.intel.com>
Date:   Thu, 29 Jun 2023 10:18:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
References: <20230628205135.517241-1-amadeuszx.slawinski@linux.intel.com>
 <20230628205135.517241-2-amadeuszx.slawinski@linux.intel.com>
 <ZJxHTHCq0T/y+dG0@smile.fi.intel.com>
Content-Language: en-US
In-Reply-To: <ZJxHTHCq0T/y+dG0@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/28/2023 4:44 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote:
>> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
>> Almost every use contains additional comments to identify to which
>> platform those IDs refer to. Add those IDs to pci_ids.h header, so that
>> there is one place which defines those names.
> 
> ...
> 
>>   #define PCI_DEVICE_ID_INTEL_5400_FBD0	0x4035
>>   #define PCI_DEVICE_ID_INTEL_5400_FBD1	0x4036
>> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N	0x4dc8
>> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H	0x43c8
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0	0x4b55
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3	0x4b58
> 
> Can it be kept sorted by a value?
> 
> Didn't check the full list, though.
> 

My mistake, I've tried to add them in order, but must have missed this 
one, will review whole list again.