Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp20489186rwd; Thu, 29 Jun 2023 03:04:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Tq+Z/rxob9FT3jZD60Xe58R95caPIP1shBG3PCmRo1WUBq51CLRtjO2ma2lgBRjYYA87c X-Received: by 2002:a05:6a20:914d:b0:122:e62d:dd0a with SMTP id x13-20020a056a20914d00b00122e62ddd0amr30787332pzc.26.1688033043235; Thu, 29 Jun 2023 03:04:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688033043; cv=none; d=google.com; s=arc-20160816; b=PcdWbGnBNvxMWas1i6vPMD3xEj/qHpRdrbdeh/GgYizvVUWoUiBULxB5+N/tbnxqHJ deZw4Q+EdnayvuBG37PUIpvAjajEEUCOupWY4nGiy34xM+5uHYbwz/90/pDxpjg6iY61 klYkD+DOmXwP3IXQ5ztFcrpxxmiDFI2pt1ZfexuI76oXpNR83It0lejXS7n9sKD2fZSM 6nbI4nhONwNIRxh9lYIU50UGcP6/BfnCosQUv5lk5jWU9SV3lODCngE4E64X08+KMcRb fH9LCj+NegpnXRu0nFTnb3z1JoHCvW9prfwoyPxFowk1yEhtk2UKsY96P61wzFrOQU+v sZkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=wh1ZwKQvB7X4STo0NUPhhi5RcPKapaS9/gCO2vsTcUc=; fh=XnXV4f2pdVxhLHz46pTzfbx/rR/1cjyOpS/LEyJjQWE=; b=H877enA3WEtTw8oP/1Xv9e+Z2R5jcq01ZI1x2YDghQQ3kF/r/L3SjkqqpRFQMjsEsi HAlcJa+0lz9FIFFNtS51ZrOiRKGWu4IdYz45HDKEXgF7tDVK4p8KLFjpe1lTrT9K4jR7 bN7iZBK59uGzV50H4snuOhzRyqtfOefZ7ECETeUfAEuZWGLuHoH7N3TGjX1fpU8KTJFC heYtCxwHEil0LF4DI6vDjuo31EPjdHijXJfdLzE28wFDqtYRA6UoxY3XTwj3QvV2BTbz 4f1jIhxK0PdxwrbBwyyegsmM505z5LfpI3JGTQSN9yElmFWIMFRDI9nwlrXYf43fecCu QeYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TxlqtQPO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q134-20020a632a8c000000b00553b9b18886si10583274pgq.638.2023.06.29.03.03.49; Thu, 29 Jun 2023 03:04:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TxlqtQPO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbjF2JnR (ORCPT + 99 others); Thu, 29 Jun 2023 05:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbjF2JnO (ORCPT ); Thu, 29 Jun 2023 05:43:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A77ED; Thu, 29 Jun 2023 02:43:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E98A6150C; Thu, 29 Jun 2023 09:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D8F7C433C0; Thu, 29 Jun 2023 09:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688031792; bh=wzR8YZnxm3FG7gwYs5SdxjfCUJ2NXEhOFnOR0leXfts=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TxlqtQPOajshWpjFna9G6VbJOeh8zHECorIIqQlvPPPQyHYCRbGuSIuZlYyeilevd 5Lia1h5+HRqmaM1fej92tx1ZC7o7S2CgedzSniTSwOKxGTJB96ZbUhtFy0+JQQP7az MMMcBFjv06KbCdIpK/mCrznNAppuXgT+dkUp614c3cg8HKv19CY4/pXBgnRqSzBbNW 7wXcWilQnGauItgDfq3a+xZLhBatp5mYGIxeUruqr/THmVHNzVDel6RZ68aBrfFPZj ACGyPmy3EPmNaWjpeDLBAH/umcemXf2S3dpgclpXvx8Xb/8RrEoi8zLTHDGjkNP4WY WKEdpiIQhIyWQ== Message-ID: Date: Thu, 29 Jun 2023 18:43:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 4/4] ublk: add zone append Content-Language: en-US To: "Andreas Hindborg (Samsung)" , Ming Lei Cc: Hans Holmberg , Aravind Ramesh , Jens Axboe , "open list:BLOCK LAYER" , Christoph Hellwig , Matias Bjorling , open list , gost.dev@samsung.com, Minwoo Im References: <20230628190649.11233-1-nmi@metaspace.dk> <20230628190649.11233-5-nmi@metaspace.dk> <87edluy5l3.fsf@metaspace.dk> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <87edluy5l3.fsf@metaspace.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/23 18:17, Andreas Hindborg (Samsung) wrote: > > Ming Lei writes: > >> On Wed, Jun 28, 2023 at 09:06:49PM +0200, Andreas Hindborg wrote: >>> From: Andreas Hindborg >>> >>> Add zone append feature to ublk. This feature uses the `addr` field of `struct >>> ublksrv_io_cmd`. Therefore ublk must be used with the user copy >>> feature (UBLK_F_USER_COPY) for zone append to be available. Without this >>> feature, ublk will fail zone append requests. >> >> Given zone append is a must, please fail to add device in case of zoned >> and !user_copy, then we can make fast IO code path clean. > > I will squash the patches and reject zone support if not user copy is > enabled ???? Or if !CONFIG_BLK_DEV_ZONED or if the user specifies a bad parameter (invalid limits etc). -- Damien Le Moal Western Digital Research