Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp20663621rwd; Thu, 29 Jun 2023 05:35:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4WCBWAUjLMWCnZ2pEebXMSjzXfaY8sl7GIO3KUAl3kZT2hnQIsZS7/Er5rzj9l9kMwZI2G X-Received: by 2002:a05:6a20:2451:b0:122:31fc:366a with SMTP id t17-20020a056a20245100b0012231fc366amr26604899pzc.36.1688042136112; Thu, 29 Jun 2023 05:35:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688042136; cv=none; d=google.com; s=arc-20160816; b=bWqr6kjk1GYpBljsqczbdTqH2jLjmUQQnv5tChezuH6OaE1IqDarliVtt4SycDIWd7 ObDI5mWLcH4Jnyxs+fkb4Eg3n/crEdkYXGses5Zy872DuKvLKOqbpFasABo0eFecEMHE l2n1wJ8vNSmGsmVLeE1RUMnZg5LmZ0XGlMX7fG/mtdEjWLYVCQw1GAY5k8LUsD7PgknQ WhMhLaARe6aVFZxS2TJ15RLzpePSRARjFdyonjZ7NA1dw7NtdoDFghwP1Bjt/QLBNNx0 tAJY7EqRToVc0M19ZeMkw5+EuFhq5/Ss9l3vmBHCHou/NvlQBJVt4J5Tl5fp4UOasRCn 8F7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I3pCW/TZDgGzycmfkFt0hGQBRAq3KOHZj8OIdfjXeuI=; fh=Z1u9u5G0Va0P5RBbyxks0MdqI6wLnAw0b40xcd5XjXo=; b=RUSXoo30phSLHGSj8zG9uL/22mQFwXSewcBjjFGblJAV77Sk+LI6D4CiDLhPgkFVEu pjhPiTE+uPfq+4UqDnpNNk5e4my3jR4EQGwYk06+dk1/hDybfwqzY0QfBM0BhyCeZKAi GRPVXbFXqSngu07Se5Vc0zu7wOeq4MZuFqnc+5c1ysaCWCCKMB28a4o+eVeM8MnXEKjR e7sY/DiaXIBcCh8Yft1OGCxk+I3ioAF50jciER7NiRx0Tyl2mnL4aQfEs4TjfwVXVgax H+OtRN0ZRQ3zvPI/teaotdMNvpeFxsVRHZKs6NibbQI8DKWyw5elIT4bgljbj/nOG4p1 0gZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mRxW0wUi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a63534a000000b0054fcef3f7b7si10388940pgl.539.2023.06.29.05.35.21; Thu, 29 Jun 2023 05:35:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mRxW0wUi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbjF2M1S (ORCPT + 99 others); Thu, 29 Jun 2023 08:27:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232307AbjF2M05 (ORCPT ); Thu, 29 Jun 2023 08:26:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F197A10FD; Thu, 29 Jun 2023 05:26:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F34E61540; Thu, 29 Jun 2023 12:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3B77C433C8; Thu, 29 Jun 2023 12:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688041576; bh=LS52vXkYfLsp8nOl2NekhIKUNII1QAdyPvLr7arBdP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mRxW0wUiy6WtBT08Rz/9diVeNseJ0fg3hzY3GLMmm0VovfhydkgknKPbpmuhCnQyy UuRR1DXAGwNS0pxytNA/D/fC/yS6gqlOzLv2F8LHnZ6IPqCE2fsNIpPAex/4/aUKb9 oqvuUaPFHfmQlWAlRY0Bhq1c/CYNPnXFj0F3lY3TAR48JFrmDRpO3bKj5LlO9wSe9S uoU++8QfLbXsg3gLPjXVeDE0WgsPkxv46bo2PTBG3AVYorqOT30hW7oT8Ivpf4aQUb qsAcLobA6uY7SFlX+aMl629GlhVHlPai7tJ62jBnNGiQsJOCF5xvBMFrVpX2+mupKZ w4Ki2FQ/ZB7jQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qEqj5-0005zd-75; Thu, 29 Jun 2023 14:26:19 +0200 Date: Thu, 29 Jun 2023 14:26:19 +0200 From: Johan Hovold To: Dmitry Baryshkov Cc: Maximilian Luz , Bjorn Andersson , Andy Gross , Konrad Dybcio , Ard Biesheuvel , Rob Herring , Krzysztof Kozlowski , Sudeep Holla , Ilias Apalodimas , Srinivas Kandagatla , Sumit Garg , Steev Klimaszewski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] firmware: Add support for Qualcomm UEFI Secure Application Message-ID: References: <20230305022119.1331495-1-luzmaximilian@gmail.com> <20230305022119.1331495-5-luzmaximilian@gmail.com> <2eb4abde-579f-94ef-b6c3-81ef197329d0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2eb4abde-579f-94ef-b6c3-81ef197329d0@linaro.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 07, 2023 at 05:51:35PM +0200, Dmitry Baryshkov wrote: > On 05/03/2023 04:21, Maximilian Luz wrote: > > +static struct qcuefi_client *qcuefi_acquire(void) > > Doesn't this need the __locks annotation? No, the mutex implementation does not use sparse annotation so adding __acquires() here will instead introduce new warnings. > > +{ > > + mutex_lock(&__qcuefi_lock); > > + return __qcuefi; > > +} Johan