Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 14:26:31 +0200
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Waiman Long <longman@redhat.com>
Cc:     linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        Zefan Li <lizefan.x@bytedance.com>, Tejun Heo <tj@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/3] cpuset: Allow setscheduler regardless of manipulated
 task
Message-ID: <4fowzgkh7yo5ku2fsrptyi7jzikynjtq4zpfcx7k26vk4k6zj3@ubnupp5jqgle>
References: <20230629091146.28801-1-mkoutny@suse.com>
 <20230629091146.28801-2-mkoutny@suse.com>
 <15c607d9-c1fa-ca11-d675-8f2b3a6fd15b@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rblx2idammiw6ntz"
Content-Disposition: inline
In-Reply-To: <15c607d9-c1fa-ca11-d675-8f2b3a6fd15b@redhat.com>
Precedence: bulk


--rblx2idammiw6ntz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 29, 2023 at 08:11:33AM -0400, Waiman Long <longman@redhat.com> =
wrote:
> So I think you should just use
> cgroup_subsys_on_dfl(cpuset_cgrp_subsys) as the v2 check if your focus
> is just to prevent problem when enabling cpuset controller.

I thought the bare cgroup_subsys_on_dfl(cpuset_cgrp_subsys) is not used
in cpuset.c but I was wrong -- yes, I'll change this.

> This change will likely conflict with the latest cpuset change on trackin=
g #
> of dl tasks in a cpuset. You will have to, at least, move the dl task che=
ck
> before the security_task_setscheduler() check.
>=20
> Another fact about cpuset controller enabling is that both cpus_allowed a=
nd
> mems_allowed are empty at that point. You may also add these checks as a
> preconditions for disabling the security_task_setscheduler check.

Ah, I will rebase on fresh mainline (or do you mean another reference?).

Thanks for the hints,
Michal

--rblx2idammiw6ntz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZJ14dQAKCRAGvrMr/1gc
jgWhAQCg5qoiDOfhNkRuhbqMER6ksJi/9R3UMnsTyDByQxNHcgD9Hxgyt1VPPcbL
NtdTozyc/W59t7siU73cfznURZII+Qk=
=E0Xs
-----END PGP SIGNATURE-----

--rblx2idammiw6ntz--