Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 14:33:14 +0200
From:   Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= 
        <nabijaczleweli@nabijaczleweli.xyz>
To:     Joe Perches <joe@perches.com>
Cc:     Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: don't take signature to be part of the
 commit SHA
Message-ID: <p6by5totn26ofijoki4v6a7lgciswfqovyfrmavtldxg63g2k5@bp3uxxbccxvr>
References: <cmhc6xudksabuza2jrhgs5yg2a2xbohadyyazitg6463uskhjp@enclcjvmbx4r>
 <f316a9d3b9f9d65e6b5542bcd8550ac3b63cbbe2.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ny4gbpphvx5wfdzh"
Content-Disposition: inline
In-Reply-To: <f316a9d3b9f9d65e6b5542bcd8550ac3b63cbbe2.camel@perches.com>
User-Agent: NeoMutt/20230517
Precedence: bulk


--ny4gbpphvx5wfdzh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 28, 2023 at 09:11:00PM -0700, Joe Perches wrote:
> On Wed, 2023-06-28 at 22:35 +0200, Ahelenia Ziemia=C5=84ska wrote:
> > Grepped through for /log /, /show /, and /git_command/, and this
> > is all I found. Unsure if there's other git executions that need
> > to be fixed, tho.
> Not sure either but perhaps these should be in some
> negative options variable like:
>=20
> my $git_log_no =3D "--no-show-signature --no-merges --no-color";
>=20
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -1164,7 +1164,7 @@ sub seed_camelcase_includes {
> >  	$camelcase_seeded =3D 1;
> > =20
> >  	if (-e "$gitroot") {
> > -		my $git_last_include_commit =3D `${git_command} log --no-merges --pr=
etty=3Dformat:"%h%n" -1 -- include`;
> > +		my $git_last_include_commit =3D `${git_command} log --no-show-signat=
ure --no-merges --pretty=3Dformat:"%h%n" -1 -- include`;
> 		my $git_last_include_commit =3D `${git_command} log ${git_log_no} --pre=
tty=3D...
git_commit_info doesn't use --no-merges, and so that'd change the
behaviour of "fixes: xxx"/"commit xxx" thusly:
  $ git log --no-show-signature --no-color --format=3D"%H %s" -1 e3b2e2c14b=
cc12da2c463a7179db39139f682573
  e3b2e2c14bcc12da2c463a7179db39139f682573 Merge tag 'i2c-for-6.4-rc8' of g=
it://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
  $ git log --no-show-signature --no-merges --no-color --format=3D"%H %s" -=
1 e3b2e2c14bcc12da2c463a7179db39139f682573
  afa4bb778e48d79e4a642ed41e3b4e0de7489a6c workqueue: clean up WORK_* const=
ant types, clarify masking
(flattening a referenced merge to its first parent).

Just confirming that's what we want, because I wouldn't think it is?

--ny4gbpphvx5wfdzh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSdeggACgkQvP0LAY0m
WPEUpQ/+IZafp5CVHAA6OoPfwvsxMlSER/5c6p9wqrdeWKwBqv6+DVoqtyNqSsNL
2ioRgZr91/TDOZ7/VWWhlZiU45MALuTSzpXT7Z2OyZMRgpm09XcEijiAVWojaa3Q
2zy3dNPGs46aoDsI/fLSHoYKGOVvlxN35rK7L5zItYXOnEqBYJdRvrIX5n+8P4Pe
7emtPEhevkNHv9DGmz7niPLdXboh/nPEieGNwakuuHr4bMJXiUige+YgAGTn+lDi
1Nc+sP3vhngvFKFY9Gz4zw5yzKLF8q7pVcRsT5g238Hii2Muf909Uk60IZlNPXZm
HXCCfxAsxshXzSUW9kRL5gHqDiLsW7pBy2MTiQxGzTLQNivzRe3qkuHsdZtDfANK
BbQg5MHDHDxSk+6hdHeprm68MordxRbpmzLgyDH3kINnNjsx4qj2gMnVjne3n18D
NjxX1yAGEo1NDtxxk2uojN/bb7d1L03jQfWvE7SHW0xJrVBc/kuvtVIBUmgsABpH
MfEWxxJcBR26sCu4hfeYhJ2gT5FPaKa4kPd9ITddYR/HULY8wJCAg2V1y4VLALyr
wXd9xC2twS36yr4Dh9+sgQpO3HSgX8rB4QAbuZ5n2t6nPUH4u/nAiMyCSjurU90a
r0+anxDbwj4W8JkFo6sF7lp6Ppbjy3FGa/0PeAmlufI1Aj4LZVA=
=+JhW
-----END PGP SIGNATURE-----

--ny4gbpphvx5wfdzh--