Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbXJVA0r (ORCPT ); Sun, 21 Oct 2007 20:26:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751098AbXJVA0k (ORCPT ); Sun, 21 Oct 2007 20:26:40 -0400 Received: from netrider.rowland.org ([192.131.102.5]:1190 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751067AbXJVA0j (ORCPT ); Sun, 21 Oct 2007 20:26:39 -0400 Date: Sun, 21 Oct 2007 20:26:38 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Kay Sievers cc: Greg KH , Kernel development list Subject: Re: BUG in: Driver core: convert block from raw kobjects to core devices In-Reply-To: <1192993396.3661.1.camel@lov.site> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 25 On Sun, 21 Oct 2007, Kay Sievers wrote: > > [ 458.013133] scsi_disk_release: disk sda, kobj ce8be990, refcount before put_disk 2 > > [ 458.032420] scsi_device_dev_release: rq cd9b2000 > > Hmm, I still don't see this without the final put. Yes, I see your point. Suppose you try doing the exact same thing again, but this time un-comment the put_device() call so that the scsi_device does get released. I predict that the log will show your request_queue drops its reference to the gendisk structure _after_ the gendisk has been released. (If necessary I could send a patch with a printk at the crucial spot.) That would prove something is going wrong on your system. (BTW you don't need to include the log for when you plug in the USB drive; all that matters is what happens when you unplug it.) Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/