Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Romanowski, Rafal" <rafal.romanowski@intel.com>
To:     Simon Horman <simon.horman@corigine.com>,
        ivecera <ivecera@redhat.com>
CC:     Ma Yuying <yuma@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pending VF
 reset in VF set callbacks
Thread-Topic: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pending VF
 reset in VF set callbacks
Thread-Index: AQHZnfDxvSeWAOer9k2q/FgfXzcbo6+J9/aAgBfqUKA=
Date:   Thu, 29 Jun 2023 13:39:34 +0000
Message-ID: <BL0PR11MB3521F019D9764F5D09AB87FD8F25A@BL0PR11MB3521.namprd11.prod.outlook.com>
References: <20230613121610.137654-1-ivecera@redhat.com>
 <20230613121610.137654-2-ivecera@redhat.com> <ZIl5t3x3/BDdHyhr@corigine.com>
In-Reply-To: <ZIl5t3x3/BDdHyhr@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?q/+/D9Urw5MaIzcNXo5Lmf1QxBCjI9/jOJaCUKBir4iKXPPRyWpulNctUR?=
 =?iso-8859-2?Q?SKaJ2IprthgAPcyHRdcnKr5ELowRS4zNmwcA9zLtHRihCYS5L/GAi1sRoU?=
 =?iso-8859-2?Q?s0gKpEeYIEVsqWk5RSqCyqJR5I5IaIrxiy5kVOqevqDfvLSiE8SnGm6XJH?=
 =?iso-8859-2?Q?YlQEqll/J7MR3iWRP1gjZptmDKnqSqDQ1T6cW75xQksnnOo1qY/VR9HHzT?=
 =?iso-8859-2?Q?e6v6Kxik9ujXiRg1rqgfWTi4Kgnjv3t1QBf8sgUT5DjwitkWS3K+w0rZE4?=
 =?iso-8859-2?Q?1Sh/BNSdjlsFA8m8lG9WZE85C//En22dOVXNmBdTX8fnGTre3wZzclO9Ai?=
 =?iso-8859-2?Q?9RfNBVX2eH4asi3y744j8EH1y5NdGVRHQYg7gku9HcKaGID0MuWZSP8aTF?=
 =?iso-8859-2?Q?7mOeac404EBwSVRTatgYIsNHEPtrvaC2KjGl1h3VcvHXOhsPtxKdqKdmnE?=
 =?iso-8859-2?Q?oHIGAOTVyIYzdlMgU7v9puPXKQiffH1/+P4e4NgErrKi6fV36gjlmwGYCQ?=
 =?iso-8859-2?Q?XdwgqskZS0DFC4q6fjQVuyT+acYOsAJszfeaQNljEooCEjIhvLyG9ntgv2?=
 =?iso-8859-2?Q?v/bM1Pgh22/QWwX2cEJZOP9/LLdYKAsvPZYLIRcnQTs3V3/quSCbTXTfUB?=
 =?iso-8859-2?Q?tje3hfHrNz+mXQEpjExun5aXZSM46/s8Vw/9Nk+zt4vwrWTv0N6XkXYKaP?=
 =?iso-8859-2?Q?Db3biG76vJNNMSngsvtlp7MqbShtMwnkv8qf+Q41MM62/njN3O/r8Att4a?=
 =?iso-8859-2?Q?cRaQqPnLhQerxU93l1R3G1QZagwS/+81X3vRTfhUKHcGfpYgxQIgfmTFy1?=
 =?iso-8859-2?Q?y2zGsnVP7jTdpEbO8DCsmImluA+SYyOj9vETU9TwBUQaI8lR3m952bfI7S?=
 =?iso-8859-2?Q?8rinYYX91rQDqFGYZo+onwA8SFu3rFUyRtmw1ewBOSFVpn37StWi7FJS+A?=
 =?iso-8859-2?Q?dZBJ1xR2u6rurDopbvZdcTlEPsyjSBTyYApfdJkMY4SoWY9MYnCc8HJtCK?=
 =?iso-8859-2?Q?1YdpV7jHbAkZTnowDofHo3XwyJZhjYXHJW+SBU+EAqSyA9+/ELvpeHYmlg?=
 =?iso-8859-2?Q?h2QjUsylL0ex4AQHfED2JkFuOGiyup4mNMuJecAYHR25cz0yx2tp0rh580?=
 =?iso-8859-2?Q?PvtFdU4rYTo3RPv4XKHjGv/03z6BAZ7zoMLiCbFw2KUDTmXuRbj11brJwd?=
 =?iso-8859-2?Q?I6zXXMLEAEoclrlAepFj+7Nyr9qf+SaZtLrcEl7DEcxLsYmlW/m1PHdViv?=
 =?iso-8859-2?Q?VszPgv8rGUQtYBi2welz1X8e+IBVKlhnJtvlDZRhbtyrLp8J5z3+mBKchi?=
 =?iso-8859-2?Q?L/WZk1tcIl/wVcvslyywhKAOra6JoBlpF8AP2lxxM23r+5zg/Yewb6H/P2?=
 =?iso-8859-2?Q?ZQadOx+yF/orh70CizeUfWvhuvnPpVsA0+Cf6lb7PVaO+cz3a2VK3dbocf?=
 =?iso-8859-2?Q?vLm0HLk0qDqLbsai3X0cKOS2zdUPcy0r4aIOuYmwNEWWvxSi3LW/RnkB1g?=
 =?iso-8859-2?Q?95+DSSkPhzJWHPhF1z6HBJTQ7DDDEMtLNSRz41OGbYywkSrHJz4z29PioL?=
 =?iso-8859-2?Q?5BcW34Qm5J1NI7VTUJtyA4bBt65RdXoq4eWsRriImXbZlb5gZzT7wh0+JR?=
 =?iso-8859-2?Q?NQkJles7syTuAa5l4mv6VHrE2x+olQI/Hgr3oesQf5pqMYM7YkH5mppg?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3521.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8910488e-57bf-40e4-5160-08db78a64658
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2023 13:39:34.2741
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CU7jpjWnprPYv6fE2UvKBYzglcmV0FZ9zKR/w7XqeT51h9rhAfQ8AyyKX3yHiTc8RF1zlggXOtSu2YqNnywsEJmuY2K9W7V1gXZbj97PxlA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8088
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: =B6roda, 14 czerwca 2023 10:27
> To: ivecera <ivecera@redhat.com>
> Cc: Ma Yuying <yuma@redhat.com>; netdev@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; open list <linux-
> kernel@vger.kernel.org>; Eric Dumazet <edumazet@google.com>; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; moderated list:INTEL ETHERNET
> DRIVERS <intel-wired-lan@lists.osuosl.org>; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] i40e: Wait for pendin=
g VF
> reset in VF set callbacks
>=20
> On Tue, Jun 13, 2023 at 02:16:10PM +0200, Ivan Vecera wrote:
> > Commit 028daf80117376 ("i40e: Fix attach VF to VM issue") fixed a race
> > between i40e_ndo_set_vf_mac() and i40e_reset_vf() during an
> attachment
> > of VF device to VM. This issue is not related to setting MAC address
> > only but also VLAN assignment to particular VF because the newer
> > libvirt sets configured MAC address as well as an optional VLAN. The
> > same behavior is also for i40e's .ndo_set_vf_rate and
> > .ndo_set_vf_spoofchk where the callbacks just check if the VF was
> > initialized but not wait for the finish of pending reset.
> >
> > Reproducer:
> > [root@host ~]# virsh attach-interface guest hostdev --managed
> > 0000:02:02.0 --mac 52:54:00:b4:aa:bb
> > error: Failed to attach interface
> > error: Cannot set interface MAC/vlanid to 52:54:00:b4:aa:bb/0 for
> > ifname enp2s0f0 vf 0: Resource temporarily unavailable
> >
> > Fix this issue by using i40e_check_vf_init_timeout() helper to check
> > whether a reset of particular VF was finished in i40e's
> > .ndo_set_vf_vlan, .ndo_set_vf_rate and .ndo_set_vf_spoofchk callbacks.
> >
> > Tested-by: Ma Yuying <yuma@redhat.com>
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>=20
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>=20
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>