Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 15:23:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Always store of_node when getting DAI link
 component
Message-ID: <1d74d2ed-0c4d-4fce-849d-5f2288394569@sirena.org.uk>
References: <20230623-asoc-fix-meson-probe-v1-1-82b2c2ec5ca4@kernel.org>
 <87jzvrksi2.wl-kuninori.morimoto.gx@renesas.com>
 <9fbe4924-5c02-43f7-b47f-bc290fd07e67@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p3xSwJ/njDdW/FTy"
Content-Disposition: inline
In-Reply-To: <9fbe4924-5c02-43f7-b47f-bc290fd07e67@sirena.org.uk>
Precedence: bulk


--p3xSwJ/njDdW/FTy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 26, 2023 at 12:49:16PM +0100, Mark Brown wrote:
> On Sun, Jun 25, 2023 at 11:54:29PM +0000, Kuninori Morimoto wrote:
>=20
> > > The generic snd_soc_dai_get_dlc() contains a default translation func=
tion
> > > for DAI names which has factored out common code in a number of card
> > > drivers, resolving the dai_name and of_node either using a driver pro=
vided
>=20
> > Yes, indeed.
> > But I think we want to set it under lock and if ret was no error case ?
>=20
> It doesn't really matter - there's only one possible result, and nothing
> should be looking at the dlc unless we return success, but yes that'd
> probably be a little cleaner providing we don't ever return early.

BTW that's not to say don't submit this as a patch, just that it doesn't
need to get applied as a fix.

--p3xSwJ/njDdW/FTy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSdk84ACgkQJNaLcl1U
h9A7NQf8DiMYBVpbql+uhhR4/aQO3adkGIelIoUtUaDRAb9Qvsuliz0afLzBRmLY
iXJEQ02Hak6oJrt0OiPFct2vtsZ8E6LPJf3P/WirIlmiUpLIShr9/feri3Nt7gIo
WCja2NjjWjfmHj1fkZxjXnQ3CRB4+byV9cyeRjfSok65A6P/jLMif6GlnNp0ieFK
zwaEmmLGzayLL6UTekwL2gU/I8CI+yp4zVgAkIe6utxTSQJ06mz/HEBL1np/+qFs
hQf4zjGdVUGpDQ+O9yS2P7CpOQPQaay4bvM8LRGkIvFZWGsMSkS0VBbsK7FiLpI6
PXqIUOfTj4BmMRnqc5vmLVMPfKgKrg==
=W096
-----END PGP SIGNATURE-----

--p3xSwJ/njDdW/FTy--