Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Leo Li <leoyang.li@nxp.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
CC:     Ma Ke <make_ruc2021@163.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9
 udc
Thread-Topic: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9
 udc
Thread-Index: AQHZqZi9K7bLkqeFik2hEi3PRtnNM6+gcHbggAAtAQCAABgTIIAAlCoAgAAuA4CAAG1lAA==
Date:   Thu, 29 Jun 2023 15:13:43 +0000
Message-ID: <AM0PR04MB6289FD7D57831D113BAAC8348F25A@AM0PR04MB6289.eurprd04.prod.outlook.com>
References: <20230628081511.186850-1-make_ruc2021@163.com>
 <AM0PR04MB62893E77D085030A6E2C37B28F24A@AM0PR04MB6289.eurprd04.prod.outlook.com>
 <f321287d-8156-b805-26fd-58acfa26e324@csgroup.eu>
 <AM0PR04MB628929736762F5DF46C55D708F24A@AM0PR04MB6289.eurprd04.prod.outlook.com>
 <7975b5bf-c8e0-237e-d6f4-98e641d39959@csgroup.eu>
 <2023062958-graffiti-skyrocket-cfee@gregkh>
In-Reply-To: <2023062958-graffiti-skyrocket-cfee@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ftnVbHFV5h1nBYnX4YKJmCd5AisGNlYGb1MSOql3xVVWnPOXBZDLwkw8VO?=
 =?iso-8859-1?Q?vDGxL78e5SyNXTemVv5UPd4G/Td3PrnlQKQrQxzNedeyRn9Rtjs3q4G6a1?=
 =?iso-8859-1?Q?xAb2g9D5bQXHEXSiMWlx7GpFQAkf9Dg1qln6t2FtFvDk/BddpUoHM3axtc?=
 =?iso-8859-1?Q?3dlutVyYf+nNi4eRNLkO8U2haVc6/4kJgBZ39b/0C4pnzcHR8gLwRBNtfB?=
 =?iso-8859-1?Q?8Pr82z6lYmR59nkCgxJd3b5lVKKDib2BwvDXEn7B5aevhZJzJwvEQVkWsg?=
 =?iso-8859-1?Q?njyD0MgPOq0ovFyWX7RAIBXc7pNQ0xuoDyp3XO0iigBVWgnoVH2wqUrC8m?=
 =?iso-8859-1?Q?12D2G48EXDCMGchrRXVtxJq4UW/j5GfOwFLn/NMW9B848c3mcqOM72yEwr?=
 =?iso-8859-1?Q?06N9AYeRwvIqwVBXIYtpqL0ApYFf3dTgXTiWG359Gn8S4761K7lRlvXPhW?=
 =?iso-8859-1?Q?IyDPlWA2ZvaU/Zvz6IIm2hF6hU2dByRKRk9J7viB4YHqzPMiA9HttY+nBO?=
 =?iso-8859-1?Q?CSfgFt3L8dxnlgzQmcqw28Vk/CvOVoRC0lkZbgvOKcJFbkq0Np25PyI+bY?=
 =?iso-8859-1?Q?3jbL+KlfgzlnY3oNvs9AgZZjXANTY8i3Rk3eBPYADpeA9T+zvcCKwDxR84?=
 =?iso-8859-1?Q?Oc8WPGwwSsXOO5WT6tXcfjR6fByJXq/L1tsfM4l1CSYA6nySIrFkJZ2NEc?=
 =?iso-8859-1?Q?VVumbLp4YhYVOuhAxec/yEt/UU1ihiNS1v0/RpBZsBgs8wlAQRoPclhpaO?=
 =?iso-8859-1?Q?kfg6wbUdHH2OyZh98mIdG6L/aKBM92USO5wgcs5upHhRVlINWvU9rc6Ade?=
 =?iso-8859-1?Q?cFWaBPKvuOkFuZVIOhvZBSkTH7AptZACpO8LpHpzhoirUmJZlW5ebeLAgF?=
 =?iso-8859-1?Q?vwa+fsNjZcXJHswA+Fz0/qnzfGOwvBeazV3Fsy9w4NpyX6q5Y8z8gAqNSI?=
 =?iso-8859-1?Q?ScW7nqGV3KZGceUcCxVh/Y6A4WZg4499pi/GlOIWqq3scs7ythz7QElhhV?=
 =?iso-8859-1?Q?+Nany+pO2EF20bts3qhpl7+VFMUXJsM6RjDoLVJkgi2vBTOgnT4omAfKk6?=
 =?iso-8859-1?Q?hQHImjEM1XD+MJXm9OUGg3c2MxqybctG93qN3qjh6qE3j2swrrDIT5KK6C?=
 =?iso-8859-1?Q?l0Mn5Lo2Ntep1a1IyGs1zBgGxjuogbqX+TOfbiJlvm08nBwe8nsfDpJMIn?=
 =?iso-8859-1?Q?BZQJt5XQzy7MTGeBZV4cWtJzJhDMHIO726JcoB1/zj5VkgntNiJAxFSYGt?=
 =?iso-8859-1?Q?J1jAOraTLzV+aJGSToXSkrh0PBUhfwPmYwz8Ea4BqaFoem8gONZ/VuQjiX?=
 =?iso-8859-1?Q?YlsTMMa4+xjymrey9I+5nWECotF+37WnJhx4/8eX8wU9ffPuWPWzRZEn3F?=
 =?iso-8859-1?Q?TTqY3HnEdJe35OwvTjPVoP+k2izs4RKgj5T7aaaInZgp+J45HKE0LGomrQ?=
 =?iso-8859-1?Q?JpEyysBawzVXMNiCMwuSJsOe/R1sHDmeYD1pQyekCFKjuTzTQcd3UZmQhL?=
 =?iso-8859-1?Q?v2blujPpYD4++vVZxaGM4sAgmRlkwC5R02AngSvXEUC93X+oZIfPrjEV2h?=
 =?iso-8859-1?Q?f3DF5XWhBh8dnyvJj4GFNAaJKN0Wf4hG5aDGa+c4VK/F9RK87r2mB74YRY?=
 =?iso-8859-1?Q?4bpkN6yup2/ZA=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6289.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdeef337-1a1c-43e1-8558-08db78b36dbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2023 15:13:43.8240
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l8uSpbHMY06YLhPI2du2k9MhYoLerBdrEeN7KrQsblLxYhUuJrY0FQybR7GxS4FQolLbuP00WX1veFEBCvvjzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7288
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>
> Sent: Thursday, June 29, 2023 3:41 AM
> To: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Leo Li <leoyang.li@nxp.com>; Ma Ke <make_ruc2021@163.com>; linux-
> usb@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for
> ch9 udc
>=20
> On Thu, Jun 29, 2023 at 05:56:30AM +0000, Christophe Leroy wrote:
> >
> >
> > Le 28/06/2023 =E0 23:10, Leo Li a =E9crit=A0:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Christophe Leroy <christophe.leroy@csgroup.eu>
> > >> Sent: Wednesday, June 28, 2023 2:40 PM
> > >> To: Leo Li <leoyang.li@nxp.com>; Ma Ke <make_ruc2021@163.com>
> > >> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> > >> linuxppc- dev@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > >> Subject: Re: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint
> > >> index for
> > >> ch9 udc
> > >>
> > >>
> > >>
> > >> Le 28/06/2023 =E0 19:04, Leo Li a =E9crit=A0:
> > >>>
> > >>>
> > >>>> -----Original Message-----
> > >>>> From: Ma Ke <make_ruc2021@163.com>
> > >>>> Sent: Wednesday, June 28, 2023 3:15 AM
> > >>>> To: Leo Li <leoyang.li@nxp.com>
> > >>>> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
> > >>>> linuxppc- dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Ma
> > >>>> Ke <make_ruc2021@163.com>
> > >>>> Subject: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index
> > >>>> for
> > >>>> ch9 udc
> > >>>>
> > >>>> We should verify the bound of the array to assure that host may
> > >>>> not manipulate the index to point past endpoint array.
> > >>>>
> > >>>> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> > >>>> ---
> > >>>>    drivers/usb/gadget/udc/fsl_qe_udc.c | 2 ++
> > >>>>    1 file changed, 2 insertions(+)
> > >>>>
> > >>>> diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
> > >>>> b/drivers/usb/gadget/udc/fsl_qe_udc.c
> > >>>> index 3b1cc8fa30c8..f4e5cbd193b7 100644
> > >>>> --- a/drivers/usb/gadget/udc/fsl_qe_udc.c
> > >>>> +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c
> > >>>> @@ -1959,6 +1959,8 @@ static void ch9getstatus(struct qe_udc
> > >>>> *udc, u8 request_type, u16 value,
> > >>>>    	} else if ((request_type & USB_RECIP_MASK) =3D=3D
> > >>>> USB_RECIP_ENDPOINT) {
> > >>>>    		/* Get endpoint status */
> > >>>>    		int pipe =3D index & USB_ENDPOINT_NUMBER_MASK;
> > >>>> +		if (pipe >=3D USB_MAX_ENDPOINTS)
> > >>>> +			goto stall;
> > >>>
> > >>> Thanks.  This seems to be the right thing to do.  But normally we
> > >>> don't mix
> > >> declarations with code within a code block.  Could we re-arrange
> > >> the code a little bit so declarations stay on top?
> > >>
> > >> But we are at the start of a code block aren't we ?
> > >
> > > But they were at the beginning of a { } block which is compliant with=
 the
> C89 standard.  I know gcc is more relaxed from this.  But it is probably =
still
> good to stick to the standard?
> >
> > Sorry I misread the patch and failed to see that the declaration block
> > was continuing after the change.
> >
> > So yes don't interleave code with declarations. Leave declaration at
> > the top of a block with a blank line between declarations and code.
>=20
> This is fine as-is, no need to change anything.

With the approval from Greg, I have no objection to the patch.

Acked-by: Li Yang <leoyang.li@nxp.com>

Regards,
Leo