Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 16:06:04 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Trevor Wu <trevor.wu@mediatek.com>
Cc:     lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: mt8188: add constraints for PCM
Message-ID: <5995e77b-ea8e-4e88-8ca2-f716df9c9579@sirena.org.uk>
References: <20230629075910.21982-1-trevor.wu@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="9vDzboGe8Rh5zM2x"
Content-Disposition: inline
In-Reply-To: <20230629075910.21982-1-trevor.wu@mediatek.com>
Precedence: bulk


--9vDzboGe8Rh5zM2x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 29, 2023 at 03:59:10PM +0800, Trevor Wu wrote:

> For certain projects, only a limited number of parameters are necessary.
> Therefore, it may be beneficial to add constraints that restrict the
> capacity of the PCM.

This commit message isn't entirely clear.  The effect of the commit is
to restrict the configurations supported when using a nau8825 but it's
not clear what a nau8825 has to do with this or why we're doing this in
general.  What exactly do you mean when saying that "only a limited
number of parameters are necessary" and what makes this the case?

--9vDzboGe8Rh5zM2x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSdndsACgkQJNaLcl1U
h9Aj1Af9EDUZJPIpv75r4jnUe38kpi7YWD4SjRP7RAdggjnFr3VblTudJeMsxBfP
Xg9arOq/KEIqU3qGGn0ejdO0SOUF/cCS5ZUyNTcIMr3IWGUlWEn2mSZDP01MbnGg
DrIv5lNYZ+LXxdZD4UPqIcuEp/umRN7mTp3nQxX3AqIo2BWplzSKE9yIYF4CrZvx
XU2ZpGqV3RIR2G8avJlLdC16KL3gOQqLzPkPEctHFP2u24hnnkobgwEvBPlR9Xuy
/TvMv8XRH3FcVqoKf82e23q0hl7W1g6DCy5N7ShqD/lRqlIjGWcUbIiaffP8f+rp
L/kqu8AfVJw33IGr4CscKIVH29kFcA==
=i7Ra
-----END PGP SIGNATURE-----

--9vDzboGe8Rh5zM2x--