Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
Date:   Thu, 29 Jun 2023 17:00:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning
Content-Language: en-GB
To:     Arnd Bergmann <arnd@kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20230607120857.3621364-1-arnd@kernel.org>
From:   Matthieu Baerts <matthieu.baerts@tessares.net>
In-Reply-To: <20230607120857.3621364-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Arnd,

On 07/06/2023 14:08, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Since usermodehelper_table() is marked static now, we get a
> warning about it being unused when SYSCTL is disabled:
> 
> kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]

Thank you for the patch!

We also hit the same issue on our side after today's sync with Linus'
tree. I confirm this patch fixes the issue.

Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net>

I didn't see this patch applied in Luis' sysctl-next branch, do you know
who is taking care of it?

> Just move it inside of the same #ifdef.
> 
> Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")

A small detail: it looks like the SHA has been modified, it should be
861dc0b46432 instead of e6944e3b75df7:

Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net