Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 08:55:18 -0700
In-Reply-To: <20230629142633.86034-1-likexu@tencent.com>
Mime-Version: 1.0
References: <20230629142633.86034-1-likexu@tencent.com>
Message-ID: <ZJ2pZh4GeBytq7R2@google.com>
Subject: Re: [PATCH] KVM: selftests: Fix the meta info of test cases in the
 header comments
From:   Sean Christopherson <seanjc@google.com>
To:     Like Xu <like.xu.linux@gmail.com>
Cc:     David Woodhouse <dwmw@amazon.co.uk>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 29, 2023, Like Xu wrote:
> From: Like Xu <likexu@tencent.com>
>=20
> Fix test case names (including descriptions) in comments for
> tsc_scaling_sync and xen_shinfo_test. No functional changes intended.
>=20
> Fixes: e467b0de82b2 ("KVM: x86: Test case for TSC scaling and offset sync=
")
> Fixes: 8d4e7e80838f ("KVM: x86: declare Xen HVM shared info capability an=
d add test case")
> Signed-off-by: Like Xu <likexu@tencent.com>
> ---
>  tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c | 4 ++--
>  tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c b/tool=
s/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> index 5b669818e39a..cdb214660e0a 100644
> --- a/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> +++ b/tools/testing/selftests/kvm/x86_64/tsc_scaling_sync.c
> @@ -1,10 +1,10 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * svm_vmcall_test
> + * tsc_scaling_sync
>   *
>   * Copyright =EF=BF=BD 2021 Amazon.com, Inc. or its affiliates.
>   *
> - * Xen shared_info / pvclock testing
> + * Test case for TSC scaling and offset sync

I vote to delete the metadata (but leave the Copyright).  IMO it adds zero =
value,
and has a non-zero chance of becoming stale in the future.

>   */
> =20
>  #include "test_util.h"
> diff --git a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c b/tools=
/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> index 05898ad9f4d9..60daee9f3514 100644
> --- a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * svm_vmcall_test
> + * xen_shinfo_test
>   *
>   * Copyright =EF=BF=BD 2021 Amazon.com, Inc. or its affiliates.
>   *
>=20
> base-commit: 88bb466c9dec4f70d682cf38c685324e7b1b3d60
> --=20
> 2.32.0
>=20