Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp20986003rwd; Thu, 29 Jun 2023 09:24:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7oRqhdpNZWC6eejR5Eyut8x39JneW46ORAyKuw3ILxGPWbk2vYA7cYT6jeCDMK5w2oPr9w X-Received: by 2002:a05:6a20:96ce:b0:12c:f124:5b72 with SMTP id hq14-20020a056a2096ce00b0012cf1245b72mr104072pzc.43.1688055839912; Thu, 29 Jun 2023 09:23:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688055839; cv=none; d=google.com; s=arc-20160816; b=KFjz+QEDgDZFIi0bclsW/PQalzGDIuFQgxL/HSVwVvzkr2ws9tMDFReK2UfO06nxmQ +niA6NLO1FNbVJHWWERUR/EKejwW+GpsVKiWaNK9X9TSIW4LqD3qwLaUl/SSRlaXB529 hueHy5GdR98toOqgdS0pUVLA+6mjwo7SqNlChKfNAMjhIt52ykxfsBtha/M8NUujPs4f PASL3ZSLXLcfVOIa+yQmuLZzjVfNxCpftRcGwhVvSnuAu0b9o82Bzw2P/MTgWgMPt2kr wGRRVPjj8BMZL6S6ZZKBIpUXakkiNOVtorngbHT93c4x5zHSOHpuNXzAtj8V69klqXeh FwHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=poaFO3/bPh14xOgLxoo80j/K9Q/PKlqqhRQVP/H2PzY=; fh=fhG4/6gHr8fOlb8YghzZoo0QF+YRLwlRDlA7GQ/FE5o=; b=fL1OZiS9sFLictER7nVhqsDJ+WObEM5Bwxd/8M2ZozescFGorneKNeJpBloRfmBAC6 nLdLvi3liS5vdKwMhXUkWa/W5lY3lmnNfEZAmFVZI/PNwkC8ooM5awqDAJEpT3DTG0ep SDVxPdbPg3wFJX2Z4tOiYrWQJkYvEFfRDpaQpQQQ3MfQgWydobjfTucDLDeOXje7Hj0p MDKDtIonrJV2nKF2abwb21WMmxEzJ70DjBtiwMI2TdV2l01gQ1baSLuVDICd0xxQKbCt ytilHhgednwBQNiHNPfMi5+M0LGAz7aCs8wNL8lcbgeILn/WUPR12lub0VL+L++dPKsm NWrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qux7W8jR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a056a00158b00b006797c2c00besi7528795pfk.144.2023.06.29.09.23.46; Thu, 29 Jun 2023 09:23:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qux7W8jR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232262AbjF2QLe (ORCPT + 99 others); Thu, 29 Jun 2023 12:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbjF2QLd (ORCPT ); Thu, 29 Jun 2023 12:11:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C9B89E; Thu, 29 Jun 2023 09:11:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B86A86157B; Thu, 29 Jun 2023 16:11:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96951C433C0; Thu, 29 Jun 2023 16:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688055091; bh=poaFO3/bPh14xOgLxoo80j/K9Q/PKlqqhRQVP/H2PzY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qux7W8jRi3usYygYWoKQ80BcrBb8GJWqLvuGuwL8lbBwBavexsXOYZo/YD8NXuGDQ d1242atZe6+maXcqWu2UAnmYyd7J7+MA4DN1eT1MDIHRkyEzElW6VSEb3knMaRxKVW XEppM1gEwcAG3KvCTuYd1XN0lhyMaDdVi+bDG9Xza9K/Yxe3evXQMuZbe1q8stHxpw jFl+XugO0YcGPCK7GH6CqDyUXfsresz9YrZfrbnLfuigc4HXzyiy3N4mFJYza82u5e UronuKaEFZqz/r813jLP8q4qjeNA/rQDcvX4hMDW6iDW1hqjlUjnGMF6i94Uc3bgst bhOgvbvlqGHhA== Date: Thu, 29 Jun 2023 09:11:29 -0700 From: Jakub Kicinski To: longli@linuxonhyperv.com Cc: Paolo Abeni , Jason Gunthorpe , Leon Romanovsky , Ajay Sharma , Dexuan Cui , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , "David S. Miller" , Eric Dumazet , linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Long Li , stable@vger.kernel.org Subject: Re: [Patch v3] net: mana: Batch ringing RX queue doorbell on receiving packets Message-ID: <20230629091129.19217388@kernel.org> In-Reply-To: <36c95dd6babb2202f70594d5dde13493af62dcad.camel@redhat.com> References: <1687823827-15850-1-git-send-email-longli@linuxonhyperv.com> <36c95dd6babb2202f70594d5dde13493af62dcad.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jun 2023 10:42:34 +0200 Paolo Abeni wrote: > > While we are making changes in this code path, change the code for > > ringing doorbell to set the WQE_COUNT to 0 for Receive Queue. The > > hardware specification specifies that it should set to 0. Although > > currently the hardware doesn't enforce the check, in the future releases > > it may do. And please split this cleanup into a separate patch, it doesn't sound like it has to be done as part of the optimization.