Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <599ba86b-1f33-4ba2-5781-cd98ecfa985c@infradead.org>
Date:   Thu, 29 Jun 2023 09:20:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] umh: fix build warning with CONFIG_SYSCTL disabled
Content-Language: en-US
To:     Matteo Rizzo <matteorizzo@google.com>, jarkko@kernel.org,
        mcgrof@kernel.org, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
References: <20230629161044.1995505-1-matteorizzo@google.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230629161044.1995505-1-matteorizzo@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/29/23 09:10, Matteo Rizzo wrote:
> When CONFIG_SYSCTL is not defined proc_cap_handler is not used. This
> causes a build warning with -Wunused-function.
> 
> kernel/umh.c:497:12: error: unused function 'proc_cap_handler'
> [-Werror,-Wunused-function]
> static int proc_cap_handler(struct ctl_table *table, int write,
>            ^
> 1 error generated.
> 
> Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")
> Signed-off-by: Matteo Rizzo <matteorizzo@google.com>

Arnd sent this same patch on 2023-June-07.

I have been wondering why it has not been merged...

> ---
>  kernel/umh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/umh.c b/kernel/umh.c
> index 41088c5c39fd..1b13c5d34624 100644
> --- a/kernel/umh.c
> +++ b/kernel/umh.c
> @@ -494,6 +494,7 @@ int call_usermodehelper(const char *path, char **argv, char **envp, int wait)
>  }
>  EXPORT_SYMBOL(call_usermodehelper);
>  
> +#if defined(CONFIG_SYSCTL)
>  static int proc_cap_handler(struct ctl_table *table, int write,
>  			 void *buffer, size_t *lenp, loff_t *ppos)
>  {
> @@ -544,7 +545,6 @@ static int proc_cap_handler(struct ctl_table *table, int write,
>  	return 0;
>  }
>  
> -#if defined(CONFIG_SYSCTL)
>  static struct ctl_table usermodehelper_table[] = {
>  	{
>  		.procname	= "bset",

thanks.
-- 
~Randy