Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95e93d2d-a157-5434-2688-da9a20ed3e3d@intel.com>
Date:   Thu, 29 Jun 2023 09:20:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH net v2] igc: Prevent garbled TX queue
 with XDP ZEROCOPY
To:     Florian Kauer <florian.kauer@linutronix.de>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Vedang Patel" <vedang.patel@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jithu Joseph <jithu.joseph@intel.com>,
        "Andre Guedes" <andre.guedes@intel.com>,
        Simon Horman <simon.horman@corigine.com>
CC:     <netdev@vger.kernel.org>, <kurt@linutronix.de>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20230628091148.62256-1-florian.kauer@linutronix.de>
 <87a5wjqnjk.fsf@intel.com>
 <b64dc5c7-600c-66db-d125-2d747a21c1d8@linutronix.de>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <b64dc5c7-600c-66db-d125-2d747a21c1d8@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmZ6Q3NPclBuYmQ4VkpWWjZNaW5pM3o2eCtBc1RyVGtXQmJXRjlNOW5XcWN1?=
 =?utf-8?B?VDNrU215OFhxYzJBaENrbzJrdUI5ZGg5amtWazUxWmpoRklaVXo0MEtVdEUw?=
 =?utf-8?B?dSszQ1hjUTZuaEM1dG9IN0ZWWmFWa3lrVWE3Y2pjTW84QXNSMlVIQVhSaFRp?=
 =?utf-8?B?bTJ4OHkweHJ5YS92TVJGTWlTWmpqNkc4UFBNUjNlSGpXeFhSei9Ra2VsZ0Vr?=
 =?utf-8?B?RHVHTmZaYkx3OEZjbDg3c0ptaXN1N21hRzdtVVM4czhjV1VlaGJQYWJNQUs2?=
 =?utf-8?B?RWwxUGRFdUJLYUlORWV6dHM0dGtycnFZT0tCOFM1VE4xY2lOdytoVmhQelV3?=
 =?utf-8?B?Ny9YTk1YajJWejAvYlVjOGV4TVdQYUpCZnkrQnA0dHVmUUpwZWUxUzZ0UXdV?=
 =?utf-8?B?SXhlY2lZSDZ4VDY0Risvb3RoMXBIZFdqVU5QT3pZRWp6eUFZemQvMkZZWTVV?=
 =?utf-8?B?WXV4cG1abStGZ3RSYzlRenV2VmhrS2paTVNpSTZHNTFPZytCRVJrMW5nSERR?=
 =?utf-8?B?b2x2TGg1MGYzR01zd3JuRkUzdnFyTW91UXBWa2lkNlovWEhtL05WV3ZydUxw?=
 =?utf-8?B?b0ZoMGpId2FJZi9FVEVVc3J0SmtsbUZnRnZXdC9LUkFKOGYycDBlcmpUR25K?=
 =?utf-8?B?clR4eVJFVjFwV25mV29LMkxlK0ppQ29SdkNXMktVdXE4Sm5NbUpWbTkwNUtn?=
 =?utf-8?B?dzdEOHczTGx2OHB0Ri9mVVp1Q1BUcG1WYmIwUHRXNUZiclFDWXRNYzhQMDBC?=
 =?utf-8?B?dFJHRysvQldCZHg3U2NvekdXZEJ0TVlLK2ZDWFpidDRYRnNSTHJaYllScldW?=
 =?utf-8?B?ZGhGUDV6WE91QlNpU3JTREQ1bDNlVHlGNlZkQ21HcFp4ckRGeFNOcjV3aWpI?=
 =?utf-8?B?OTlvVmVleW9BV0VOUFBuTUN3VThMaU5jNXFIdlFCZWNkcnIxUEl2cVhDRE45?=
 =?utf-8?B?aTdIbXdWQWlzcHFSSmJCZ0lKSDBkMzNzekFNTmVYZkVsK3ZIYlAySFVHWDUx?=
 =?utf-8?B?Q2hRT0FuOGllcFRiTjR2am5vMEYzTGhWTTBwWDVPRXlERmwxc3hiR0FxL0l2?=
 =?utf-8?B?WEo5RG5UYWdGaWR6aUFZbktrZ1Y2aXBicytxT1hGZjF2YnNjeTBkVjV5VlVT?=
 =?utf-8?B?ZGxHNysvRjJ0bHE4V2ZXNmQ4MGd1NW5tQW5RcWZ2Q1JnWWxzYzMzWC9SaGow?=
 =?utf-8?B?TnpzeGxqRXhtNjQ2VDRkN3Z3QWVHVEttb0cvNTkwM1B5dzUxY3k2dUpoRENX?=
 =?utf-8?B?VEY0MmkveG9zK2daK25paG4yNTdlL1NaSGRIWlBPZEx4aVV2VzE0eGtSWHUy?=
 =?utf-8?B?Rk5manIveHY4TFkvdUNpaFNjQkVKQUVXV3BvMTFyTEhoZk5EdkxGZkxucWVW?=
 =?utf-8?B?UUQramNBZlkzaEtINmFVK21GSlJXQ0w4VitZT3FDWTNNNFlxODVGSjMyZG5j?=
 =?utf-8?B?UVN6QXpYazhFaVR5c2xRQUl2QVJjbll0VmJrZmdlR1NHTVZ4dkcvWS9IQnhU?=
 =?utf-8?B?dk9laVRuVksrVXoyUnpXRzJwOFUwcFRod0I3ODhvRmx3YXNQOHIxV0x4a01H?=
 =?utf-8?B?TndpVndUTVpnSEd1RFNwcmdacWw4cDNncGk0K3dhNDdsK2t2U09SNmhPaU5H?=
 =?utf-8?B?N1NvR2NYTjUxRk9WR1gxeTJrcW03cVB1UnUrTU1xUnpVRHJwTDNNY05UUUlq?=
 =?utf-8?B?ZWo5eC9DQXN0UEtORmthaFRMRW9UNnExVTRKR0ZOS0pha1dHakFYcnIzbGp0?=
 =?utf-8?B?NkhFbEFQdFN6aTRKWDVNUlJCWEFmaHRwb1pEbGs0RjM1QXlKdVg3S0VqZE0r?=
 =?utf-8?B?WXBZK05jMmRiZFM1Y2tKRVZ0dGlDdEs1Q1ZhbHl2Wkl3TWkySTZxUjNCVHY4?=
 =?utf-8?B?azFHVExWVnYrWXhxRG1IZVlTNExpZWFCM2thM2FtMW1mMVN0RFhxOEl4S2oy?=
 =?utf-8?B?VEVOM0FzMnliWjVwSytCaFJOckFQNGxUaU5mK2NzSE92WVZtWEUrT1dtU1FJ?=
 =?utf-8?B?aERpOHc0OUFKRnRzV1Z5WTFxcnY0UnIvZjhZTnR4QzFXWGFLbFM1T1AxZDhz?=
 =?utf-8?B?NXdEUFcyR3hVLzBBLzJEY3p0S2hKSDFoV1FhelJHb1FrRXMyamUxdXUrNVdU?=
 =?utf-8?B?ZHdmQldjRGNUTXdnNk5LQzFJblBLNHFXUldXNGx0dVJZR0FIbFJONWt3NUVQ?=
 =?utf-8?B?Tnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 46e664f8-9006-4b82-b4bc-08db78bcce82
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 16:20:51.8894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /qzxsOBi2mZSyhCgBDGaqhiykf9kEyNAyJnLXiP/Txb5gRK3e87DP5dRMElF/lZBJYGQm7OsA1IxfPkF8QGKknkNlY00H6uQMwlayLT+pMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6651
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/29/2023 12:07 AM, Florian Kauer wrote:
...

>> This patch doesn't directly apply because there's a small conflict with
>> commit 95b681485563 ("igc: Avoid transmit queue timeout for XDP"),
>> but really easy to solve.
>>
>> Anyway, good catch:
>>
>> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> 
> I am sorry, that was bad timing. I prepared the initial patch on Friday and overlooked the merge.
> Shall I send a v3 or will someone else take care of the conflict resolution?

A v3 would be great.

Thanks,
Tony