Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21079660rwd; Thu, 29 Jun 2023 10:37:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JgfiQK/J/m1yrjsrytcnvpRgZfCM7SPldylyhvhUiBZlMIGYtGHdwnKogJEFx6pD4S4BX X-Received: by 2002:a17:902:c403:b0:1b7:ed16:c804 with SMTP id k3-20020a170902c40300b001b7ed16c804mr19991797plk.27.1688060235575; Thu, 29 Jun 2023 10:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688060235; cv=none; d=google.com; s=arc-20160816; b=Dh97xsfAw5KVO560Ha1g8YsSPH3PqFaWhNmU8odGTtDYY//G/QUGRCiBwD0lfUeFhT 78JqqDHaRydG0H+DfXKk1eEZ+IDPZkShw4Q8D8knVaTMaEf6VIDP26IIe1uDU/8oUbZj mqOXgppg8KoyiijaIchBKe7TYO/F+fLP+rumENWSHYpZRzB0LMi103+8i0x1BcK7Uox5 fmoKOANy2VzGSerAKfnkQAcI2z0qu9kXyqtjaeOlhV6ey5hF4320+ovqK7ecGpPILik0 /uSp9B6IE0lMJoKUVW4mLyH6jlQbBVDp2e6aV1ZV26N+sS6Um+gkmNapbzIAWnGuVAt1 BQwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; fh=G1D2m0cgmoaKOb92pRfzn+25Fl2vB3cfQsJwv5BfRKQ=; b=eObFRMhnXcF6wbJWG/kLhOgpkSYqRiOaNKC82ZgwbKShJdXIk/aDOjwf0qmAvV6LGs 8LC9j25feFs6lBdAlBzTMiEKXV9zF1hyXUKkt7xw446EhG0uQa7zFK4xrk8+SVKgHhZZ NJ/kfVWZ0PzYwRjJUPzsSTPjgqkPxFnqUIQvZeMClGDKoVY4iCUWmuA+J57aCCGIK9xt ososLtl+9zfgIoZR6EijhppPk7Y3fM0uMzCdy+zo5MsWr3CFwsy5uVU7yIMtv9oHYLxt jOzxGnUQxm648QE/fnPaYNYd7WIQ5Rk2O+Ym2JHpbS+EiLNiiQ3nXx7ZwWZ2A5CBfPGc 03rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=KLEnhdgt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jf5-20020a170903268500b001b18ec6ddfcsi9192739plb.294.2023.06.29.10.36.37; Thu, 29 Jun 2023 10:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=KLEnhdgt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232278AbjF2Qmf (ORCPT + 99 others); Thu, 29 Jun 2023 12:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbjF2Qme (ORCPT ); Thu, 29 Jun 2023 12:42:34 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0675630E4 for ; Thu, 29 Jun 2023 09:42:33 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9891c73e0fbso154690066b.1 for ; Thu, 29 Jun 2023 09:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1688056951; x=1690648951; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; b=KLEnhdgtu1c8kM62lKXQjj5JgvBYesh4er2kkookEOPNPvUhB+y6XBGIpsThY4Oz7c RqoxMNfBA/d6bI/EI60+uuUD06gTkpYEAI5h5V8fB0cCJJXD/2n7qzNNP/cDrK/lWzxu qg3NX0vGeSu/SOth9o5WfCH+j1hi/gtxz9+Jg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688056951; x=1690648951; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5w9ol53Pbytsh9JJtWN5s3IG7GIlT/ijcbnJWBLshdM=; b=d9zQY0st/J4Y8QkdFfpCF3HYj8UtQP6sYEXJ1m4HS49hhGp+r71plAG96rk4QwX1iJ J/paD4FMDRn9/MBafYyT4zltSymNibOqz7nFadD6R2rGgz9Vuc2X5WtKQFlWWAWIOAoZ G0jPV9yMCok79hcWAgrEulzbD71piWfwpI9ZVagA914o4r91IYhHLHAL5v+3MQ7OBYoc jaM73I9WqhQgu9x2FbR2lJDrsKW4RCmeYovUgmmZbdN3U/PPyGAlJHPAd9jlnrnx2IUz p1zN1gFt+rnzaPYLFCIRfi46pFc6uj9KUdXE6keBbLh6f4sGiapa0kInUBJG/3xP0q0j GVqQ== X-Gm-Message-State: AC+VfDydZr+arMu8NCBgcjykkghXuqmHpVDmARLaMFXOfIXJy6995OZv 37nSrSjfcwhtZFcrE7gJXG3rzYkM+c2+Sd9FbZIRWonl X-Received: by 2002:a17:907:6d09:b0:991:f0dc:c930 with SMTP id sa9-20020a1709076d0900b00991f0dcc930mr4947224ejc.16.1688056951131; Thu, 29 Jun 2023 09:42:31 -0700 (PDT) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id t14-20020a170906948e00b0098d2f703408sm6984954ejx.118.2023.06.29.09.42.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 09:42:30 -0700 (PDT) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-51cff235226so1567907a12.0 for ; Thu, 29 Jun 2023 09:42:30 -0700 (PDT) X-Received: by 2002:aa7:d94f:0:b0:51d:a2d9:85a3 with SMTP id l15-20020aa7d94f000000b0051da2d985a3mr478016eds.8.1688056949878; Thu, 29 Jun 2023 09:42:29 -0700 (PDT) MIME-Version: 1.0 References: <20230607053135.2087354-1-stevensd@google.com> <8ef3ee-ba41-8e9e-4453-73736ff27783@google.com> In-Reply-To: From: Linus Torvalds Date: Thu, 29 Jun 2023 09:42:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH hotfix] mm/khugepaged: fix regression in collapse_file() To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , David Stevens , Peter Xu , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Jiaqi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Jun 2023 at 21:31, Hugh Dickins wrote: > > There is no xas_pause(&xas) in collapse_file()'s main loop, at the points > where it does xas_unlock_irq(&xas) and then continues. Thanks for reminding me. Now applied, Linus