Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Matt Whitlock <kernel@mattwhitlock.name>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     David Howells <dhowells@redhat.com>, <netdev@vger.kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Dave Chinner <david@fromorbit.com>,
        Jens Axboe <axboe@kernel.dk>, <linux-fsdevel@kvack.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/4] splice: Fix corruption in data spliced to pipe
Date:   Thu, 29 Jun 2023 14:05:16 -0400
MIME-Version: 1.0
Message-ID: <4bd92932-c9d2-4cc8-b730-24c749087e39@mattwhitlock.name>
In-Reply-To: <CAHk-=wiDwfyj0CCupT-oEToqsNLcbsTQdcgDupF=ZETUjJQJtQ@mail.gmail.com>
References: <20230629155433.4170837-1-dhowells@redhat.com>
 <CAHk-=wiDwfyj0CCupT-oEToqsNLcbsTQdcgDupF=ZETUjJQJtQ@mail.gmail.com>
User-Agent: Trojita/v0.7-595-g7738cd47; Qt/5.15.10; xcb; Linux; Gentoo Linux
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thursday, 29 June 2023 13:56:04 EDT, Linus Torvalds wrote:
> On Thu, 29 Jun 2023 at 08:55, David Howells <dhowells@redhat.com> wrote:
>>=20
>> Matt Whitlock, Matthew Wilcox and Dave Chinner are of the=20
>> opinion that data
>> in the pipe must not be seen to change and that if it does, this is a bug.=

>
> I'm not convinced.
>
> The whole *point* of vmsplice (and splicing from a file) is the zero-copy.
>
> If you don't want the zero-copy, then you should use just "write()".

If you want zero copies, then call splice() *with* SPLICE_F_MOVE.

If you want one copy (kernel-to-kernel), then call splice() *without*=20
SPLICE_F_MOVE.

If you want two copies (kernel-to-user + user-to-kernel), call read() and=20
write().

I don't know why SPLICE_F_MOVE is being ignored in this thread. Sure, maybe=20=

the way it has historically been implemented was only relevant when the=20
input FD is a pipe, but that's not what the man page implies. You have the=20=

opportunity to make it actually do what it says on the tin.