Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: steelseries: Add support for Arctis 1 XBox
References: <20230629172041.3771-1-hadess@hadess.net>
Date:   Thu, 29 Jun 2023 11:50:22 -0700
In-Reply-To: <20230629172041.3771-1-hadess@hadess.net> (Bastien Nocera's
        message of "Thu, 29 Jun 2023 19:20:27 +0200")
Message-ID: <87wmzm9k7l.fsf@nvidia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7RIT7tiwsZIsEyHL6nOsEA+YFp721Ge17opDVoeVtmorQrLvQ6SRz97VYEQy?=
 =?us-ascii?Q?QqV9WXXkPDrO9nvVnm/A4EACXWbxN4L1KqSq4tzhectm1HT1q4Qs0yScx0bL?=
 =?us-ascii?Q?JNyz9cs+xeXs28n8yyEnGQTC1tdxJJ7xn8qoNQW7Fv8tBupzTAb57kYXO8xI?=
 =?us-ascii?Q?WB5N/X42K45nw04mcIKzc4gPkpT+oiLYEdYPrS7GV020cQ7SVs35n3Lnx61b?=
 =?us-ascii?Q?2e3EH+BF9q146/neT1yhrUEy/kAo96+ZEkFW8B/kNEofcB4duTijI46RVZ4w?=
 =?us-ascii?Q?iT2OVE753BJ0g5GhNj8RxN2AlkfuFwxvVRGUin7NhJ2L+H9NfqqCmDvbkogx?=
 =?us-ascii?Q?xtKyOYizq72D+4HC08/UAYx1r07wGv0Fk6Pvdwt1zhNis6P0tYioZYphhZoO?=
 =?us-ascii?Q?a8gdl+rm23P8dpe+3lbO9uGm0N+Ji6jyzTu+9mxgOpGMfYOeY+2mxg0zAOJW?=
 =?us-ascii?Q?z2RhPPXwYW+ZdacccYgR4tzaHtUILZc4mweRWkJYchA9uUd79LHu+Ll1EKki?=
 =?us-ascii?Q?p/7o8DgPRauzAvGtBsaD8d2y7P464TGdCnRBwozR2ge5HuFCIQ+SplwdMg5l?=
 =?us-ascii?Q?Fm8xCNcZYYprPockotRubo4LYiRMVc7Z9KKoVEnJOo6pu+Z2bDOe7eFomLsS?=
 =?us-ascii?Q?qdI8vD930HwVFeqyipIdgzzwQkBWECGKTFxMLDeYDOTs43dPgUsIlCns+kwX?=
 =?us-ascii?Q?NTQfAd2aF+7QtfbS7+GzDhn5izLjaOJb+Z1S3VShBxEblEW/Pj/DEOjkGMIX?=
 =?us-ascii?Q?YS2JCtyu/6fAKHKOZGuJdJ+NqXhyKkY2wJZpGQUWQuyzCMvA0IdMaYw4Ou87?=
 =?us-ascii?Q?E2a8UqEJNn6FDtx5MduZu1EvbpSdBMLLrs2umzV9KNz9jWj05q5lIV4jetzP?=
 =?us-ascii?Q?XX8WZmtNl89kVYIbi2KS+U4M8iZ8KApu/Kc7bLi4uXK8CdSugKaKz4SiFcnz?=
 =?us-ascii?Q?VImPO7D6X2Qbx+X8hAm20A6WYn4FK7+iVbMv/pmcAH/2YZ9JlnhQ90WT5QRH?=
 =?us-ascii?Q?bHsDaP2HRhcE33zfmRQTfJyFVQrxvpgUW+DPgtCR7Rhc2Ei8jg+fImOUmEO+?=
 =?us-ascii?Q?XCTLckdng3hhm5Gb0hy+JII0oOkFAu57mzYOMD4g3Sz9JxUP2MeHttp1/W1h?=
 =?us-ascii?Q?d4+Q3EqQwxOVjVTBtOIVMDu655wdBVC912l4YiylenjmQPgLPUkWWNTSsSd9?=
 =?us-ascii?Q?iuXEzEb5jsPra1mk1oSrv4bakhoThu8bM6f2zRrldC14Qfs/FRMEf1IWFNUf?=
 =?us-ascii?Q?boLppLhWzpZBFn3h/c0EhfST+W2CH+kXFcMWnsm0gGteAG7ttKTq5FkIxdxg?=
 =?us-ascii?Q?tJClX3HjSPKOL6qwQ5sETpWHktkwO7+z9LGAj/Qx8iLEhotW3sGxDGbtTdxd?=
 =?us-ascii?Q?aG3RN5VG7VDDNlwXgmdjUAPneEDl3t2wfr8rjJGIw02fTgRHTAW7OuDQOfXR?=
 =?us-ascii?Q?Q5P1Dea6w53AJvGpvxD49ZFvwtKHhApIpENyavyej7RgjB3SZVo3JWFETRum?=
 =?us-ascii?Q?EvhuD+u+dgvQdSmeO8ciR74cBUNepjrLuL3DXaTqKVLuo7dWswoRvw5AMvGc?=
 =?us-ascii?Q?CNWOz9R6a555qVbnf4GXElGg7efFT9EY6cXg68+nYbPZxsOI1JqFYECGAGQc?=
 =?us-ascii?Q?1Q=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d103358e-ffab-4d6d-c94c-08db78d1b7fd
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 18:50:33.4862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ooeOErVs622xxXCbRw0Z8RxqNZ5OIAzXUmfLAvX0QXP7GbYECodpc8plvYa9I7AymY+bnDLsiLe1amJgrc4h3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6220
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 29 Jun, 2023 19:20:27 +0200 Bastien Nocera <hadess@hadess.net> wrote:
> +static const struct hid_device_id steelseries_devices[] = {
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, USB_DEVICE_ID_STEELSERIES_SRWS1),
> +	  .driver_data = STEELSERIES_SRWS1 },
> +
> +	{ /* SteelSeries Arctis 1 Wireless for XBox */
> +	  HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, 0x12b6),

Shouldn't the USB device id be added to drivers/hid/hid-ids.h?

> +	.driver_data = STEELSERIES_ARCTIS_1 },
> +
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(hid, steelseries_srws1_devices);
> -
> -static struct hid_driver steelseries_srws1_driver = {
> -	.name = "steelseries_srws1",
> -	.id_table = steelseries_srws1_devices,
> -#if IS_BUILTIN(CONFIG_LEDS_CLASS) || \
> -    (IS_MODULE(CONFIG_LEDS_CLASS) && IS_MODULE(CONFIG_HID_STEELSERIES))
> -	.probe = steelseries_srws1_probe,
> -	.remove = steelseries_srws1_remove,
> -#endif
> -	.report_fixup = steelseries_srws1_report_fixup
> +MODULE_DEVICE_TABLE(hid, steelseries_devices);

Thanks,

Rahul Rameshbabu