Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21170132rwd; Thu, 29 Jun 2023 12:00:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlGBxh2zI+PcKa+j2+llnqXJVIYLJC0qybu+CqdQJpb8dTTvkCGVWSdEOb4rRvlZtTQZJZvo X-Received: by 2002:a05:6870:3c16:b0:1a2:c149:99cd with SMTP id gk22-20020a0568703c1600b001a2c14999cdmr846501oab.8.1688065229999; Thu, 29 Jun 2023 12:00:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688065229; cv=none; d=google.com; s=arc-20160816; b=FdaVZcEguBKxiQTLDdc7m9Fagys1Yu4IvetkmCFqBPSdwKjyzdWfmVkcUs4ADudTYx PKz6tVntftTwXWkI9bdJqxkTsKePzxnuYNLAOrU/COzGiORjFtrC4/to2Lt5sPetbjxT CveWZKl8IFrOfSRrcLr8UFYYFASYQv5jztLiz2mksronvKqpyyraZieRuLcIkcB+DfGE bR8vTBwfRPpNlghXCYHFGTkgMX+pjuHVobyLbFSlHuAvpG9mU5GVcJMGnaa76YESIDMO XVYpDCs9c1x2gLwVwViNHhion+Yjup9Vh6uVKVeRfoFuEWmTxU0fI1xpinWlNA4Ds9is KVxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/FlO6Jg75h7o7gINpngRzGw5kuFzFb/sRPAmynbpWL4=; fh=TpvoRWQMCfWfYyMReH1ZnHpN/ez/LTuFdSNrnV+oOp4=; b=HY1y58arjCSFCWDsQ8bhn2TFT5rii+2f2Xce6wiDtNTDhqjPkLuc96XZd/KQGhFonh owfj9YJN+iWmEX/qFynFxnCcfPf0iB16YRQMux7QQWLssOZJLJYydR3HtV90rtNuDIao HcBnkj0VSoVy9hbUlDsGHOE9z5g6WNZ+wo9vX1MwHEGxihx7EBWHiVxBEVzOzJrTBlYB xlOAhUzy6XUeoXpnyawTFTDfZJVh3Pai3PwpCLWTkKEj36NrX++HVpwkzl4R7NJr6/l3 J/Yv6G+hmdmd294umspBtV6J1NORCBy1AsBfipSWXeyPEUddcQN3A23YKoXDmLsw+zOJ dLLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WNa2Wqtw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a17090a1a1400b0025e9df04869si13212702pjk.164.2023.06.29.12.00.16; Thu, 29 Jun 2023 12:00:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WNa2Wqtw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbjF2S7P (ORCPT + 99 others); Thu, 29 Jun 2023 14:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232666AbjF2S7M (ORCPT ); Thu, 29 Jun 2023 14:59:12 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C430FCA for ; Thu, 29 Jun 2023 11:59:10 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fbaed1ac99so10550375e9.1 for ; Thu, 29 Jun 2023 11:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688065149; x=1690657149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/FlO6Jg75h7o7gINpngRzGw5kuFzFb/sRPAmynbpWL4=; b=WNa2WqtwhDEFGZyeP3X1GuyXVe6QeR2n2jhIdc8gOr1KXIKZ09eD1yTtWDdh1ttCv+ s5BT2021wqRbiDHRIBJwWy80hewSh4Qo9PcZhnMN5A3PFOzrgy4vfRGjNmwvVreROl5E tdxHLgjPd0A+hWD59C93r6O9SSU1K/IVTxdwZxwLv/2k7ZMxhKdUeb3+XF3kEMBanxd/ cN/jDDcfItExCzIAAe5ledowEqjq5jzrgMoDbqs+6pCfabTuySDQDdro6yOq332RV4MF eS40zefM0IEKgWq20lJSBDfq3AU3738aGtzH6cvCBq8UR4Om+SbolC9gbKaqijN5x6d1 TT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688065149; x=1690657149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/FlO6Jg75h7o7gINpngRzGw5kuFzFb/sRPAmynbpWL4=; b=i2iLYEGWZQhB5iyYKe6qnJjIzzJJC7Ip3lt07iXjBxL5o7CoDubpHMrjI3qWrh9SAt mshxeyNiZiVcVxIyFCVyUTpRZby+qIoxbLdzH3jJ3V83EPaPd4eMthFiVMNJOUW0tCzh mZzcDaNoItZUhrt1WTNXwcoYo4fMV3xGqdwSXa1pYKtQGs6dnHgaUJJr8qOO+8UFsckP KCQSU5dqQWN9SOM0niO1kezQ1PflOH7DhhV61DrFrDXDzM/ADoXTTHIHFlIx2CDZkXnx wuTKfc6II2szXsfNpSO9+PR/j+jQbLCYKU09mzR5csEXWCaOI15TNVgm96JmUVtbSr/U ZH3g== X-Gm-Message-State: AC+VfDxFmgKMg4RhnkuGoQxoOIfi4op6SRPbz6xiceKLktkcy379u/nR WG0XlZ6NWrFGItqzFHavpN0zXw== X-Received: by 2002:a7b:cc15:0:b0:3fa:77ed:9894 with SMTP id f21-20020a7bcc15000000b003fa77ed9894mr236281wmh.7.1688065149269; Thu, 29 Jun 2023 11:59:09 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id s25-20020a7bc399000000b003fa96fe2bebsm12106523wmj.41.2023.06.29.11.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 11:59:07 -0700 (PDT) Date: Thu, 29 Jun 2023 21:59:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Eddie James , linux-hwmon@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux@roeck-us.net, jdelvare@suse.com, lakshmiy@us.ibm.com Subject: Re: [PATCH] hwmon: (pmbus/acbel-fsg032) Add firmware version debugfs attribute Message-ID: <45a29025-4c06-4f88-b82f-a8002c25c376@kadam.mountain> References: <20230627184027.16343-1-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2023 at 09:53:16AM +0300, Dan Carpenter wrote: > d2c6444389b625 Eddie James 2023-06-27 22 char out[8]; > d2c6444389b625 Eddie James 2023-06-27 23 int rc; > d2c6444389b625 Eddie James 2023-06-27 24 int i; > d2c6444389b625 Eddie James 2023-06-27 25 > d2c6444389b625 Eddie James 2023-06-27 26 rc = pmbus_lock_interruptible(client); > d2c6444389b625 Eddie James 2023-06-27 27 if (rc) > d2c6444389b625 Eddie James 2023-06-27 28 return rc; > d2c6444389b625 Eddie James 2023-06-27 29 > d2c6444389b625 Eddie James 2023-06-27 30 rc = i2c_smbus_read_block_data(client, ACBEL_MFR_FW_REVISION, data); > d2c6444389b625 Eddie James 2023-06-27 31 pmbus_unlock(client); > d2c6444389b625 Eddie James 2023-06-27 32 if (rc < 0) > d2c6444389b625 Eddie James 2023-06-27 33 return rc; > d2c6444389b625 Eddie James 2023-06-27 34 > d2c6444389b625 Eddie James 2023-06-27 35 for (i = 0; i < rc && i < 3; ++i) > d2c6444389b625 Eddie James 2023-06-27 @36 snprintf(&out[i * 2], 3, "%02X", data[i]); > > If data[i] is negative this will print FFFFFFF1 etc. (This is an x86 > config... Did we ever merge that patch to make char signed by default?) I meant unsigned not signed. But actually we debated both ways... Signed by default would annoy PowerPC devs since they try to really lean into the fact that char is unsigned on that arch. :P https://lwn.net/Articles/911914/ regards, dan carpenter