Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
 <20230601053546.9574-10-nikita.shubin@maquefel.me> <ZHudRkB1YcMD_DaQ@surfacebook>
 <35bc18b2e685e8596b1fdc1a2e6212dc98725cd4.camel@maquefel.me>
 <CAHp75VdygQvzeWUHcQBteKZmvC6nBDeQv1c2ZJ-SBCHcjn4h+A@mail.gmail.com>
 <d5a5c0bcfecb96ea740337785623ed78a1591622.camel@maquefel.me>
 <CAHp75VfxvBXkQJiMYzLByqM_s_eVK4+YSoB-0LALrhZKi0g8wQ@mail.gmail.com> <9a41dd21fdfe3f8b8f6788a1c3822b096162f61b.camel@maquefel.me>
In-Reply-To: <9a41dd21fdfe3f8b8f6788a1c3822b096162f61b.camel@maquefel.me>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 29 Jun 2023 22:21:12 +0300
Message-ID: <CAHp75VcbyyDyVOADjO4Bb_pSBoVQuvASUuP5gba4gU-vdHxboA@mail.gmail.com>
Subject: Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx
To:     Nikita Shubin <nikita.shubin@maquefel.me>
Cc:     Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Michael Peters <mpeters@embeddedts.com>,
        Kris Bahnsen <kris@embeddedts.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 29, 2023 at 5:16=E2=80=AFPM Nikita Shubin <nikita.shubin@maquef=
el.me> wrote:
> On Thu, 2023-06-29 at 16:39 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 29, 2023 at 4:10=E2=80=AFPM Nikita Shubin
> > <nikita.shubin@maquefel.me> wrote:
> > > On Wed, 2023-06-21 at 11:28 +0300, Andy Shevchenko wrote:
> > > > On Wed, Jun 21, 2023 at 11:22=E2=80=AFAM Nikita Shubin
> > > > <nikita.shubin@maquefel.me> wrote:

...

> > > > > > > +       irq =3D irq_of_parse_and_map(np, 0);
> > > > > > > +       if (irq <=3D 0) {
> > > > > > > +               pr_err("ERROR: invalid interrupt
> > > > > > > number\n");
> > > > > > > +               ret =3D -EINVAL;
> > > > > >
> > > > > > Shadowed error in case of negative returned code. Why?
> > > > >
> > > > > Majority of clocksource drivers shadow it. Same like above.
> > > >
> > > > It doesn't mean they are correct or using brand new APIs.
> > >
> > > Or may be this because irq_of_parse_and_map can return zero as
> > > error,
> > > and returning zero from timer_init means success ?
> > >
> > > Please correct me if i am wrong here.
> >
> > 0 means no mapped IRQ.
> >
> > > > Can you use fwnode_irq_get() instead?
> > >
> > > Will it help ?
> >
> > Yes, definitely, in two aspects:
> > 1/ it makes code less OF-dependent (helps also OF people to clean up
> > the spread of OF headers and APIs where they are not needed);
> > 2/ it takes care about proper error codes.
> >
>
> Well... every use of fwnode_irq_get in 6.4 looks like:
>
>         err =3D fwnode_irq_get(fwnode, 0);
>         if (err < 0)
>                 return err;
>         if (!err)
>                 return -EINVAL;
>
> So i don't see any special care as it still calls of_irq_get just like
> irq_of_parse_and_map.

Well, this change is not a fix and not going to land v6.4 anyway, have
you checked what's in the v6.5-rc1? I believe it will have
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/comm=
it/?h=3Ddriver-core-next&id=3D39d422555e43379516d4d13f5b7162a3dee6e646,
will we?

> But i am convinced to use the same approach, thank you!

No, please, don't copy the old and ugly variant, use a brand new one.

--=20
With Best Regards,
Andy Shevchenko