Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: steelseries: Add support for Arctis 1 XBox
In-Reply-To: <8b8d8d78bb8856b933ee92ba2b9c8a256f90d29b.camel@hadess.net>
        (Bastien Nocera's message of "Thu, 29 Jun 2023 22:03:05 +0200")
References: <20230629172041.3771-1-hadess@hadess.net>
        <87wmzm9k7l.fsf@nvidia.com>
        <8b8d8d78bb8856b933ee92ba2b9c8a256f90d29b.camel@hadess.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Date:   Thu, 29 Jun 2023 13:09:38 -0700
Message-ID: <87mt0i9gjh.fsf@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUxkMHFzd1J3czZvN1p0K3hqRXpzNDhJUHlkRHA1bEVGQWFqYVhQUzlsVURx?=
 =?utf-8?B?Y3NKdE56Wk91aHVyRDhxUFhXSUlYNGhOMGxaUC81YjNLNkZYY2Z2YnpvM0I2?=
 =?utf-8?B?T3ZUKyt6Mmw4dk83cGVFcXU3b1ZhRlpxanlmNlNuUGFvb3lvVTBPdWJmSGN1?=
 =?utf-8?B?Q3ZoK05JeHR0RkV0bWtnQVFnVkgzRWs5QVo5NDI5dm9UclFKcHdBcVhqeE01?=
 =?utf-8?B?U1lOZ2xnajZXSnpBbXp6emNKOHB3Y010dnZ1ZjIzRnFsb3ZNNmxRZjl6d044?=
 =?utf-8?B?YWhZTTdOT05hcm9laE96Zi85ei9HeU9MNTd6Q3UyNWZoV1h6NWlXY2dRaFdm?=
 =?utf-8?B?YlIwbFNKNWNTT2RyNDl6YytianU0K0ZGUGxGdjJmcnUwU0lIWW4vcmdLQjlk?=
 =?utf-8?B?T3J0QnhCdVhVTzJiSnBDMHo5TGVLUWRXU1VQS3R4UldMa3I1ME1NNFowQzdk?=
 =?utf-8?B?SVYzeUt5bWZYd2VuUEMyZ0Yxemg3NjZpVFNsMmpXTUVxYk53eExHaDlTMXkw?=
 =?utf-8?B?bHdmaFA4dXRaMS8zdE5DZUpjbm5kTWk5MS9GdzJ3NGFibDJiVWM4ZmlXRjZO?=
 =?utf-8?B?U29rcTFIeWhTWnR6RWVqckkwRTk0bG9OSTlCdzJQdTBheFhINDN0SCtoOXIy?=
 =?utf-8?B?NlpvZjlRR3lRbFMyNDl1aEM5dUgwdDJobDNBS2haT3NUSHNYSTdqZENFKzdR?=
 =?utf-8?B?ZUk5VzcwWjl6SGNyck1CblZNbzRTd1pGK3JoN0hWdmtzZXdOdVRvNmc0NHI1?=
 =?utf-8?B?YStNYlhJT1FWODNoZmYwYXNyTTJOTWp0U084cHJZZE91bkFVRWx5YUx5Vlk3?=
 =?utf-8?B?RGpoTERZQ2lGRWtJRVppYWJIQmtPZmw5UXBYY0JjSHZBbk5qSDB0NzhGNzJX?=
 =?utf-8?B?YlJnczEweU9LaHZkaDh2RTdTVFVzMEZzU1VrUmhTWTJtSmNHS3kxZ1paaDNm?=
 =?utf-8?B?MXlKY2ZGeE1kL3V2UVBiT1RjbVRWQkx5SCtZZzFtNGc0RS9GNVZXRGNheS9T?=
 =?utf-8?B?RU1DaE9zOEozUlkwNk9HektnVUlkZWZmTG1uSnRVTVltV0pvcVZJMmQ5YjNN?=
 =?utf-8?B?dGhWWVB5d2ZSWDNENWtMRWZpTUhWQ0hsUW9CWHlOZzhPUUtiTWRGZENUczhZ?=
 =?utf-8?B?L2g4V1BvZm1mQ3piUDRpazlvb2V4ZWd4aE54VHU4UGNZbXhRSW5aaVdhWWdn?=
 =?utf-8?B?VlRhak1nelJVVGRJdGMrR0VuaHBvdHhUUUIzN2x5ejIxYnhzaklYWlh6MzJL?=
 =?utf-8?B?MVlaWU02MDhyTk5SSGxlUVlpbDV2VjRWVWY5aVkxdjlmRnBsSWd3UEg4eElP?=
 =?utf-8?B?RjJUeFh0YzZUZWcvalV3VDdqYXpqZThCS0JUaDdjcHZTRUwzMURxNFJoUUN5?=
 =?utf-8?B?Mld4YUE1UnFGWDUyVGVaZkNTUDMzZFFDSFI2cXZySS8vM0xXemFETlZJbklN?=
 =?utf-8?B?K1laQmNWb3ZXckFlMUFVNENXYmhTQ1l3UjV3N05LUldLZzJTV0RWVk5SL1Nv?=
 =?utf-8?B?V2NtZWcwa0xlOFd6MmlNVWloY1VJUUsrM1JhQ3NUK0wwam1YM0JQTkt6VmNW?=
 =?utf-8?B?NHZzSDVyTGpyMDB1YU96Vk9BcVdCeGlLRmo2YVBSSUVVdGdUR2oraGlkc2hl?=
 =?utf-8?B?UnA3d1duWE9UNFBTVStGck1oV1F1T3dIaDRETk9Pdm5hamhLT0sxa295MjZO?=
 =?utf-8?B?TlpMaCsyTy91M20yb0VrTFMwL2hNQkdVNWNGRndQVjVsNHdOVEF4NDBkYmtx?=
 =?utf-8?B?dCtuYXJSVFd0ZVd2WXVUOFNqblhwbGZrb1ZocG53anNweDd6NjlTNGhxUWNj?=
 =?utf-8?B?OTFtNEcxWTR1NTRud0RmZnFwcUxBODNtRWQ4UGtBZVhwdlk1Q2FQOUJxdDEy?=
 =?utf-8?B?My8xRUtDY0VMSHRQNEJlcTgvNG5LdEhUaXV6aEJnMkhvbDdXa29BUWZ5bERM?=
 =?utf-8?B?VzdlOGtwZ2pZcm5wYUJBMTcvblFzb1pwNkFodHg2RUpsOWpaVW1vNk5ndmla?=
 =?utf-8?B?YmxBRGRuOFhDcml5VjZDNG0yZkVFNTRJejZTc1hlSVY4bjZUcFYxa2NKSzhZ?=
 =?utf-8?B?N1R1S2JlclQvYUdHYlFVMVpQVnNWaTd6VGJDSkg4WElvRDVKd3JFZ3RJQjBr?=
 =?utf-8?B?QVpBaVdnWVg2VnI1U0hBQlIyenh0TkMyZWYyVDlpUVZjQnJZRzFteFM0ZzF3?=
 =?utf-8?B?eUE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 113e8c88-c6f5-41f0-d1d6-08db78dcc964
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 20:09:47.1350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5I1ATN9s2OaPg/2KC+xBQ6cJvCd+T7s/y3Hry373dnCUac4Iu/g97d0dOHPo+tph5r+axSz2kFUjxYIq4nIBGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7655
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 29 Jun, 2023 22:03:05 +0200 Bastien Nocera <hadess@hadess.net> wrot=
e:
> On Thu, 2023-06-29 at 11:50 -0700, Rahul Rameshbabu wrote:
>> On Thu, 29 Jun, 2023 19:20:27 +0200 Bastien Nocera
>> <hadess@hadess.net> wrote:
>> > +static const struct hid_device_id steelseries_devices[] =3D {
>> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ HID_USB_DEVICE(USB_VENDOR=
_ID_STEELSERIES,
>> > USB_DEVICE_ID_STEELSERIES_SRWS1),
>> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .driver_data =3D STE=
ELSERIES_SRWS1 },
>> > +
>> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ /* SteelSeries Arctis 1 W=
ireless for XBox */
>> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HID_USB_DEVICE(USB_V=
ENDOR_ID_STEELSERIES, 0x12b6),
>>=20
>> Shouldn't the USB device id be added to drivers/hid/hid-ids.h?
>
> No, the hid-ids.h is only used if 2 files in the hid directory need to
> reference the same device.
>
> Since changes to the way hid drivers are loaded, there's no need to
> blocklist the devices in the core to handle them in a driver, so
> there's no need to reference the device in another place than the
> driver itself, so no need to add it to hid-ids.h

Makes sense with the fact that the device id is only needed in this
source file. For example, you don't need to recompile the steelcase
driver module when introduce some other unrelated device. Thanks for the
clarification.

-- Rahul Rameshbabu