Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b8d8d78bb8856b933ee92ba2b9c8a256f90d29b.camel@hadess.net>
Subject: Re: [PATCH] HID: steelseries: Add support for Arctis 1 XBox
From:   Bastien Nocera <hadess@hadess.net>
To:     Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Thu, 29 Jun 2023 22:03:05 +0200
In-Reply-To: <87wmzm9k7l.fsf@nvidia.com>
References: <20230629172041.3771-1-hadess@hadess.net>
         <87wmzm9k7l.fsf@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-29 at 11:50 -0700, Rahul Rameshbabu wrote:
> On Thu, 29 Jun, 2023 19:20:27 +0200 Bastien Nocera
> <hadess@hadess.net> wrote:
> > +static const struct hid_device_id steelseries_devices[] = {
> > +       { HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES,
> > USB_DEVICE_ID_STEELSERIES_SRWS1),
> > +         .driver_data = STEELSERIES_SRWS1 },
> > +
> > +       { /* SteelSeries Arctis 1 Wireless for XBox */
> > +         HID_USB_DEVICE(USB_VENDOR_ID_STEELSERIES, 0x12b6),
> 
> Shouldn't the USB device id be added to drivers/hid/hid-ids.h?

No, the hid-ids.h is only used if 2 files in the hid directory need to
reference the same device.

Since changes to the way hid drivers are loaded, there's no need to
blocklist the devices in the core to handle them in a driver, so
there's no need to reference the device in another place than the
driver itself, so no need to add it to hid-ids.h

> 
> > +       .driver_data = STEELSERIES_ARCTIS_1 },
> > +
> >         { }
> >  };
> > -MODULE_DEVICE_TABLE(hid, steelseries_srws1_devices);
> > -
> > -static struct hid_driver steelseries_srws1_driver = {
> > -       .name = "steelseries_srws1",
> > -       .id_table = steelseries_srws1_devices,
> > -#if IS_BUILTIN(CONFIG_LEDS_CLASS) || \
> > -    (IS_MODULE(CONFIG_LEDS_CLASS) &&
> > IS_MODULE(CONFIG_HID_STEELSERIES))
> > -       .probe = steelseries_srws1_probe,
> > -       .remove = steelseries_srws1_remove,
> > -#endif
> > -       .report_fixup = steelseries_srws1_report_fixup
> > +MODULE_DEVICE_TABLE(hid, steelseries_devices);
> 
> Thanks,
> 
> Rahul Rameshbabu