Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 15:22:14 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning
Message-ID: <ZJ4EFjIU8VmhFN9c@bombadil.infradead.org>
References: <20230607120857.3621364-1-arnd@kernel.org>
 <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Thu, Jun 29, 2023 at 05:00:42PM +0200, Matthieu Baerts wrote:
> Hi Arnd,
> 
> On 07/06/2023 14:08, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Since usermodehelper_table() is marked static now, we get a
> > warning about it being unused when SYSCTL is disabled:
> > 
> > kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]
> 
> Thank you for the patch!
> 
> We also hit the same issue on our side after today's sync with Linus'
> tree. I confirm this patch fixes the issue.
> 
> Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> 
> I didn't see this patch applied in Luis' sysctl-next branch, do you know
> who is taking care of it?

I'll send a second pull request to Linus now.

> > Just move it inside of the same #ifdef.
> > 
> > Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")
> 
> A small detail: it looks like the SHA has been modified, it should be
> 861dc0b46432 instead of e6944e3b75df7:
> 
> Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")

Adjusted, thanks.

 Luis