Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21429290rwd; Thu, 29 Jun 2023 16:18:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5c0qdpR2Wcz5mdIUUtfXUkv1S3Gkkb/UBYo+i44poIXTfr4E23c+qhZiBo11dfAdTe3Opz X-Received: by 2002:a05:6808:f94:b0:3a1:de5c:3279 with SMTP id o20-20020a0568080f9400b003a1de5c3279mr1069612oiw.14.1688080702879; Thu, 29 Jun 2023 16:18:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688080702; cv=none; d=google.com; s=arc-20160816; b=MAV5xoR3m7iguUnlJIAP/UV07dYRiQihn4Ougiga/tcW6AscGSr1kF6RRChqK3r7zr Zc/TlLyA71rhHAgBAqUPNM+lZtJR6dLt/aqtafrY5g75qAndtn7ZOc3MrOrUji7S/TfC SGgfaX0ual0uFPR+e4CZHuRz8NOScqEAL2ZDnKPBhNbzShBB+xZh2hTzna/y7LPn/GK2 wnNp0UKEZCZXm8G3eUx95biiG4YVkPR8mifRfc608ii5Ofp50VlAn6wpRwLB2BkFfegU lnc2b9s/doDejthEWngcR5HDkQd43AJwCudv2Hnry7NSPzPlitsgQCqhDXHFFbaWGf2k 4W6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ouIIJPlckIJc9s2Ly4rKH2jNlWjaAkDeAVhQw+0U5tI=; fh=WUEY+oAJIFgM/51+q8PH72R4umiCgb326/xtUK4FtW8=; b=WmKTP/U6XlUvvzr1aLd/1Tf1KCrn/FzIcCid3paUXONBwBmlsWMaYfxUGaq47/gWxS NZ/Q3bPujD071puoie/Ne5jpXpAPyihf4E7p60ZUbO9EuhVUZT2PJnQwPWASuBH4yPt7 w3wZTirfVLRpxxjzZguPNg5gpZ/zDtjk5V/zQFP00HiwKC6jCApbmHlEqqhcDXhIoVMU aAB1rb5z8vYYtMMHeXjoC8Uv1tBwk590CR9flFl1mZB+cvC1mNTGUTCzbRSM28SELXQ3 qhRJpKrcx+WhRvvnOwQzi7Ecrcrepgn7SE1yfKsVBZUdvzxcIX9uuk1Tv8jYEdDqigyA d8rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=m4m8CXI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h18-20020a63f912000000b005575b3902c1si11419197pgi.346.2023.06.29.16.18.08; Thu, 29 Jun 2023 16:18:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=m4m8CXI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbjF2XLo (ORCPT + 99 others); Thu, 29 Jun 2023 19:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjF2XLk (ORCPT ); Thu, 29 Jun 2023 19:11:40 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF7630EC for ; Thu, 29 Jun 2023 16:11:39 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b6a1fe5845so19571841fa.3 for ; Thu, 29 Jun 2023 16:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1688080297; x=1690672297; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ouIIJPlckIJc9s2Ly4rKH2jNlWjaAkDeAVhQw+0U5tI=; b=m4m8CXI5kC9XyLaB3B93wRD//YHWodMtxl8KCaREWm2mLWWsOuW2lkGcxQb58OX/Z/ Ad662wXUZPHwSQYS4o4BeqGrSKnLU0jAVe0i0Fo5db3KfKvNW+TvQ6XPT0oF8WzbFue+ D6w0CTphRNULh071DYz+veN2UHVwygD1RslfbZSniNwqHugKQoMf+llv5QYqiC3uMdiZ Sr2xQughruiYIKC/i99TZhG0Y8OcRRBMQFKcxRZgWEqCywKswIbBlA/FYJHGF7IABDh9 WScBt11ybJihu6wKpgYSUNXNvMF6E8kbQap6AYhqQSKFWSq5IlUGplv9GtbBeXP5apMB cEbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688080297; x=1690672297; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ouIIJPlckIJc9s2Ly4rKH2jNlWjaAkDeAVhQw+0U5tI=; b=ef/ZeugVL0hZwHETH9XkCuUnX8LRVYkdxdcgVIXt7febbPDOZVL2d/XhNfwC5DdX7Z RYOeriN9vu8l2oGoZsfBgylpE41jvYvXZy5IXjjtOwhCyeWJhtbC5+Qlx7wfzgvqO1cL D+6jdqzBY9krtLaNpFXBSoZrs2ReOny8SwI/5YsxC3/RJBSm1M4vLElS5zSDnqQmU+zo f8YIWe8ktKStibl96fA3qpbWMsUEcd+g1JS853O1KrQLGfWqEUyMd0/6WB/G/WVHuutK 6+DY7Okz/XjtbqLBhQEfTDixe/ogp/oPDmhsM+4ealiP+MlxO2+i6Gdwj0ulv2jxS2Uy Il3w== X-Gm-Message-State: ABy/qLZJSxNhD/eA8DE43duFC6JIf9cUF9p+xdHn+C+7oKRo/JXrLm49 a3MaFa7TyR2yHB7ptdIJ2ZuneJvjP3roSaj++tORzA== X-Received: by 2002:a05:6512:1094:b0:4f9:5a61:195c with SMTP id j20-20020a056512109400b004f95a61195cmr976866lfg.13.1688080297379; Thu, 29 Jun 2023 16:11:37 -0700 (PDT) MIME-Version: 1.0 References: <20230629-rebuttal-vagueness-a699deb7c7b3@wendy> <20230629-museum-playhouse-6dbe7e573f2c@wendy> In-Reply-To: <20230629-museum-playhouse-6dbe7e573f2c@wendy> From: Evan Green Date: Thu, 29 Jun 2023 16:11:01 -0700 Message-ID: Subject: Re: [PATCH v2 03/10] RISC-V: shunt isa_ext_arr to cpufeature.c To: Conor Dooley Cc: palmer@dabbelt.com, conor@kernel.org, Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Andrew Jones , Heiko Stuebner , Sunil V L , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2023 at 1:30=E2=80=AFAM Conor Dooley wrote: > > To facilitate using one struct to define extensions, rather than having > several, shunt isa_ext_arr to cpufeature.c, where it will be used for > probing extension presence also. > As that scope of the array as widened, prefix it with riscv & drop the > type from the variable name. > > Since the new array is const, print_isa() needs a wee bit of cleanup to > avoid complaints about losing the const qualifier. > > Reviewed-by: Andrew Jones > Signed-off-by: Conor Dooley Reviewed-by: Evan Green