Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 08:23:06 +0900
Message-ID: <87a5whkg4l.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     "Mark Brown" <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Always store of_node when getting DAI link component
In-Reply-To: <1d74d2ed-0c4d-4fce-849d-5f2288394569@sirena.org.uk>
References: <1d74d2ed-0c4d-4fce-849d-5f2288394569@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vv/Ixyt+Y52uLzWPRnUOTrub1riD3AnsXR29nzqJuxdaI7EU92ZWzhQTaGpx?=
 =?us-ascii?Q?nP1ulLrjmr9d119ixGGNLb4YZVTGbjBk8PBW2dZZHe4tubtnAxdinJp+gDES?=
 =?us-ascii?Q?mjpJzbOTye6N0wNNyzhSwe+rfpxFupRw9xAvTdkA/cfe7kKciz1Mv2bka4vt?=
 =?us-ascii?Q?mu/4excR9YtQi0ipso1d78gdQgGYQsQwgAoB+IAegCovteR7mr3+0pltrRO0?=
 =?us-ascii?Q?obKq4XblG4vl7Od6/7RP1hNMpj/XldPkpWfCQjNkQlhG5tD+Vz1JWtnxGPdb?=
 =?us-ascii?Q?+/rVDac61KKXtSkTOTccZrAQkBg85YMv63CoAZsgCNd1t/CZ110AhBT0SB6q?=
 =?us-ascii?Q?r2kEXAnkXNJaY4ngozIq+Yurwk9Ds8QHrhqtsPkbEO+vp+yAYENBpBNPw0nK?=
 =?us-ascii?Q?JVpbCmPbYt0MRuNpsJptyXHOAH6RzEGrJhODCsp0j63gyqjKcSpmoqVq6gYQ?=
 =?us-ascii?Q?6PEkGKmFYzPZPoAx2GyNqpJbWbKWfLGU0nvpt+ZUGpruMsajKgxaXmHV8E30?=
 =?us-ascii?Q?rT/J4mqg2oUwBwB9kDNEbmL1jIrrtlMUbkF0r9w4EqWVfkquRyQcg1H/MpkD?=
 =?us-ascii?Q?zMq4pxg59lxBKYe3p5vnPPyCdsr2K9eyz4dcZz4TKJ/C5vBHHvpNJ//Drqil?=
 =?us-ascii?Q?8gXwgT/7VQmlbS7zZ7nYNX2s6JaSSIriB8+1T15PSaLWDbvNlQPWEb75IKgM?=
 =?us-ascii?Q?gCGLnbHf4lRqcELUqgQZyvWMUOH9ugI5ICJqW9VIdSYYB0Heq6x21xoDJble?=
 =?us-ascii?Q?jieLeicHGr/Wx4DxIkfKpI/V9HARD0ZhTy91MuvT1IyaGp1Pd4gnpmHrg1YZ?=
 =?us-ascii?Q?1hXdSAd/lDwOAnVEtqXm0Latlpec/ElnUKt9gscLZSMFc9KYlo3dT7A6NjHl?=
 =?us-ascii?Q?ceY+/D27jxAp428/x0MEKPUR99CMdnBJyftRlszReOu2lcyyL6oupJ3jiWt+?=
 =?us-ascii?Q?+S9miBIZq0vgsJM4MbEfODh4g0XxfMmdSlVhlgbKe2TGN3HYORjQJFv9F5jJ?=
 =?us-ascii?Q?dC39NP2PYxAQdHcXI0kDrMnOsM4/TO5NlGsIn7rrzcotIFxfRfpW+4e0ImrL?=
 =?us-ascii?Q?kF2MKWRhDy8inJryGz+C+sPABAeYkfJPU9c7JgEcpNpG2AROLD9abu6+NEgY?=
 =?us-ascii?Q?9zgr/s+Mhuv5DYgfYEZVs5I8QcTO8E95tLmr1OQ3mr57qw8uXs0Qvsfc60Ta?=
 =?us-ascii?Q?12KnpiCr239fpCXtqCQrup3O+LixjkcvKJbhTB3ww1CWOjuP0I1qixSTRH0o?=
 =?us-ascii?Q?6ZBj8Be5r+aP1H9t+fTGv67Osa/oPV2D09243UrCWPePFolPsoQ/XTKBq8tP?=
 =?us-ascii?Q?tH+8h6cKbtx1NTqLNvVzboGNyl9tTgw5e5c3kgInIC7mmzAQjv1QLRAJjEHR?=
 =?us-ascii?Q?Fvpz7A9oPiFWYzK8nEqlwoFS/k3dM6m+woMmXuKvtQiDgJns88/1coCakNNV?=
 =?us-ascii?Q?T159izjApy21R78P9awno0+GcOwJfDIFfhuru/Rq6CSRHB52bOLWFSPQbE20?=
 =?us-ascii?Q?PMP0/fopEQ/x+SSxVMACgS1cTHOiKVp9felYzKHxxEHJNj5+wSZNio9L83Rp?=
 =?us-ascii?Q?ORRX/f3NpiE1NiuJ6fIsKswCtzyuGaS7CCmBSYO4YAdGUJZ5/E0StsfT4tCX?=
 =?us-ascii?Q?+opH3d5o493PQn6FJkEqgwY=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f413f472-c38b-4588-8a57-08db78f7d049
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 23:23:15.7609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1bRFQpYgFaGRHld4JaI3Ll69HSr1WqzvqwLgosesoUpcPiUGN5SCRXcE3QnuEpT7oxjv7uTHxRhG1g11EKHWO9XY4ni1YxKRG9M4zEtFYtAvs3R4YvqHrJiKpoZSZMt3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8603
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Mark

Thank you for the mail

> > > But I think we want to set it under lock and if ret was no error case ?
> > 
> > It doesn't really matter - there's only one possible result, and nothing
> > should be looking at the dlc unless we return success, but yes that'd
> > probably be a little cleaner providing we don't ever return early.
> 
> BTW that's not to say don't submit this as a patch, just that it doesn't
> need to get applied as a fix.

Thanks. I thought it is not a big deal.
But yes, will post a patch.


Thank you for your help !!

Best regards
---
Kuninori Morimoto