Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77c97dd7-a692-4881-e87c-373ad1bfa044@intel.com>
Date:   Fri, 30 Jun 2023 10:05:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 4/4] KVM: selftests: Add test case for guest and host LBR
 preemption
To:     "Zhang, Xiong Y" <xiong.y.zhang@intel.com>
CC:     "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "like.xu.linux@gmail.com" <like.xu.linux@gmail.com>,
        "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230616113353.45202-1-xiong.y.zhang@intel.com>
 <20230616113353.45202-5-xiong.y.zhang@intel.com>
 <b4dac7d8-06d7-6d16-117d-5953cd37c34f@intel.com>
 <MW4PR11MB5824984347876F9D3DCB710FBB25A@MW4PR11MB5824.namprd11.prod.outlook.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <MW4PR11MB5824984347876F9D3DCB710FBB25A@MW4PR11MB5824.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3RvaVd2STBLQTMvVXRRdFJaclJ5dUpJMzg3cDV6VkRvZ1pIaUlUQUJIVG9C?=
 =?utf-8?B?WXVPZ3FaSzZCVHlCQWF6aERrSEFleFd4eVJuNTN4Q0o3VVNiamdIcXhXb0da?=
 =?utf-8?B?Y1M1Q2p0elFWOU5FNStXQ1VwSmFnc2EvdFlObjB6cVdpaDAwY1k4Vm9tRmVw?=
 =?utf-8?B?ajY2UzJPcGxqRkJ0RWN3QVd3cEdGSGNndmw5SHpVOFRXNEZsNGo1UWMzRFlu?=
 =?utf-8?B?bzNCdmNYbVo3NEs2dENSbFpvRFUrc2xoWDZSVDArUDgwSjVpZHVCYmkyS1lW?=
 =?utf-8?B?MzFhekp3YkUvNXFDTVlsMlNKTVZHT1Ntd3FLU2xVWWRYMVdmMHJYWUIvNFVT?=
 =?utf-8?B?WGovMGZ0dzNaUEhaQlRwVVZhclA4bmI4dTk3azBpWmZBb013U01GdUozMHMz?=
 =?utf-8?B?a2twL1JNTEs2clpEQ0JVbE8xbldlck4yNUF2a1B1VkJIRG5lM3BwaWluL2pL?=
 =?utf-8?B?V3FyVjYvTkFBSkh1TTQydGhuTnhPSjhORVVLWkZCSzZDSzJRV2Jib2c5VkNh?=
 =?utf-8?B?K01XL1c4bmFRSDJ6RjZac0ZFejFUZWRzUlUvaXpmdmRWejlmU0VFV3dtUDRR?=
 =?utf-8?B?QU1yUERUcEFBVzVSV1NmTE1WT3BaRjAwM05WSWpHS2JPV1BkR2hQbHhaQ2pB?=
 =?utf-8?B?L0ZINlF1NTdSMHNmNWkxWC9IQ2JhTVJnSkFhVUNUeGVBQ1pIY0tJdlN1czNx?=
 =?utf-8?B?M3RrKzFaUHloLzJ6eWNoellOL3VRVHY1SnpDSUN5bmhvZ1JaNEpxZk03MmRG?=
 =?utf-8?B?ak5zdFBDL0N5SXNIR0xqOVowcmd0MDVoa0loM215NDRtcmdjYWVPcnAxZXZt?=
 =?utf-8?B?VGx3Z0pteUt4ckV4Uzh0N000TXNPNC91ekY4dCtvZy9TZG5zK1hGbks2R3dw?=
 =?utf-8?B?SENXdmkxYURRaFp4eUVVMFJuazdqNjFVOU1lWU9RbGs2aXZZMEthNStTekJ4?=
 =?utf-8?B?NWM4RHEwa0dXdFF6TW9Ta0tDei9GcmJKLzRhYzR3aUdOZXBtU0JoQnJ3OGIr?=
 =?utf-8?B?N2Rvdk5VQU5jeWR2c1JrdzB2MmRFcXEzRFpGMUphZEt3bmRNb0djbFNRVFI2?=
 =?utf-8?B?T2ZZTWNlQ3hSNDkvVllPMWVaL3dQcjljUVdpM1hTbExKYU5hWC9HMXdwZkxs?=
 =?utf-8?B?UzdVaVYyNjJQM1VBUEV5L2pyWDZnK0VaSFhjakNOVHA1a0ZmRVdsK0JCSTV2?=
 =?utf-8?B?eDRtSUxJVTRZRS9TcWswQzdNYjBhanhuSGZkM1ZydXNiQmMvdGY0MytaSU92?=
 =?utf-8?B?Y1dYbExSQmRod1pwRWVDUmlZTkhCajJwS1dpSTE4WmR0SnFuSWlnNU02MERH?=
 =?utf-8?B?SStlUnF6SGY3Y2NtV3BaR2J0MEhiWm03WVhxemtSektCNUNtdUhZdVlUSWNi?=
 =?utf-8?B?eUJqRWg5R045ay82SzNsVklXV0l3NWhCdlVFVThrcEQxVGgralNJQi9MSEgy?=
 =?utf-8?B?bkxTT1VpaEwraHNXM1ZYNG9hZG94d2c0UW05UE9NR2FSZGVPZGNnd1dYeGpP?=
 =?utf-8?B?NnY2ZVhmR2xNbVJXUkV1V2V5aGtSeWphRTEzRXQwUUF2alJqUW9ZbXp2UCtv?=
 =?utf-8?B?U0VJdHQ3L3pFTnN0YkZUMUZqRTFNVDkwL2h3Um9ZT21JdCs3SFVSRGZBK2hK?=
 =?utf-8?B?cW9RNWM5cmw5VDVWa0NhUGRlVy9jWDlObytiSCtIcXFyQzREL0JMczN4dWZp?=
 =?utf-8?B?NldZUkpaN0tXZGlEcy93TklNdXZXVWFPY1dXVWFYN2Z1MWx5Y1dlandxWGhN?=
 =?utf-8?B?azRuWVFDZlphTW5xSnF0ejEvWHRPODJ6VnRIMDQreUNwUVRhcFZzLzhUdWlT?=
 =?utf-8?B?bEozSkx4eEk2d2xFODBBZExiZzFxb2NBaTBvb0tGUEpIZzB1YUpFZU9VbmFz?=
 =?utf-8?B?Z3M0YnhYSzdYa0tFTjk1U1UwdkJZWGtNbmFGaElJS1BLcEd5UjQwek0xTG8y?=
 =?utf-8?B?MUs5eVM2d3ZNbUtDNTQ1Q01IalNmTDNwQnB6Z0pnYm5zaWs5RmVYaEN3MGxR?=
 =?utf-8?B?NGxlRnlSeDYvVmFDL3IxeVV1TGgxa3EybGNkb3p3MWdiNWFzVEJpZmRDRzRZ?=
 =?utf-8?B?TnhBSTJ6RDVvOUg4WlF4OVoxM0JkQzhOay9xbUYyTmtyUDIxekI5VVUrNzcx?=
 =?utf-8?B?WjY2UjBzeEhpMEJaNmFNcU5kRHE3cElQQ05mQnY0N1pCSFlaYzhMdFRUNjhk?=
 =?utf-8?B?NFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9af9a13f-5539-4b55-399f-08db790e8c47
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 02:05:59.6084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mrV0ZCIjT4W90Wg+QNrdoQ6+Sd5SWdgxAvLC8rzBYIq56xIdNv7oH1DjSbQ3hMgS3u084ZcKB8ykhjxxDGiYeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4841
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/2023 10:52 AM, Zhang, Xiong Y wrote:
>> What kind of issues you expect this selftest to find?
>>
>> IMO, it verifies the generic perf schedule rules but cannot find specific issues.
> Current vLBR event break the generic perf schedule rule. So I write the fix commits and selftest to avoid future broken again.

OK, I think you need to refine the assert failure messages and give the 
users  straightforward messages showing something

wrong is happening and stop the following tests since something is 
broken, no need to trigger more errors. E.g.,

+	TEST_ASSERT(r == LBR_MSR_WRITE_ERROR,
+		    "1. Unexpected successfully read/write guest LBR_TO msr");


"1. Unexpected successfully read/write guest LBR_TO msr"
=> "Host LBR ON: Detected unexpected results when write guest vLBR MSRs. Stop testing."

Then at the end of tests, you can print a successful message showing the perf/LBR is working as
expected. This way, testers can got clear result indication of the app.

>> e.g., whether the LBR data is corrupted in some cases. If the selftest can verify
>> whether
>>
>> guest/host data is maintained correctly in a high contention env., that can be
>> better to
>>
>> sever the purpose of selftest.
> Once vLBR event is preempted, I see designing gap and guest should get wrong data, it is out of this commits scope to fix the gap and to verify the result.
> I should add this into commit message.

Yes, refine the change log of this patch to tell clear purpose of this 
app so that users know why this app is needed.

>
> thanks
>>
>> On 6/16/2023 7:33 PM, Xiong Zhang wrote:
>>> When guest access LBR msr at the first time, kvm will create a vLBR
>>> event, vLBR event joins perf scheduler and occupy physical LBR for guest usage.
>>> Once vLBR event is active and own LBR, guest could access LBR msr.
>>>
>>> But vLBR event is per process pinned event, perf has higher priority event:
>>> per cpu pinned LBR event, perf has lower priority events also: per cpu
>>> LBR event and per process LBR event.
>>> So if host doesn't have higher priority per cpu pinned LBR event, vLBR
>>> event could occupy physical LBR always. But once per cpu pinned LBR
>>> event is active, vLBR event couldn't be active anymore, then guest
>>> couldn't access LBR msr.
>>>
>>> This commit adds test case to cover guest and host lbr contend.
>>>
>>> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
>>> ---
>>>    tools/testing/selftests/kvm/Makefile          |   1 +
>>>    .../selftests/kvm/include/ucall_common.h      |  17 ++
[...]