Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21593560rwd; Thu, 29 Jun 2023 19:17:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlFeisD62HwnUfqkmxZLtuFk9YzLMsDCGGF6jj63pS3knAfAvIEj2fkYYxTGNJcI6TYAysL0 X-Received: by 2002:a17:902:c10c:b0:1a5:150f:8558 with SMTP id 12-20020a170902c10c00b001a5150f8558mr960176pli.17.1688091447289; Thu, 29 Jun 2023 19:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688091447; cv=none; d=google.com; s=arc-20160816; b=ncAqw6yHWxjDnmEEKBjjcJ6qaACEKDY1bfBVDB7RLPbqlEsxlAQO3mmxUr5tEIe+mV H0bcmg6qyNhPochIw5boO4YjJpkT+eFatjAGIyE+3LIX/fV34vZNgMUfsDchu/gTs8IT HFazu/tCKP+UggwEZMEMM3TlP1fYXagvPjUA8rCSNKLpFtOYOGk1a5udkOr6vBdLnewZ AFM5n1E7gcGzy2uaz/Eo+1AhGRsiWrhXy4YnlApXKHK/Hm4klJe6v0Y40Mj90QTkurYc gB1rgG9Nd5s1g0FUvr4RXeAvPnlI3V+5B5BaY3WxCych2UfYxZyf2qNbUGQSAzhfR+Hz va5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=bgpQbtO9SF92yiygf8Ky0ViLq2sNHlzHQWMo6oLZtyU=; fh=f2/2HyUqLrsLfaMzPtpX0SQECN7afHCKNNDFnGXzMh0=; b=SY16pXfxNktKrvL9bIoEDm0GVbNAODBZct2+WVbwuo8Saa9+76bc6B5i69e3qzVPVU qEE/xh0Xz5tLA2g/r0C0474kvMm44xkbdFM5NyZLFaNfPdo5vG7E+pVGsLLNB4NQiKQP r4f2rrCA1Xib0UZv8l3TwNQy5Rj2F/mfWG+cluShxrQ+XnjHUAblE0Noe7N1IvOocgag ACgCAhU3D6XaCaAZJqaKIlbcrji+uaQXPhg6lthPkOcYHdZIQ7KOEYFFfIyb3rBhSBZe 80vpSPrG1gu9Fslhr8/DTXQ8UUS6upLVT1/ZdXdAUvubEBlTyKP5W6/Prr1sOD6a9eTm roog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a170902d1cd00b001b7f2171a9dsi9698611plb.521.2023.06.29.19.17.12; Thu, 29 Jun 2023 19:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231724AbjF3Bmx (ORCPT + 99 others); Thu, 29 Jun 2023 21:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjF3Bmu (ORCPT ); Thu, 29 Jun 2023 21:42:50 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7198230DF; Thu, 29 Jun 2023 18:42:44 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 419057FD3; Fri, 30 Jun 2023 09:42:32 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:42:32 +0800 Received: from [192.168.125.93] (183.27.97.206) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:42:31 +0800 Message-ID: Date: Fri, 30 Jun 2023 09:42:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter To: Krzysztof Kozlowski , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Walker Chen" , Xingyu Wu , Emil Renner Berthing CC: , , , References: <20230626110909.38718-1-hal.feng@starfivetech.com> <20230626110909.38718-2-hal.feng@starfivetech.com> <92171465-d2ba-c3ba-aa55-0f705e924a0f@linaro.org> Content-Language: en-US From: Hal Feng In-Reply-To: <92171465-d2ba-c3ba-aa55-0f705e924a0f@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.206] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Jun 2023 17:32:04 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter. >> >> Signed-off-by: Hal Feng >> --- >> .../sound/starfive,jh7110-pwmdac-dit.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> new file mode 100644 >> index 000000000000..bc43e3b1e9d2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-pwmdac-dit.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 Dummy PWM-DAC Transmitter >> + >> +maintainers: >> + - Hal Feng >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-pwmdac-dit >> + >> + "#sound-dai-cells": >> + const: 0 >> + >> + sound-name-prefix: true > > Drop Will fix it. > >> + >> +required: >> + - compatible >> + - "#sound-dai-cells" >> + >> +additionalProperties: false > > Instead: unevaluatedProperties: false Will fix. Thanks. >> + >> +examples: >> + - | >> + pwmdac-dit { > > pwmdac? No. For a similar implementation, you can refer to "spdif-dit" in arch/arm64/boot/dts/rockchip/rk3328-rock64.dts Best regards, Hal