Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21627186rwd; Thu, 29 Jun 2023 19:56:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlGWDPEOF25lEzN6BkucXihJNDpu5li0B5amPofMurSp4eOf22wshnzfSatxqUHZNo4nMRE0 X-Received: by 2002:a05:6358:c6a8:b0:134:ce45:b782 with SMTP id fe40-20020a056358c6a800b00134ce45b782mr1325034rwb.21.1688093791068; Thu, 29 Jun 2023 19:56:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688093791; cv=none; d=google.com; s=arc-20160816; b=JPYxc6c52ogoAAkrauSMy/ZBpmXZ/hXRnxEPMGLY8wAasF/S2jQW20evCAcyDGNzDR gekdWNkn+lP86FauOIeoSFOn8Q022wcc5Wa9jqjkr7LaBS1QbBUp6RsVCEcP6DqTYLQG cojfTEacpCwpB4SNvRq3S+beCnK7Yb/Sb4qrLfFeCoQxKX3j3O/r7dQvRKuofAz3NOBy hswH48CgVu70KMT5oyZHBwKb477Me+9UDTdyO0Ea4+cQmwU6KMwZUY5ZOD5ztg7Igdnm 4dZYf9BvpoTNcYOkXbPadpLEjDWIvDQtYQz4S3r4KQ6I8jRNNsV+PRaI3S+e7SW5kuAP EiQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:subject:cc:to:from :message-id:date:dkim-signature; bh=o+KGax9Prrl1aK209DwaJqb3NAowYrI4dDxErwwgPnk=; fh=IKSGlQL4Lj7mWSTeBZjOxj1+2e7MrwqHwUgo1KuCS5E=; b=kicQ++PBgYLlO6LGWm+4cju26SQMiiZxneOqKVeRMPGlbff9LVfP1hQUDZrePs5S6l ZAYsmBeC4z8mqLxOTEB58LBAkK5Jqw3QN8es72M8nU5yvWz/F7WWRED79mqEGmpGlZyZ NAxGGoap28Y/mlSrYcl6HfVxQaeTxJmShBG41kIr4WPP8tRhoXqaoTQZlxBDXuJb7QU1 oBid4TPBSfNrvhlaDuaVDKXq/SBXVDxEpcQztf5Bf+gCfn9jRRoBjobSaMRexR+n1a0u oEbnVybsdvLKHE4/nezq/OFud55j+Kez0r0baKiCO6gxq7PWP/tNQJK02msAOy+8MIzW 2loQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=C2ts+DNr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l4-20020a170903244400b001b80efa4e2dsi7795164pls.390.2023.06.29.19.56.15; Thu, 29 Jun 2023 19:56:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=C2ts+DNr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232154AbjF3CPQ (ORCPT + 99 others); Thu, 29 Jun 2023 22:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232444AbjF3CPC (ORCPT ); Thu, 29 Jun 2023 22:15:02 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58413AA8 for ; Thu, 29 Jun 2023 19:14:44 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-7659dc74da1so122167285a.3 for ; Thu, 29 Jun 2023 19:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1688091284; x=1690683284; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=o+KGax9Prrl1aK209DwaJqb3NAowYrI4dDxErwwgPnk=; b=C2ts+DNrL1pQiS6JNzSxtLrzLQgwS4NaOS/YnhlmW81by+di/BvhE8arb4BA27x8I9 7RPiRL//DKgH00EWeUlk5nGnq47qPNg0L0YQOoRH1h54u2xxWKO86Xvv9Rkk+c2eDKHt O1QfWsUjjmbF8QQNVeIczz6ooIRZKDX315WMqWw1qkQ83MSnyUdIBgepvnm6VVd8ElDu vAA6b7QH2tyRze/wcGKp7SgR1fT2JVAF2IUpQNsWJqAGycMfgoNaxs6iVUjHBMXHEC6T ZJc+PuSXkrXJY82Z44ZETTdS+Bry/TBqKQ5TAUq/ajgrFtq9MJeNcTxjIOKw1x37s4JV lXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688091284; x=1690683284; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o+KGax9Prrl1aK209DwaJqb3NAowYrI4dDxErwwgPnk=; b=FjAhrO4aevh9TnnLRCfH6SvcTDRAb9XFeGorOqIojd0YHGwHo46zlPQO1wiHNyxL8H 6DLom2aix+Ucx+kVLgs3bWB1Hp/NkGPH/wp4Qgwq6AgluJb6+nFPg5JZrEQfr//XZl3s gpOF3DLKG/wROOyPoVcikGyGX4yFf8zVd+Jm0N8MP5usnkuvzYFcAQa82yBw5F+OGbIn VCprvZaf495nCZZV17G0iDRfZR8gOw7jvcWhiyFw27eX+hLbks0U1zrK0UMDotYyGukN qCIGReQ4jqugTrd4GqjFifknG5dISvzyTaIHORBOpFHNRlRhmRMCcGOlRs+oiv/MIGNN JLkw== X-Gm-Message-State: ABy/qLYLnZrPlQNl5F0kMI8fqhpD0IZynwshzZ+OsQ5U/QKyNoyjRS4/ U6342FmSL1mkzd2oweHH6ZyWGuMlULxhzPoqZw== X-Received: by 2002:ad4:5ce2:0:b0:634:7c34:6c6f with SMTP id iv2-20020ad45ce2000000b006347c346c6fmr2074259qvb.13.1688091283768; Thu, 29 Jun 2023 19:14:43 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id ea19-20020ad458b3000000b0062626bd3683sm7564128qvb.59.2023.06.29.19.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 19:14:43 -0700 (PDT) Date: Thu, 29 Jun 2023 22:14:42 -0400 Message-ID: From: Paul Moore To: Casey Schaufler , john.johansen@canonical.com, mic@digikod.net Cc: linux-security-module@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, keescook@chromium.org, penguin-kernel@i-love.sakura.ne.jp, stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v12 0/11] LSM: Three basic syscalls References: <20230629195535.2590-1-casey@schaufler-ca.com> In-Reply-To: <20230629195535.2590-1-casey@schaufler-ca.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,PP_MIME_FAKE_ASCII_TEXT, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 29, 2023 Casey Schaufler wrote: > > Add three system calls for the Linux Security Module ABI ... I saw two small things (see patches 7/11 and 8/11) when looking at the patchset today, but otherwise it looks pretty good to me. However, before I can merge this, at a minimum I would like to get an ACK from John on the AppArmor patch; an ACK or a Reviewed-by on the rest of the patchset would be great too. I know Mickaƫl has reviewed and commented on this patchset before, it would be nice if we could get his ACK/Reviewed-by too. Of course reviews and comments are always welcome from anyone who has looked over the code; this is an important patchset so the more eyes the better. Assuming no one catches anything further, I think we can get this into the lsm/next branch as soon as the merge window closes. Thanks for all your work on this Casey. -- paul-moore.com