Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <065fe185-4004-2329-f016-bb5161266094@axis.com>
Date:   Fri, 30 Jun 2023 09:23:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v1 2/2] dt: bindings: lp50xx: Add max-brightness as in
 leds-pwm
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>, Astrid Rost <astrid.rost@axis.com>
CC:     Dan Murphy <dmurphy@ti.com>, Andrew Davis <afd@ti.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>, <kernel@axis.com>,
        <linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230629134722.3908637-1-astrid.rost@axis.com>
 <20230629134722.3908637-3-astrid.rost@axis.com>
 <20230629175939.GA3260807-robh@kernel.org>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <20230629175939.GA3260807-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2duUGJWanhnM1R0elhSNTJmcDhyL0ovNWFlY3RlRHdvUStuU2dyWERIR2NO?=
 =?utf-8?B?WjhEZFBZVEhCVmU3eERoNzQ5TlUwUW01UU9QQ0g1S2dWb0NnZE0yN0F1TFN5?=
 =?utf-8?B?YUR6eUcvRWwraGNhYUhsb2kvSTJrQkcxQ2VoT1NIdFdLaXk1MlpkdGtjV1Za?=
 =?utf-8?B?YmUvcFNwRTd1UW5KNWJPTytJTUNiR0hkZ1lEKzBnRHZ0UjdhUnFzdEg5eG9S?=
 =?utf-8?B?YWhQeXozK2plRnNwTGhTVllOa3MxU0JzSFloU1B4ZGtod3lobkJJMWExbmhw?=
 =?utf-8?B?azNoYWlwM1MxRmpHNGxuRzlTclphWlVuV0lvWjlGUHVlNFJvWFpLZG1PZG9n?=
 =?utf-8?B?L2N0UFdVV2k4aEQzaStBNHBobWwrdEVva0lIZUZzNUxBcXQrNW5SNkNhTzVZ?=
 =?utf-8?B?ZFRmcnpzZlF2MC8rRkZZQXpHRTNDNkdlQ0NjNnN1STZqV0xNOXlwWEJmOXE5?=
 =?utf-8?B?bU82R0RBTUJnNXd6OUFiVXRyVnVJVDJmZ01FTEdqaCtTSkh6NlVHWU04WGpX?=
 =?utf-8?B?cUhoSS9vZlp6MmtJcnRTZktBL2pqNVR4TTVGVTRrRXl2S0JlVlRlcHZqQ044?=
 =?utf-8?B?c0RudnBld25uTE5NUVEyT1BvSUFRdHFhNDRFaFJmQWs5TnYzUFlXMi9nN3Vy?=
 =?utf-8?B?ZGV2THJPRFlNWHd1bDhLNkhVMUZVblBSUlVBRUNqZG0rTG5xUGg2YTdDR1kr?=
 =?utf-8?B?dmVYMXhNRnJNSHRhTXUya1pjUzNOYUlnOTAyZWEwWU5uU1doclBvZHdaOXQx?=
 =?utf-8?B?SUJjd2RRQ2lxbVQzd1ppQVYxRHlOSndqdjgya3YxTHlmaHJlN0pxMm9sOVBM?=
 =?utf-8?B?bnExZkFndGJBVW9LWEw5Q3BreUhDQzVsODZsNm16Z2lBa0JtVlR6by8vSno4?=
 =?utf-8?B?TjYycVVWejFIbDRucm1RL1FoM0JDUkI5UU1jV2VUSVg3d3p5OGJnRlhmQ0gr?=
 =?utf-8?B?QWhSMjJ3ajBodGZIL3NjOEloM3RZUUpNTGxYNzVaTUZHdkU3UE5jd3ZoVHls?=
 =?utf-8?B?VWRyYkhFOWNSZHdpdmVKMjd6TXdRZ1p4STU0ekVveDdMekVLNWRiMDBUUlBr?=
 =?utf-8?B?K0R5TXRIeHpXYm9rWVdDMlFlMERGVFB4TjdDTVc5ajJRSTRZd3diMGZaekJt?=
 =?utf-8?B?Q3IvTUFUS1ZMTDJ3NTdJb1htY1paY0NRdmNyWE9qNWVRcVIzODNsbE1OYml4?=
 =?utf-8?B?Z3NnREwrMS9OMTZRWmxFcG1mdnVGakdNRnNWUmNVWDhvSkJQSzdqeHUxWGJ4?=
 =?utf-8?B?LzNsY1BDOTVaVGJZY1hvL2NlYmJnb2ppdDJ3MWdKbjY1R3pTMnpRTWhvWXZI?=
 =?utf-8?B?RklKNTNSMjBhUThzUlUyUUgrRW5aZUIzdnQ2U1plTTFLZ1gwaHJnVEtydGs4?=
 =?utf-8?B?WVpUdmZJMGc5dEErQlNnS3hTZG5zclhsbkpoSi9SVmRYM1diWVYzYlZYOG1U?=
 =?utf-8?B?OW1nOW9TY1I2L24zN2FCVzgwQWl4ZjlHNVJqRy9qNmFscFJoT1VwcU15YjhX?=
 =?utf-8?B?cjNGWFBXb3NmMlBNSmpYVU1BeDdUSitRM3ErUytsTk1IY1R5YjRqcHBpV2J3?=
 =?utf-8?B?RTNqWGxER3EwZnM4eU85RHBJWVdLZjJzcnV1aVhHdWxBczkwN1RGa294STI5?=
 =?utf-8?B?T1BuZWdMQ2pHUmpaWmRVS3BzU1djZ2UwUmttaTZ1OHA1eHJJSTNSMDJxR25T?=
 =?utf-8?B?eFdJSkppd2s0MjlUYTRWYS9pa1dHYVRHUThNSlZFc2pySXhTN0VhWlB1TFJ2?=
 =?utf-8?B?ZGhybnZpeVRKWUtHZ2drTnBVMkZNdHR6dkVHMWE1N25STXhDeWM1eDRCYjY1?=
 =?utf-8?B?TytoTkFyZittS0NCU2lOVllacDJla3hLNjBycjhGNkI0SjBscEYvNnI4aU12?=
 =?utf-8?B?M1pDQkpxRUdOUEtjbTAxYnBYSHFsTXN6bklySDNQN0VpellhWk02VTE5bDh5?=
 =?utf-8?B?VHpsMW9CbnBSRmdFTklZZ3QzMzVrNnRKc1k0WmZITEVNLzFENVNKdit3cG8w?=
 =?utf-8?B?eTI1enBQc0dpRVpicE41TVd0TzdXb3Y5WmJWR1ZvY0k0WUJZWmtOTWRzMTAr?=
 =?utf-8?B?RXF3bU1ZYzdyQUc0WDNoSGxHVkRnUzhhYjVGMmI2Mzd1Y3hvcHdFZDIvemFE?=
 =?utf-8?Q?LqSA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 88e83c55-de04-4b15-ef42-08db793aea75
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 07:23:35.2985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9rzmCWL+afCtl++vJgV1QxBgaJM+5BrYK6uLIat3EnflCm36imyyeHarr2nmLSAU2mhjjd14zR/ZyyoEb7K1FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR02MB6879
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/23 19:59, Rob Herring wrote:
> On Thu, Jun 29, 2023 at 03:47:22PM +0200, Astrid Rost wrote:
>> Add max-brightness in order to reduce the current on the connected LEDs.
>> Normally, the maximum brightness is determined by the hardware, and this
>> property is not required. This property is used to set a software limit.
>> It could happen that an LED is made so bright that it gets damaged or
>> causes damage due to restrictions in a specific system, such as mounting
>> conditions.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>>   Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> index 402c25424525..6a1425969cb4 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> @@ -73,6 +73,15 @@ patternProperties:
>>         '#size-cells':
>>           const: 0
>>   
>> +      max-brightness:
>> +        description:
>> +          Normally, the maximum brightness is determined by the hardware, and
>> +          this property is not required. This property is used to set a software
>> +          limit. It could happen that an LED is made so bright that it gets
>> +          damaged or causes damage due to restrictions in a specific system,
>> +          such as mounting conditions.
>> +        $ref: /schemas/types.yaml#definitions/uint32
> 
> We already have led-max-microamp. If this h/w works by controlling the
> current, then that is what you should use. "max-brightness" makes more
> sense for PWM based control.

Yes, I looked into this. This LED controller TI-LP5024 has only one flag 
as max current option, which allows to set between 35 mA and the default 
value 25.5 mA. This is not enough for our application.

> 
> If you do end up keeping this, it belongs in the 'led' nodes not the
> controller as brightness is a property of the LED, not the LED
> driver(controller). And it should be in common schema rather than
> defining the type yet again.

I will look moving it into the the LED generic bindings as Andy 
suggested. max_brightness is already there and handled correctly. It is 
just a matter of reading it from the devicetree.

> 
> Rob