Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Wentong" <wentong.wu@intel.com>
To:     "Ye, Xiang" <xiang.ye@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "Matthias Kaehlcke" <mka@chromium.org>,
        Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@intel.com>,
        "Zhang, Lixu" <lixu.zhang@intel.com>
Subject: RE: [PATCH v5 1/5] usb: Add support for Intel LJCA device
Thread-Topic: [PATCH v5 1/5] usb: Add support for Intel LJCA device
Thread-Index: AQHZVRWD5foyHxgwkkK9uWFVvb93r6748VqAgAD7YwCAAAlegIAAdbQAgAAEFwCAASG9gICoCqlw
Date:   Fri, 30 Jun 2023 07:40:48 +0000
Message-ID: <DM6PR11MB43163C9D76023777B36380B98D2AA@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20230312190435.3568212-1-xiang.ye@intel.com>
 <20230312190435.3568212-2-xiang.ye@intel.com>
 <20230313170341.GV9667@google.com> <ZBAqTqZEDz/vAwVC@ye-NUC7i7DNHE>
 <ZBAyKQwnQ8fxHRuU@kuha.fi.intel.com> <ZBCU5h/A2woJLtvT@ye-NUC7i7DNHE>
 <ZBCYVNmoo2EdDY90@smile.fi.intel.com> <ZBGLYXxpkwokgV4R@kuha.fi.intel.com>
In-Reply-To: <ZBGLYXxpkwokgV4R@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6CU8VJ1VffSUwF4O76qGcWYxKdFaCwr4/R41GNHAuaIRkx3KDdG0+/3MZRg7?=
 =?us-ascii?Q?wxCECxLukDsN/ePZmID1ob0Mpo2KM1RIiaaGJHAln0Mv1mKoyQTWX4grIGEn?=
 =?us-ascii?Q?xBAN+N9WXY9VQCOEognJk6yhwlb5au/yLsJtgRVKaA0PUwa7PZs7nFcFHmcM?=
 =?us-ascii?Q?d24Lhff6yGtdUbJZOcwOFEclDZ6tef9MGOQPEZLNJL9glojcf1DI/pDCbtrd?=
 =?us-ascii?Q?WKxPphUKVeCOBv5BJ9flH0NyIV8wALRW8Wz60cvH5kVXNBD+ee2+XetaxB1A?=
 =?us-ascii?Q?I8ngChFhxea4nyit/JPOMiJtwqTKPkLIXF9E8QlZPnRlCDcfUHg25AXHHD2w?=
 =?us-ascii?Q?Y4SMpxJO2E2G4UFZ1g1898UeaHlkTWEEuuBjF0td9u4Wjuz2U/1FexDbFsjc?=
 =?us-ascii?Q?Izs/fWz9p3/RAcym10V2NUwGKSxkVIN1pW5vewjDN/4fbF42tLSwa4nOo+7A?=
 =?us-ascii?Q?YLy8gq5BdF/IBB4RNdpsP6lAcmKDr3Dtw9wn/eyz24J6NXZFpjorbwBsODpb?=
 =?us-ascii?Q?R7BKA7nK3zEVlW36ledUSwGwnzs+hCmXa/UdKElV4WArjhE69wiXFibA/ijS?=
 =?us-ascii?Q?RgLYMrD2N4TJB+IOfMA7Xp4SycsKIgNdiBONqGKfGCl1C1KOZoyfGADQry64?=
 =?us-ascii?Q?imwiSdhaZ3wzJYlPSOoDH9qcWnn8X7cc5FldzZRm2yA9NRahelLqI+gL/KJf?=
 =?us-ascii?Q?Zq6reaTT+PjtmhnmdCjSmHhQ0csjx211f+gAjZm8WoyoCn1erDW8CkCp2ESv?=
 =?us-ascii?Q?5KQEcYxes9nIiqg/S5RXO58QWtgRqbWWpPrHz1mg3Kx7ORyN0svbqObE/nFm?=
 =?us-ascii?Q?SGr5HnMhYndaqFMpgm0qR7LxeUVAY/ea2q6l/l/FWRPyiN1wy+2aK39XGhwc?=
 =?us-ascii?Q?AfyB3wmLXULeuYMeqd/wsIbq+wiGViTNAOTST71Chtco+iS+i/Qkzc6yKC+4?=
 =?us-ascii?Q?SbUm8bMumlMLj3ZerCwxpO4x9IvWX4snueeWl1+n22Pr6+baclWMWh9weTNg?=
 =?us-ascii?Q?mYgyqfusI0mh4EYjYUw2fPVVLimv4dAMLSxwBmh1n5pALsvzQamDM1h4fpQt?=
 =?us-ascii?Q?/nCHW1Wg9R0tK5o29InP11Fr84uUdXJMcOafyLm0spcA75t8UZYYTokHTy6Q?=
 =?us-ascii?Q?c9fQzXIZrTX30XyysdVQpIbXAqAHgQVbWMW9XvPpsKAvgYr0ZDXH8M9943IM?=
 =?us-ascii?Q?/VBAAwmoV3RdqgqK0HD5DVFvi+MqUKI0WdzJik+tmr3iHr4ST/8qMf+tkW5C?=
 =?us-ascii?Q?sQ0NZ85RYlsWpAWKmxVccIXqgetKxRj7h2IJFIzPmDjtmZIS2x+EUzvRqzaA?=
 =?us-ascii?Q?1VfEMxVJF1LBfq36vNqEJ3/9tlvV8Sj+Z9akVIli9DeaZUBVIyopuFBHMWq4?=
 =?us-ascii?Q?aQN4pT38sLV7Uyc9ylczeZtxV9SidU8JpkRs51E0eV21p7m7D1GxUfFlrsi4?=
 =?us-ascii?Q?tDS4gfOVeNiBB/4B3kF87naUSgNA/ptChElBouUJwo76IP5NcWXr7QM7ryAh?=
 =?us-ascii?Q?IZ8PojWHPxMLqDAZQI8x3TcJFVnOOcR+utX0g5W1TU2NzZQOruKx3RIufvRi?=
 =?us-ascii?Q?+eWOte+/MZ+vfJNGXOyiOFSnbNInBQKInoPHMftH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c90bd5c8-2d9c-447b-21b7-08db793d524c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 07:40:48.3648
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jxtKSvEB7KB+H4Ut3gbP3Tgu2A+tqJcDX0uPaJUVGRsSdt4bMI2CZVfc96NOUlOKF1O7pPL80S28bk23W4zsAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8388
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Wednesday, March 15, 2023 5:10 PM
>=20
> On Tue, Mar 14, 2023 at 05:52:52PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 14, 2023 at 11:38:14PM +0800, Ye, Xiang wrote:
> > > On Tue, Mar 14, 2023 at 10:36:57AM +0200, Heikki Krogerus wrote:
> > > > On Tue, Mar 14, 2023 at 04:03:26PM +0800, Ye, Xiang wrote:
> >
> > ...
> >
> > > > You don't really seem to get any benefit from MFD. Perhaps it
> > > > would be more appropriate and clear if you just registered
> > > > auxiliary devices in this driver. Check drivers/base/auxiliary.c.
> > > Yes, it should be a work. I have a question.
> > > MFD provides the ACPI binding for sub-devices through struct
> > > mfd_cell_acpi_match. But I didn't see this in drivers/base/auxiliary.=
c.
> > > If using auxiliary bus to implement the LJCA sub-devices, we need to
> > > do the sub-devices acpi binding manually in ljca.c.
> > >
> > > Something Like:
> > > adr =3D LJCA_ACPI_MATCH_GPIO
> > > adev =3D acpi_find_child_device(parent, adr, false);
> > > ACPI_COMPANION_SET(&pdev->dev, adev ?: parent);
> > >
> > > Is that acceptable?

This actually doesn't work, look at the acpi_find_child_device(), it compar=
es the
bus address specified by _ADR object, but there is no _ADR object in DSDT f=
or
these three devices because the relationship between the parent and childre=
n
isn't bus type listed in ACPI spec, so it always return NULL.

BR,
Wentong=20

>=20
> Looks ok to me.
>=20
> > Maybe you can implement this on the level of auxiliary bus.
>=20
> I would actually prefer that the auxiliary bus itself does not make any
> assumptions regarding the whereabouts of the fwnodes at this stage. Maybe
> later, when(if) there are more users.
>=20
> thanks,
>=20
> --
> heikki