Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 10:04:40 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Michal Simek <michal.simek@amd.com>
Cc:     Srinivas Goud <srinivas.goud@amd.com>, wg@grandegger.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, gcnu.goud@gmail.com, git@amd.com,
        michal.simek@xilinx.com, linux-can@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] can: xilinx_can: Add ECC feature support
Message-ID: <20230630-drop-down-sloped-d00e26bd9085-mkl@pengutronix.de>
References: <1686570177-2836108-1-git-send-email-srinivas.goud@amd.com>
 <20230616-unneeded-denote-eaa4053514d8-mkl@pengutronix.de>
 <8bda5b4b-54ac-0b20-4167-686856347e54@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="l4i42uioh2eh4lok"
Content-Disposition: inline
In-Reply-To: <8bda5b4b-54ac-0b20-4167-686856347e54@amd.com>
Precedence: bulk


--l4i42uioh2eh4lok
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 23.06.2023 09:48:16, Michal Simek wrote:
> Hi Marc,
>=20
> On 6/16/23 13:12, Marc Kleine-Budde wrote:
> > On 12.06.2023 17:12:54, Srinivas Goud wrote:
> > > ECC feature added to Tx and Rx FIFO=E2=80=99s for Xilinx CAN Controll=
er.
> > > Part of this feature configuration and counter registers added
> > > in Xilinx CAN Controller for 1bit/2bit ECC errors count and reset.
> > > Please find more details in PG096 v5.1 document.
> >=20
> > The document "PG096 (v5.1) May 16, 2023 CAN v5.1" [1] lists the
> > XCAN_ECC_CFG_OFFSET as reserved, although it has a section "ECC
> > Configuration Register".
> >=20
> > [1] https://docs.xilinx.com/viewer/book-attachment/Bv6XZP9HRonCGi58fl10=
dw/ch1ZLpOt4UKWNub7DXjJ7Q
> >=20
> > The other registers (XCAN_TXTLFIFO_ECC_OFFSET, XCAN_TXOLFIFO_ECC_OFFSET,
> > XCAN_TXOLFIFO_ECC_OFFSET) are also listed as reserved and not even
> > mentioned on the document. Am I missing something?
>=20
> We cross check available public documentation with HW team and there is no
> public documentation for this feature yet. We didn't get any exact day wh=
en
> documentation is going to be released.

It's a pity, but's that the way it's sometimes is.

> Unfortunately it is not the first or even last time when this is happening
> but I still think is good to get this feature done properly till the time
> when documentation catch it up. Please let me know if you have any concern
> about it.

No problem, update the cover letter and mention that the documentation
is not public available, yet. For reference we can keep the reference to
the internal doc (and mention that).

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--l4i42uioh2eh4lok
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmSejIkACgkQvlAcSiqK
BOgQDAgApM6bEsPxOTvK98GSqYgvFZHiuJ5Ikc7xLbAKqQcvTOcM24fzd4+NeXm7
DKj1h5BUg1TyiOUueBAhsf4jaKS1cRgi/MGLbKpcLn6nanhl5fhO7hnMcfk3cylg
gp/dVEwcIC/zCq8waYVD6zAbkKSzsK6UUO8u7+d0+wlWxK8XF9SfQBXN46bCD26+
4sP2Cm/S2Z9LIi36XZgKLAUoSdo8MnHkwcYYCSgAdZMcvG5d5sPPvMtU40cmmQhZ
fgvnU7lL8SP8/gtrTYG5/IH9BBP1/Af/quEspcu7JgOcelQftPdpun6rQT/P2O5B
kqNatB6pvlHBIkZY0pwWRGnjaNTqDA==
=sUaS
-----END PGP SIGNATURE-----

--l4i42uioh2eh4lok--