Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 16:01:38 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/12] KVM: x86: Add a framework for enabling
 KVM-governed x86 features
Message-ID: <ZJ6L4oWE9refbXnX@chao-email>
References: <20230217231022.816138-1-seanjc@google.com>
 <20230217231022.816138-2-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230217231022.816138-2-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L1Km8ysilYeLLcPwb2tveU0Wkb7R6qHRcfXGYfITWmUhLvYtRylPuYS29Uwe?=
 =?us-ascii?Q?7M6e42/MqlKU+9fQfEFtQJ9ZkaC3ElMGMUsUehMqgbpfYHw2zFauY3f2GHb1?=
 =?us-ascii?Q?kI9ZnpH41gDZW2FeIgzfnCNU2Zalcb6gYWY6hitbE+GMnL/n7ZVIXCS0TyIQ?=
 =?us-ascii?Q?aoIfNZh6ZK/qgpJFCNiyvH1uiBlhXmfd1EAo68zS96AjvL7ja6+OYzNFzVnI?=
 =?us-ascii?Q?73Eo5HN9G+uezAuTxfNO3C1BfvH8woCIxsbutO55hAlmoGHn0v6IWqY82EFP?=
 =?us-ascii?Q?4SDKK8bTozqTwZhD/CWxBsFWuPOpVbU90lxA5JDPrxtdhQeNhdQRAwjRX6hM?=
 =?us-ascii?Q?7KBLo/t+1gd04Fa2AqXEmlUkoz7oS+Z3qNZiDQHmrRm/j0k6blu70vQ0tMcg?=
 =?us-ascii?Q?Or36SYpuFxXwoTvO1V1GmlRvGskBpKh43AqLkTLXLx1Yc+TBJN2+59p0jYCe?=
 =?us-ascii?Q?50A8sX1375im2Fynj3ZJsQj2b8P6iH25lwqBT0J9rFx+90jMEtDujsbmHFug?=
 =?us-ascii?Q?+KP1tMrNufKY2fCylN5Q4X4bEbzrrmu6VX0JYjWG/xOR/hAgWxZHs9H2ct+k?=
 =?us-ascii?Q?6rkaZgcVX9BMS7WGjv6lf0xzZxilP0xcscyiUYbjO5+M15BwHjBFkgtHxYnt?=
 =?us-ascii?Q?amPEckwg72r/e+fYhgJV47bENG0LIn2c/+nJ9ixow8wnSsY7HiOM2CUO0Soo?=
 =?us-ascii?Q?7373ExaU2uDY8gWPQoVABmaEIGzCU4HbWcBwpEdIyf9qrbzHOCIMkh82wkbF?=
 =?us-ascii?Q?b/7D1To6kgvQqTyHbx+DJ+kf54cITd2noU0oiul5z1OTb3yrImmkm44StuK5?=
 =?us-ascii?Q?7bm+jRIfVUy8zOmEomFX95RJpnKcg7RTtL3dhTcSXftMa6e/dKdm20Tv1fL8?=
 =?us-ascii?Q?xt6oKEgIC0Md7WpihVhFeyhOoZOeWPzxqIUBA/NlRK66rNoMLEdJn9JnRe3o?=
 =?us-ascii?Q?1GCeLHMn+D8StYmseMlIpN12jr1lNICFOS+DH9xmkBb7xS2ZyBN9IIAYbeKy?=
 =?us-ascii?Q?8JJhFTjQm2wUQ12cxCPagVscXhsEUj8Gzk4FyRKwobS5BnIQq9n5kbhU00VX?=
 =?us-ascii?Q?A7/xT+sAl1FvxTWbpniG7W9tdEQ0iI3a1MQU02HxHRsYnO7q0HwSxkXvtOyY?=
 =?us-ascii?Q?He03aljj8GN3Bd0U3tT9H6pArfm1d05BnwnG5ag6FGgYuf9HjkjU08eaITkY?=
 =?us-ascii?Q?CSMDcPIn40rhqo5EYMH0gt2B6wYiV1nD3A9Z4+jK/oUSh7BrveUoC9z8Qqei?=
 =?us-ascii?Q?ZNiheImKxPOp2PV15Yliyx/EJm/Eo4TuVACLFdlAol0xaaqkW3/kWR96ENWe?=
 =?us-ascii?Q?pzmD5xI9wmN18dM3wLgQFY3PEeysk0/HqSmRQ5/8akCBp9VFZmAjHHdW8nSt?=
 =?us-ascii?Q?Q1vDyp+sv/BZ3LlUZPFHox280tZbwij5QKN5Wd1G+cBdBrayURCqrsh88uGg?=
 =?us-ascii?Q?Phtqcvl2qmdZATZe4d2uRzNZv/yNpHmmRSa9s+05Ta+qrPxOidkrDTbFFAXm?=
 =?us-ascii?Q?VyxVbiwy5Fo7cr/Sb1HNQ/QotZeXTi4JM9m4N+5s4zH1SGmlPUpRzjVm4OGS?=
 =?us-ascii?Q?rOxGIH1lxGuz+kNVGOwBF2E4JWm13fIB//YRRNLB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 887bc5e0-0a52-4f52-954e-08db79404189
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 08:01:48.8903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pt8cDo1YJ0Y7HJjNjREnSTy+xgoSZgaOrthkU+orpyvmlmaWQGqTSXeDXKL15QIlTri03qSHyGVXd9JC/FUP+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7436
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 03:10:11PM -0800, Sean Christopherson wrote:
>+static __always_inline void kvm_governed_feature_set(struct kvm_vcpu *vcpu,
>+						     unsigned int x86_feature)
>+{
>+	BUILD_BUG_ON(KVM_NR_GOVERNED_FEATURES >
>+		     sizeof(vcpu->arch.governed_features.enabled) * BITS_PER_BYTE);
>+
>+	vcpu->arch.governed_features.enabled |= kvm_governed_feature_bit(x86_feature);
>+}
>+
>+static __always_inline void kvm_governed_feature_check_and_set(struct kvm_vcpu *vcpu,
>+							       unsigned int x86_feature)
>+{
>+	if (guest_cpuid_has(vcpu, x86_feature))

Most callers in this series are conditional on either boot_cpu_has() or some
local variables. Can we convert them to kvm_cpu_cap_has() and incorporate them
within this function? i.e.,

	if (kvm_cpu_cap_has(x86_feature) && guest_cpuid_has(vcpu, x86_feature))


The benefits of doing so are
1. callers needn't repeat

	if (kvm_cpu_cap_has(x86_feature))
		kvm_governed_feature_check_and_set(x86_feature)

2. this fits the idea better that guests can use a governed feature only if host
   supports it _and_ QEMU exposes it to the guest.

>+		kvm_governed_feature_set(vcpu, x86_feature);
>+}
>+