Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Jun 2023 10:32:41 +0200
From:   Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas@t-8ch.de>
To:     Zhangjin Wu <falcon@tinylab.org>
Cc:     w@1wt.eu, arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 11/15] selftests/nolibc: prepare /tmp for tmpfs or
 ramfs
Message-ID: <457759dc-cd95-4474-a184-242bdb028445@t-8ch.de>
References: <cover.1688078604.git.falcon@tinylab.org>
 <9dc032064dde254a03e2111da1e58344deca6522.1688078605.git.falcon@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9dc032064dde254a03e2111da1e58344deca6522.1688078605.git.falcon@tinylab.org>
Precedence: bulk

On 2023-06-30 07:52:03+0800, Zhangjin Wu wrote:
> Let's create a /tmp directory and mount tmpfs there, if tmpfs is not
> mountable, use ramfs as tmpfs.
> 
> tmpfs will be used instead of procfs for some tests.
> 
> Signed-off-by: Zhangjin Wu <falcon@tinylab.org>
> ---
>  tools/testing/selftests/nolibc/nolibc-test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index c0f5302ada5d..8e3e2792f5e3 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -1054,6 +1054,10 @@ int prepare(void)
>  		}
>  	}
>  
> +	/* try to mount /tmp if not mounted, if not mountable, use ramfs as tmpfs */
> +	if (stat("/tmp/.", &stat_buf) == 0 || mkdir("/tmp", 0755) == 0)
> +		mount("none", "/tmp", "tmpfs", 0, 0);
> +

mkdir()
mount()

without any error checking should do the same and be easier to read.

>  	return 0;
>  }
>  
> -- 
> 2.25.1
>