Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp21997756rwd; Fri, 30 Jun 2023 02:28:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHvk/ZjEgfbMjTRfkks3CfdmWTQsrq373YHPUecT5i7Hqrxt5yQ7qYqDcvL89sYRj/6NqMI X-Received: by 2002:a05:6358:cc20:b0:134:e964:134c with SMTP id gx32-20020a056358cc2000b00134e964134cmr2107070rwb.11.1688117307785; Fri, 30 Jun 2023 02:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688117307; cv=none; d=google.com; s=arc-20160816; b=FKVTE4kS8ansJLcrcHPyBCrJ/bPiCdDh7C5ayYQPrLYmSkPX1piS+ximIBg2rLg3Kt 2qP4f1vLJ/wWssTV1q+swFbYr6IiJMiunyhnCD437am/fcRN8ynj+wKonyYO+r/wG1ND clkwoMJenjRpO9UJtlLQqtXulTVocIOVGXTTEDD1kLoQS3ZW34hE40fFU5Oa70NC78BM JgAXEMwmqOKQHXyoAZXlRnxJkWFz40CBgYc61GkBQ3oTo/geUG9BMxGnlMDQrznusLt/ /GNOJKNJV4AmqiEQIYR7E97LXh5sE731clXa3vHSNeGdlckoqhLhVbTzDIQ1JRPQGPVb pGkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j3GEhaNA0apRlT03hhOFTYFrxGOQIyTB0AkaO1T1KQQ=; fh=XnVgkJpQMUbzMWvAwzzqXzxjmg3bKsdXcwhAGRKYFe4=; b=kaVs8HbbbQMPx5e5VT3gELInU2P7p9neqeCSxeJ18zn4ztnOkE+GFxARvXdW/htCRh /BN8uNEaR20st2bfW5GCphX7BuUD55xzxWFaUbCeOpUZ7Kco/NL+0R4D9DDcaeZ8pLMD 8V2VI0gEjDoZIXUBURoRtCGkFGUxRSqO849PbS4lfOA8l9YXeYBF/+75teo+If1DAz3/ El2yrdiDytmQHMW5WNATl+gyVPr5JwpR8Bcl6IaJYPUxR3qWGQ6J9/A6Bo9TJY1SVzsI 9eOSVOMCqjl+4taU4d23gwh45L36BxA9qi5kroE5ft4Dsr6To5TrmSIkSR1Jz2fCuG0h OyOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=ARtNh02g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w7-20020a63fb47000000b005440b9f013csi12381822pgj.899.2023.06.30.02.28.14; Fri, 30 Jun 2023 02:28:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=ARtNh02g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbjF3JUp (ORCPT + 99 others); Fri, 30 Jun 2023 05:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232444AbjF3JT6 (ORCPT ); Fri, 30 Jun 2023 05:19:58 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D61B44B1 for ; Fri, 30 Jun 2023 02:19:27 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CB2422189C; Fri, 30 Jun 2023 09:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688116765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j3GEhaNA0apRlT03hhOFTYFrxGOQIyTB0AkaO1T1KQQ=; b=ARtNh02gLnlihH768pnMUpK2PYdehqY6uxev1Di3n+k98cR4mQlmkMzSfkf3LncAmI49wn yiR/DEFowAKXKSBPRK4SlYsJ4QDXZEZXuXh6mflFI9Z219zQoMBDfFrgNLDYLg+XZrjxcY HtN7M5t79qkAs03dyevmiNWIlq5ZOfI= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 00B2D2C141; Fri, 30 Jun 2023 09:19:22 +0000 (UTC) Date: Fri, 30 Jun 2023 11:19:22 +0200 From: Petr Mladek To: Douglas Anderson Cc: Andrew Morton , Randy Dunlap , Michael Ellerman , Christophe Leroy , Greg Kroah-Hartman , Haren Myneni , Jilin Yuan , Laurent Dufour , Luis Chamberlain , Nathan Lynch , Nicholas Piggin , Tom Rix , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Message-ID: References: <20230629124500.1.I55e2f4e7903d686c4484cb23c033c6a9e1a9d4c4@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629124500.1.I55e2f4e7903d686c4484cb23c033c6a9e1a9d4c4@changeid> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2023-06-29 12:45:06, Douglas Anderson wrote: > The powerpc/platforms/pseries/mobility.c calls > watchdog_hardlockup_set_timeout_pct(), which is declared in > . We used to automatically get included, but > that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define > HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. > > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org > Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH") > Signed-off-by: Douglas Anderson Thanks for the patch: Reviewed-by: Petr Mladek Best Regards, Petr