Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com>
 <1687955688-20809-12-git-send-email-quic_mojha@quicinc.com> <99c98f22-69f7-4a6a-acc9-6a6a6bdb2031@quicinc.com>
In-Reply-To: <99c98f22-69f7-4a6a-acc9-6a6a6bdb2031@quicinc.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 30 Jun 2023 12:25:22 +0300
Message-ID: <CAHp75Vd9+YHbExOQwK6bVHD016kB599yxUrj1PYFb__zENDi8g@mail.gmail.com>
Subject: Re: [PATCH v4 11/21] soc: qcom: Register pstore frontend region with minidump
To:     Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc:     Mukesh Ojha <quic_mojha@quicinc.com>, corbet@lwn.net,
        agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, keescook@chromium.org, tony.luck@intel.com,
        gpiccoli@igalia.com, mathieu.poirier@linaro.org,
        catalin.marinas@arm.com, will@kernel.org, linus.walleij@linaro.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 30, 2023 at 7:55=E2=80=AFAM Pavan Kondeti <quic_pkondeti@quicin=
c.com> wrote:
> On Wed, Jun 28, 2023 at 06:04:38PM +0530, Mukesh Ojha wrote:

...

> > +             scnprintf(name, sizeof(name), "KDMSG%d", i);

Also a side note: here you use the 'c' variant of sprintf(),why bother
with it if you don't even check the returned value?

--=20
With Best Regards,
Andy Shevchenko