Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aad9608b-34fa-1405-1fc4-5eb8d7d1647f@intel.com>
Date:   Fri, 30 Jun 2023 11:48:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before
 acpi_nfit_add()
Content-Language: en-US
To:     "Rafael J. Wysocki" <rafael@kernel.org>
CC:     <linux-acpi@vger.kernel.org>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <rui.zhang@intel.com>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>
References: <20230616165034.3630141-1-michal.wilczynski@intel.com>
 <20230616165034.3630141-8-michal.wilczynski@intel.com>
 <CAJZ5v0jjwk+jVsULD8nyguc7p00Sn3Hyxq7=PLNzpj-Fz6H6sg@mail.gmail.com>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <CAJZ5v0jjwk+jVsULD8nyguc7p00Sn3Hyxq7=PLNzpj-Fz6H6sg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3pOaVZJWGZoUitURXZaQ0YvUjk0aXdmQlVEU2hHVG82U05VT1JLY0pVMG5D?=
 =?utf-8?B?RzNnRG9aZ2JFRDBDWlFTWUR4OWdaK1MyR1NFM0RCZGdLUDY1eDFtSEphSzZT?=
 =?utf-8?B?LytOQXJwOUd1Z0lYYlB1SjBaRSsyb2Z4WEc3Vzl0dW9IWnNmYlpTc1lTUnlF?=
 =?utf-8?B?b0ZEaXZoRW9ZV3k3VGk3c1JEdUplLzlyMHBMOTU2WTlnMlo5OEZwV1FsMTM0?=
 =?utf-8?B?ZWFaSU9RWllRdGc0a0RIek4xTTc4NW9nZ0hWTDVaSThHZkZKWERMMFZzejRz?=
 =?utf-8?B?Nmptd0xlQTU4aVdVd3hDeVZhcmRROTBreHFiUTQ4Z1QyZllYWHRCNW1MOGV6?=
 =?utf-8?B?d2F2N3NWWit4L1poRE5tc1JEbCtvL0xybHR2RHplZnpoOEFWdFhmRDhoYjcw?=
 =?utf-8?B?Q0dXTXMvbFpoRGNnSnEwODAraXVUVTJuaUVDSUR4d1VIeGZ1TTVoYXhrdVJo?=
 =?utf-8?B?VVJFOEZUZTJ1ZlB2VjNPenBvSlJDRmthZ1JjZ1dPZFJtcUUrSEVMMmZDdnEr?=
 =?utf-8?B?UmlDYkxTcjhMTlhGK3UyQmNLOGdlcUNXd1lBZzBESFp4bHQ4TExpMDdGZ2Qx?=
 =?utf-8?B?WkZZWE1sbGpjNDAyN09WVlBMZVBuZWpYZkptd01iRkdNWjBmbEVCbENUVWtY?=
 =?utf-8?B?Rk1WYUdRS2xFVUdyYlkzWE1EYnJVei9xOW45L3hRT0RXOTlnRjVkZWhhVllp?=
 =?utf-8?B?WWdEVDNwSjkyQzdMQmxOMk1CV0FxbmpOSEFRc3o5SzVXR09CaHloTjFya0x6?=
 =?utf-8?B?dzE1VWZNNERPMUpwS3VyU054WTRVdjlQOHdxY3BRRHpXbklodm96QnM5VG5u?=
 =?utf-8?B?Y1dYWXI5Ynp1WHBDUG5Eb3I1ZUxKSlQ4L045OWF0UzN4cmJYcjRhdTdqNEd4?=
 =?utf-8?B?d3VlcjFNSVBSbS9yOUVOK2ZEdllTK3V2ODhMNDA2UGdkQk9ONEUzQ2JzMVFs?=
 =?utf-8?B?YzZ4MUZkKzRSY1ZHMXdpcFlUeEU4L3FzWjVCREt4Rm1MMURHSGxobm9VRVlT?=
 =?utf-8?B?WjFRdFlDVFMzVE9WaXlDUllLeVhwTWhNWElDWVFjNDd6UWpkV21mK0J1YWlJ?=
 =?utf-8?B?MHBZV0FVdjNROVFEQm81eHpCWDBVemRoREpDcSs3YkNUODgwQ2FMSzEzUURH?=
 =?utf-8?B?ZXd0VnIvOHd6U0FWaVRNVkkyRjY1dWVLL3oxM0ZES3pIUDU3U1g3bFlVQ1FQ?=
 =?utf-8?B?aHpLVGZPMWFBN3hhRVFHV1Q1YTNzQjZYRkU5ZXFOdlpITHkxeUhhWkFzbEVi?=
 =?utf-8?B?aGdEb0I3NDIwZk9XNHVXVkx6aEdjZERvQVF3RTRWdVlxRnJZa3JCSzVsMzJZ?=
 =?utf-8?B?eDErRTRSYjdMcVR4R2lTejR1elZsQ2ZtYUYrVDdrbUpaYkI0b011ZitlVjEx?=
 =?utf-8?B?NlRBdEdCeUtCSXBvSkI0aTV0UVR1VkxpTlVJckRZeWhNQi9rZWhnZVhvNXVy?=
 =?utf-8?B?NDZBOHd1NDlqUk4wYnZMV0t0am5vQTUzYlRpSmNHVzF3RmV4blBBa3pza3hG?=
 =?utf-8?B?OTZ0WncybVQ5RW1DbUg4dTN6MldaVjl0d05sQWk3YjI3ZlhTODBLVERESTRH?=
 =?utf-8?B?NlRhR1ErWkN4YW1JNlhRTXVDUEpxMXhNRGNUdDM3dzNVMFhkaVBWcmF6TjR3?=
 =?utf-8?B?NHlhYVVyZk9nQTNaUWhTMlI2Mm5YVUUxNEpQcEtRMW90dG1DOVk3Zzc2ekZW?=
 =?utf-8?B?dit3Q0FkU0FsWk5JVTJXNzQxVVo2eE43Z3RNQWxxampnYW05cVBlS1ByUmwy?=
 =?utf-8?B?SHM4Y1R6VER4TVFwNVA1Z0p6Z1JJckRyYWhlZGxGamVUYVQrL2dSNUNEdEMr?=
 =?utf-8?B?RWdnMkpJRU50ZWxvVm1iMW9BT0xOSklIYW0xZFRXVkhnQlM4cFJoaGVuQ0dO?=
 =?utf-8?B?NzlwbVA1dFYwNW5nM25IcWR2M0ZyaDN4WGhvRVNjR2pwSnZVL2V4VWEwNDFW?=
 =?utf-8?B?aGFsajlvald1d1FWRzQ3UmhyckFyZTRqWno4SGYxUzBzRFJPSmtCV3RlbW0v?=
 =?utf-8?B?alltYmM2Y0F1RXp2UlJjR0hrSlMyekpkK0c4bkg2VTE1RjgxSjZQbnpKZTlo?=
 =?utf-8?B?UU1oc3k3cU1BRktuT3pna1pBSnBlN3dCNW9hYXNSaGJWVWFNVWlrMXlrZzhN?=
 =?utf-8?B?OXJ1MDBmMnVHN0tXeVNFT2prY2JqMFNBUDBsekwzNjNtNVZyUFBWT0lxMG5P?=
 =?utf-8?B?aEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 63295cc1-4e0c-4347-b77f-08db794f2b57
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 09:48:34.1834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r0oJ9fgsibQqJLBey8KttO8W1VTSNxSpI7RTpoLc5oISY+tFRbwneRfe/mv7wfhnLPwWGWWhPIgbgnG7ofGM0vtUJ1Ms1VsB6Xsi9Isx5Z0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8602
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/2023 6:06 PM, Rafael J. Wysocki wrote:
> On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> <michal.wilczynski@intel.com> wrote:
>> To use new style of installing event handlers acpi_nfit_notify() needs
>> to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in
>> the file, so it can be used inside acpi_nfit_add().
>>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>>  drivers/acpi/nfit/core.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>> index 07204d482968..aff79cbc2190 100644
>> --- a/drivers/acpi/nfit/core.c
>> +++ b/drivers/acpi/nfit/core.c
>> @@ -3312,6 +3312,13 @@ void acpi_nfit_shutdown(void *data)
>>  }
>>  EXPORT_SYMBOL_GPL(acpi_nfit_shutdown);
>>
>> +static void acpi_nfit_notify(struct acpi_device *adev, u32 event)
>> +{
>> +       device_lock(&adev->dev);
>> +       __acpi_nfit_notify(&adev->dev, adev->handle, event);
>> +       device_unlock(&adev->dev);
>> +}
>> +
>>  static int acpi_nfit_add(struct acpi_device *adev)
>>  {
>>         struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL };
>> @@ -3446,13 +3453,6 @@ void __acpi_nfit_notify(struct device *dev, acpi_handle handle, u32 event)
>>  }
>>  EXPORT_SYMBOL_GPL(__acpi_nfit_notify);
>>
>> -static void acpi_nfit_notify(struct acpi_device *adev, u32 event)
>> -{
>> -       device_lock(&adev->dev);
>> -       __acpi_nfit_notify(&adev->dev, adev->handle, event);
>> -       device_unlock(&adev->dev);
>> -}
>> -
>>  static const struct acpi_device_id acpi_nfit_ids[] = {
>>         { "ACPI0012", 0 },
>>         { "", 0 },
>> --
> Please fold this patch into the next one.  By itself, it is an
> artificial change IMV.

I agree with you, but I got told specifically to do that.
https://lore.kernel.org/linux-acpi/e0f67199-9feb-432c-f0cb-7bdbdaf9ff63@linux.intel.com/