Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <699b327d-acea-c51d-874a-85133b74a73c@intel.com>
Date:   Fri, 30 Jun 2023 11:52:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in
 acpi_nfit_ids
Content-Language: en-US
To:     "Rafael J. Wysocki" <rafael@kernel.org>
CC:     <linux-acpi@vger.kernel.org>, <dan.j.williams@intel.com>,
        <vishal.l.verma@intel.com>, <lenb@kernel.org>,
        <dave.jiang@intel.com>, <ira.weiny@intel.com>,
        <rui.zhang@intel.com>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>
References: <20230616165034.3630141-1-michal.wilczynski@intel.com>
 <20230616165034.3630141-9-michal.wilczynski@intel.com>
 <CAJZ5v0hPY=nermvRKiyqGg4R+jLW13B-MUr0exEuEnw33VUj7g@mail.gmail.com>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <CAJZ5v0hPY=nermvRKiyqGg4R+jLW13B-MUr0exEuEnw33VUj7g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWwrdjlxYlpNVnJvT3MrQmcvVVZtNWJ3bE91eHFqN2ZzQkV6SFVKYWdGY1cz?=
 =?utf-8?B?OW05Y1B2dTdBeGNtSXl6cm1JakZ6aGtGYUdDODZBcktJSjNkcEFNa21YQUJY?=
 =?utf-8?B?cmVxVGtPM0RPWFZydTRlWmljbE45ZmdxV0gxcmwvQW9rMjN3Z1FuUE45NG9h?=
 =?utf-8?B?UktLaU4vRDFmQThQcmFCYSswQjJJSjc1Q3pjbkNSK0RBdlF4WXprOXdTNXA1?=
 =?utf-8?B?dDFsbWprOG1TLzJvdEJQYi9uQ0NRSG1VWm1kM3k0WWpaUUt1MWdpQlE1ajNV?=
 =?utf-8?B?Vk1yaytHOU5GR3VYTVcxVzk0TitzR1V6N3R6ckQrd0Y1WS9nOUwzTWhMVWtO?=
 =?utf-8?B?NWdYRWpDaFVQZmhENWkvQjh0d0dmUTRaSUhCbTVRNlJ1bmp4amNLejVVMlRM?=
 =?utf-8?B?YVh5TW4ySStKN1NNNHVEcFdNMmlEZlJybU9WNmxiamtkZnlJNGpMOTk3TkRh?=
 =?utf-8?B?SFNPV1MzOU9yUVpFeTJJb21ZbXprcTRFS1RzbW5Ybmt3VEFCRUpyYitvWlgx?=
 =?utf-8?B?cEhMZU92STRBaW15UU9jWkFaZitHWkFCeHo0RU1FSXplOHBHOXpydWQwWkpp?=
 =?utf-8?B?US93c0Q5U1NJUW5mS1Zub3YwNXFwdEZ3bUhSZWNUN3dVdkc5OHhLeWZqQTM4?=
 =?utf-8?B?SWgrNzdwaWx0dURXSHRMZm10a0NkTkJsMnpRN09OZmNJa3NNMTEvVFY5NGxR?=
 =?utf-8?B?WnZhUW01a1Q1OWk3MDJBdVFVQnVPbXJLTGNEUUl4Z1J5dlJmbTI3Zmg2c3k1?=
 =?utf-8?B?aGVSZlRGdDdDOXJYOTd6aXBMM3lKMVVnZmJuUkpZZTI3MHV1NEMydGdCdWpE?=
 =?utf-8?B?ZllQRk9xUzZoZ2ZxUUF2YWtjRWdFcFpCRWpGWlNDdXdkWllXdCtoMlJFMnBq?=
 =?utf-8?B?azh2RXozdlB3WmJ0RnpwMEhIaTFZamNSVXZydm1MWHQyQ3JCcDdrekJnbERO?=
 =?utf-8?B?amFLSmhVTTZ4MGlQQlFMdHA2ZWt3aU10dVgwN01Eb0JnbUcrK1UvZHFaNk00?=
 =?utf-8?B?YnRuWFJNWWlSZEsvVGJqL2NDbmdpZE96Y0lKTjU4NlZJNWhSek5rM002SHlw?=
 =?utf-8?B?Wm9pK1JQM0NmYjVzUHAyQ1p6NVFPVkFOSnovUkh0WG5UUWMwNzhIZGQ4emJR?=
 =?utf-8?B?R0dHZVc1cXExVjdZcjdpRGRwZ0ozZzlIZ0VZQ1YyT0w3RkNsZmdGYjZiNUJO?=
 =?utf-8?B?KzI2L1dWeVJuV0ROYVhLdWMvMUVLMnluUjh6a284QWNNejR6RWgrdHRkZjBu?=
 =?utf-8?B?TGNQa3ZRMGFjeTYwdGlSMFlhazJyOE4xUUI2aU9adjRselpDV2FSeWtlcnBP?=
 =?utf-8?B?a052WFVRNWcxU0lqWlBqaGtGKys2NTVhR2NmVGd4Rzc4ZXBzNE1mYTNKLzRZ?=
 =?utf-8?B?Y3lnODVBQlVJSER4dlJ5ZUJsNFdPdVNoNzNJdEJSVVlPU2hVMmlGMzNpVk5I?=
 =?utf-8?B?NFJKUG9BbzI4OElPbGN1QXI2S2dhVnF4TWJxUmlvazhidjdqSjd6OVNhOTBh?=
 =?utf-8?B?Y1pKUitVMVR0YlQ0VzFrT1pXR3BwM25CSkh5ZDRNTS93ZGxLNi9qUkNqbTZj?=
 =?utf-8?B?K3d3aWgycU5UZVNKRE5Wb0M5ZFF1UmJMaEtvNEdWN3FnK3F4VEVCeC9kQ3or?=
 =?utf-8?B?NDUxUHNJWWJvUldteG5VSGs5WmgxaXREdUV3WXA4bytyVG1vSHJKTFZhR25I?=
 =?utf-8?B?Z2ZuWmZrR2ZEd055M3A4SXUrdG5BSVp6NEJWYm4xSTByV003Rmczam1oWGFJ?=
 =?utf-8?B?MUhURjJWVSszVDRWWDJGb1JBSm1ac3o0S0pKQ1JKb0d1VXRTSURUQ2g4RWRy?=
 =?utf-8?B?VzcySWNPRHpNUk9XNU5TdlQzWnFHbWdORFJGK3BNY3dYU210ckhkYytDQkFO?=
 =?utf-8?B?WXdFUUFWQlc0Nm8zU1NHOXdwN1BId0l6Ky9mOE0zNjNrRGhEUnU3M2padlZR?=
 =?utf-8?B?ckRQQUtlVW8wNU5aWEJzeTUxNDZjQkNESGw5bXl4S0VYakR2UkV1SHhLL3hq?=
 =?utf-8?B?RVlianJMTEdsaitBd0R4WDNKQitZK0VwTUQ3Sm1YWEhleFNFcDkwZmcwS0hE?=
 =?utf-8?B?K0Voei9VZGhwM29NR2ZFSFZUU3FsbU1MMGlZY3hjcTVpZU14bUswMzI2YVMr?=
 =?utf-8?B?SVQ1S2gxL3oxWFJlUU5VNDAyTVZKMXNmbGsrMitGcDdvczRpZHNqMzV4ajJR?=
 =?utf-8?B?QlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f63b813-c1ad-4809-a85e-08db794fad2e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 09:52:12.0364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GABxD61SAwWhhTJ2+XbBV11LxDMjHYCBRsIKPSb45Yqpxd9Usdxs+q2ePsIoTud0kIXvyRzKp1uH4XZpd9ZncJA7TocF+upYNXD9lRB5qIk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7711
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote:
> On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> <michal.wilczynski@intel.com> wrote:
>> Currently terminator line contains redunant characters.
> Well, they are terminating the list properly AFAICS, so they aren't
> redundant and the size of it before and after the change is actually
> the same, isn't it?

This syntax is correct of course, but we have an internal guidelines specifically
saying that terminator line should NOT contain a comma at the end. Justification:

"Terminator line is established for the data structure arrays which may have unknown,
to the caller, sizes. The purpose of it is to stop iteration over an array and avoid
out-of-boundary access. Nevertheless, we may apply a bit more stricter rule to avoid
potential, but unlike, event of adding the entry after terminator, already at compile time.
This will be achieved by not putting comma at the end of terminator line"

>
>> Remove them and also remove a comma at the end.
> I suppose that this change is made for consistency with the other ACPI
> code, so this would be the motivation to give in the changelog.
>
> In any case, it doesn't seem to be related to the rest of the series.
>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>>  drivers/acpi/nfit/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>> index aff79cbc2190..95930e9d776c 100644
>> --- a/drivers/acpi/nfit/core.c
>> +++ b/drivers/acpi/nfit/core.c
>> @@ -3455,7 +3455,7 @@ EXPORT_SYMBOL_GPL(__acpi_nfit_notify);
>>
>>  static const struct acpi_device_id acpi_nfit_ids[] = {
>>         { "ACPI0012", 0 },
>> -       { "", 0 },
>> +       {}
>>  };
>>  MODULE_DEVICE_TABLE(acpi, acpi_nfit_ids);
>>
>> --
>> 2.41.0
>>